2024-06-11 01:21:36

by Jeff Johnson

Subject: [PATCH] PCI: add missing MODULE_DESCRIPTION() macros

When ARCH=x86, make allmodconfig && make W=1 C=1 reports:
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o
WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o

Add the missing invocations of the MODULE_DESCRIPTION() macro.

Signed-off-by: Jeff Johnson <[email protected]>
---
drivers/pci/pci-pf-stub.c | 1 +
drivers/pci/pci-stub.c | 1 +
2 files changed, 2 insertions(+)

diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c
index 45855a5e9fca..04815fcb0ce7 100644
--- a/drivers/pci/pci-pf-stub.c
+++ b/drivers/pci/pci-pf-stub.c
@@ -39,4 +39,5 @@ static struct pci_driver pf_stub_driver = {
};
module_pci_driver(pf_stub_driver);

+MODULE_DESCRIPTION("Simple stub driver for PCI SR-IOV PF device");
MODULE_LICENSE("GPL");
diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
index d1f4c1ce7bd1..d4fec791b321 100644
--- a/drivers/pci/pci-stub.c
+++ b/drivers/pci/pci-stub.c
@@ -92,5 +92,6 @@ static void __exit pci_stub_exit(void)
module_init(pci_stub_init);
module_exit(pci_stub_exit);

+MODULE_DESCRIPTION("Simple stub driver to reserve a PCI device");
MODULE_LICENSE("GPL");
MODULE_AUTHOR("Chris Wright <[email protected]>");

---
base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
change-id: 20240610-md-drivers-pci-831cb8f308a9

2024-06-13 22:21:55

by Bjorn Helgaas

Subject: Re: [PATCH] PCI: add missing MODULE_DESCRIPTION() macros

On Mon, Jun 10, 2024 at 06:21:16PM -0700, Jeff Johnson wrote:
> When ARCH=x86, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o
>
> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>
> Signed-off-by: Jeff Johnson <[email protected]>

Applied to pci/misc for v6.11, with updates to the text:

> ---
> drivers/pci/pci-pf-stub.c | 1 +
> drivers/pci/pci-stub.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/pci/pci-pf-stub.c b/drivers/pci/pci-pf-stub.c
> index 45855a5e9fca..04815fcb0ce7 100644
> --- a/drivers/pci/pci-pf-stub.c
> +++ b/drivers/pci/pci-pf-stub.c
> @@ -39,4 +39,5 @@ static struct pci_driver pf_stub_driver = {
> };
> module_pci_driver(pf_stub_driver);
>
> +MODULE_DESCRIPTION("Simple stub driver for PCI SR-IOV PF device");

+MODULE_DESCRIPTION("SR-IOV PF stub driver with no functionality");

> MODULE_LICENSE("GPL");
> diff --git a/drivers/pci/pci-stub.c b/drivers/pci/pci-stub.c
> index d1f4c1ce7bd1..d4fec791b321 100644
> --- a/drivers/pci/pci-stub.c
> +++ b/drivers/pci/pci-stub.c
> @@ -92,5 +92,6 @@ static void __exit pci_stub_exit(void)
> module_init(pci_stub_init);
> module_exit(pci_stub_exit);
>
> +MODULE_DESCRIPTION("Simple stub driver to reserve a PCI device");

+MODULE_DESCRIPTION("VM device assignment stub driver");

> MODULE_LICENSE("GPL");
> MODULE_AUTHOR("Chris Wright <[email protected]>");
>
> ---
> base-commit: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670
> change-id: 20240610-md-drivers-pci-831cb8f308a9
>

2024-06-13 22:22:37

by Jeff Johnson

Subject: Re: [PATCH] PCI: add missing MODULE_DESCRIPTION() macros

On 6/13/2024 3:20 PM, Bjorn Helgaas wrote:
> On Mon, Jun 10, 2024 at 06:21:16PM -0700, Jeff Johnson wrote:
>> When ARCH=x86, make allmodconfig && make W=1 C=1 reports:
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-stub.o
>> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/pci/pci-pf-stub.o
>>
>> Add the missing invocations of the MODULE_DESCRIPTION() macro.
>>
>> Signed-off-by: Jeff Johnson <[email protected]>
>
> Applied to pci/misc for v6.11, with updates to the text:

thanks for the cleanups!

/jeff