2023-05-16 16:05:17

by Krzysztof Kozlowski

Subject: [PATCH v2 1/3] arm64: dts: qcom: sm8550: enable DISPCC by default

Enable the Display Clock Controller by default in SoC DTSI so unused
clocks can be turned off. It does not require any external resources,
so as core SoC component should be always available to boards.

Suggested-by: Konrad Dybcio <[email protected]>
Signed-off-by: Krzysztof Kozlowski <[email protected]>

---

Changes in v2:
1. New patch
---
arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ----
arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 -
2 files changed, 5 deletions(-)

diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
index 785889450e8a..f27d5c657f44 100644
--- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
+++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
@@ -419,10 +419,6 @@ vreg_l3g_1p2: ldo3 {
};
};

-&dispcc {
- status = "okay";
-};
-
&mdss {
status = "okay";
};
diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
index 6e9bad8f6f33..0a3a08336b46 100644
--- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
+++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
@@ -2684,7 +2684,6 @@ dispcc: clock-controller@af00000 {
#clock-cells = <1>;
#reset-cells = <1>;
#power-domain-cells = <1>;
- status = "disabled";
};

usb_1_hsphy: phy@88e3000 {
--
2.34.1

2023-05-16 16:30:56

by Dmitry Baryshkov

Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sm8550: enable DISPCC by default

On Tue, 16 May 2023 at 18:46, Krzysztof Kozlowski
<[email protected]> wrote:
>
> Enable the Display Clock Controller by default in SoC DTSI so unused
> clocks can be turned off. It does not require any external resources,
> so as core SoC component should be always available to boards.
>
> Suggested-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Reviewed-by: Dmitry Baryshkov <[email protected]>

>
> ---
>
> Changes in v2:
> 1. New patch
> ---
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ----
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 -
> 2 files changed, 5 deletions(-)

--
With best wishes
Dmitry

2023-05-16 16:31:18

by Konrad Dybcio

Subject: Re: [PATCH v2 1/3] arm64: dts: qcom: sm8550: enable DISPCC by default

On 16.05.2023 17:45, Krzysztof Kozlowski wrote:
> Enable the Display Clock Controller by default in SoC DTSI so unused
> clocks can be turned off. It does not require any external resources,
> so as core SoC component should be always available to boards.
>
> Suggested-by: Konrad Dybcio <[email protected]>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> ---
Reviewed-by: Konrad Dybcio <[email protected]>

Konrad
>
> Changes in v2:
> 1. New patch
> ---
> arch/arm64/boot/dts/qcom/sm8550-mtp.dts | 4 ----
> arch/arm64/boot/dts/qcom/sm8550.dtsi | 1 -
> 2 files changed, 5 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> index 785889450e8a..f27d5c657f44 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> +++ b/arch/arm64/boot/dts/qcom/sm8550-mtp.dts
> @@ -419,10 +419,6 @@ vreg_l3g_1p2: ldo3 {
> };
> };
>
> -&dispcc {
> - status = "okay";
> -};
> -
> &mdss {
> status = "okay";
> };
> diff --git a/arch/arm64/boot/dts/qcom/sm8550.dtsi b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> index 6e9bad8f6f33..0a3a08336b46 100644
> --- a/arch/arm64/boot/dts/qcom/sm8550.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm8550.dtsi
> @@ -2684,7 +2684,6 @@ dispcc: clock-controller@af00000 {
> #clock-cells = <1>;
> #reset-cells = <1>;
> #power-domain-cells = <1>;
> - status = "disabled";
> };
>
> usb_1_hsphy: phy@88e3000 {

2023-05-25 05:44:41

by Bjorn Andersson

Subject: Re: (subset) [PATCH v2 1/3] arm64: dts: qcom: sm8550: enable DISPCC by default

On Tue, 16 May 2023 17:45:37 +0200, Krzysztof Kozlowski wrote:
> Enable the Display Clock Controller by default in SoC DTSI so unused
> clocks can be turned off. It does not require any external resources,
> so as core SoC component should be always available to boards.
>
>

Applied, thanks!

[1/3] arm64: dts: qcom: sm8550: enable DISPCC by default
commit: 5ef00c06ea5e4e0de1f63d2c620f671750f73f9b
[2/3] arm64: dts: qcom: sm8550-mtp: drop redundant MDP status
commit: fbeffa580e30fe7fb748e4ccc39c2b18a137c055
[3/3] arm64: dts: qcom: sm8550-qrd: add display and panel
commit: fdb0038e96659f08dae575aae6b4b6b22884d17b

Best regards,
--
Bjorn Andersson <[email protected]>