2005-11-23 17:36:38

by Andi Kleen

[permalink] [raw]
Subject: Re: [LinuxBIOS] x86_64: apic id lift patch

On Wed, Nov 23, 2005 at 09:19:59AM -0800, yhlu wrote:
> sth about SRAT in LinuxBIOS, I have put SRAT dynamically support in
> LinuxBIOS, but the whole acpi support still need dsdt, current we only have
> dsdt for AMD chipset in LB. And we can not have the access the dsdt asl from
> Nvidia chipset yet...

You probably don't need most of it. Just a basic SRAT table (no AML methods)
and enough to keep the ACPI interpreter from aborting early.

Or alternatively just fix the bug that caused you to go with discontig
APICs in the first place.

-Andi


2005-11-23 17:40:31

by yhlu

[permalink] [raw]
Subject: Re: [LinuxBIOS] x86_64: apic id lift patch

is there any way to make the kernel use apci but still use pci irq
routing from mptable?

YH

On 11/23/05, Andi Kleen <[email protected]> wrote:
> On Wed, Nov 23, 2005 at 09:19:59AM -0800, yhlu wrote:
> > sth about SRAT in LinuxBIOS, I have put SRAT dynamically support in
> > LinuxBIOS, but the whole acpi support still need dsdt, current we only have
> > dsdt for AMD chipset in LB. And we can not have the access the dsdt asl from
> > Nvidia chipset yet...
>
> You probably don't need most of it. Just a basic SRAT table (no AML methods)
> and enough to keep the ACPI interpreter from aborting early.
>
> Or alternatively just fix the bug that caused you to go with discontig
> APICs in the first place.
>
> -Andi
>

2005-11-23 18:18:10

by Stefan Reinauer

[permalink] [raw]
Subject: Re: [LinuxBIOS] x86_64: apic id lift patch

* yhlu <[email protected]> [051123 18:40]:
> is there any way to make the kernel use apci but still use pci irq
> routing from mptable?

Yes, don't provide any of MADT, DSDT, FADT.

Stefan

2005-11-23 18:17:13

by Stefan Reinauer

[permalink] [raw]
Subject: Re: [LinuxBIOS] x86_64: apic id lift patch

* Andi Kleen <[email protected]> [051123 18:36]:
> You probably don't need most of it. Just a basic SRAT table (no AML methods)
> and enough to keep the ACPI interpreter from aborting early.
>
> Or alternatively just fix the bug that caused you to go with discontig
> APICs in the first place.

Andi,

I really like your insisting way, but what we tried to express is that
there is hardware that just forces you to have discontiguous APIC ids,
so either you disable parts of the hardware or you are forced to do
nasty things.

Wrt the ACPI tables a good rule of thumb is that if you start to have
some of them you have to have them all. For example if you have a logical
subset of them and try to cover the rest with PIRQ or MPTABLE you will
fail because Linux moans about incorrect tables without even looking at
them. And no, there is no reason for not reading a HPET table when
there's no MADT available. And no, I'm not going to send a fix since I'm
really not motivated to dig into that code any minute more than
absolutely necessary.

I agree that there's a reason that the Linux ACPI code is as it is, but
in fact as it is a reaction to zillions of buggy bioses it is not always
the best solution to have clean firmware not working with it "fixed" to
behave like the others out there.

Stefan


2005-11-23 18:22:21

by yhlu

[permalink] [raw]
Subject: Re: [LinuxBIOS] x86_64: apic id lift patch

only RSDT+SRAT?, I will try it....

YH

On 11/23/05, Stefan Reinauer <[email protected]> wrote:
> * yhlu <[email protected]> [051123 18:40]:
> > is there any way to make the kernel use apci but still use pci irq
> > routing from mptable?
>
> Yes, don't provide any of MADT, DSDT, FADT.
>
> Stefan
>
>

2005-11-23 18:35:22

by yhlu

[permalink] [raw]
Subject: Re: [LinuxBIOS] x86_64: apic id lift patch

it doesn't work. At that case must disable the apci in kernel...(acpi=off)

YH

On 11/23/05, yhlu <[email protected]> wrote:
> only RSDT+SRAT?, I will try it....
>
> YH
>
> On 11/23/05, Stefan Reinauer <[email protected]> wrote:
> > * yhlu <[email protected]> [051123 18:40]:
> > > is there any way to make the kernel use apci but still use pci irq
> > > routing from mptable?
> >
> > Yes, don't provide any of MADT, DSDT, FADT.
> >
> > Stefan
> >
> >
>

2005-11-23 20:29:08

by Andi Kleen

[permalink] [raw]
Subject: Re: [discuss] Re: [LinuxBIOS] x86_64: apic id lift patch

On Wed, Nov 23, 2005 at 10:35:19AM -0800, yhlu wrote:
> it doesn't work. At that case must disable the apci in kernel...(acpi=off)

Shouldn't be very hard to fix in the kernel though
(to use only SRAT and nothing else of ACPI). I can look
into it if nobody beats me to it

-Andi