2017-11-21 11:48:35

by Peter Ujfalusi

[permalink] [raw]
Subject: Re: [PATCH 05/10] dmaengine: bcm2835-dma: Use vchan_terminate_vdesc() instead of desc_free

Eric,

On 11/15/2017 08:53 PM, Eric Anholt wrote:
> Peter Ujfalusi <[email protected]> writes:
>
>> To avoid race with vchan_complete, use the race free way to terminate
>> running transfer.
>>
>> Implement the device_synchronize callback to make sure that the terminated
>> descriptor is freed.
>>
>> CC: Martin Sperl <[email protected]>
>> CC: Eric Anholt <[email protected]>
>> Signed-off-by: Peter Ujfalusi <[email protected]>
>
> I haven't fully followed the series, but thanks for porting your fix to
> other platforms!
I have seen similar patterns in these drivers and it was the right thing to do
imho.
Unfortunately I can not test on other platforms than eDMA and sDMA, but I
firmly believe that based on the usage it should be fine as it survives my
torture tests.

It would be great to see some Tested-by from others to have more coverage.

> Acked-by: Eric Anholt <[email protected]>

Thank you!


--
Péter

Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki

From 1584175733188183769@xxx Wed Nov 15 23:15:09 +0000 2017
X-GM-THRID: 1584052564070608420
X-Gmail-Labels: Inbox,Category Forums,HistoricalUnread