2023-07-21 05:01:23

by Varadarajan Narayanan

[permalink] [raw]
Subject: [PATCH v5 0/6] Enable IPQ5332 USB2

This patch series adds the relevant phy and controller
configurations for enabling USB2 on IPQ5332

v5:
Binding and dts:-
Fix email id
Removed 'Reviewed-by: Krzysztof Kozlowski <[email protected]>'
as had to change bindings file to be able to use generic phy instead of
usb-phy

Driver:-
Remove unused definition
Use generic phy instead of usb-phy
v4:
Binding and dts:-
Change node name (bindings & dts)
Driver:-
Remove unused enum
static const for '.data'
Error handling for devm_clk_get
v3:
Fix bindings file based on review comments

v1:
Cleanup DTS
Combine driver, kconfig and makefile patches
Remove unused functions from M31 driver
Drop the clock driver changes

Varadarajan Narayanan (6):
dt-bindings: usb: dwc3: Add IPQ5332 compatible
dt-bindings: phy: qcom,m31: Document qcom,m31 USB phy
phy: qcom-m31: Introduce qcom,m31 USB phy driver
arm64: dts: qcom: ipq5332: Add USB related nodes
arm64: dts: qcom: ipq5332: Enable USB
arm64: defconfig: Enable M31 USB phy driver

.../bindings/phy/qcom,ipq5332-usb-hsphy.yaml | 51 ++++
.../devicetree/bindings/usb/qcom,dwc3.yaml | 3 +
arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 +
arch/arm64/boot/dts/qcom/ipq5332.dtsi | 56 +++++
arch/arm64/configs/defconfig | 1 +
drivers/phy/qualcomm/Kconfig | 11 +
drivers/phy/qualcomm/Makefile | 1 +
drivers/phy/qualcomm/phy-qcom-m31.c | 264 +++++++++++++++++++++
8 files changed, 399 insertions(+)
create mode 100644 Documentation/devicetree/bindings/phy/qcom,ipq5332-usb-hsphy.yaml
create mode 100644 drivers/phy/qualcomm/phy-qcom-m31.c

--
2.7.4



2023-07-21 05:08:11

by Varadarajan Narayanan

[permalink] [raw]
Subject: [PATCH v5 5/6] arm64: dts: qcom: ipq5332: Enable USB

Enable USB2 in host mode.

Signed-off-by: Varadarajan Narayanan <[email protected]>
---
v1:
Enable usb-phy node
---
arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 ++++++++++++
1 file changed, 12 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
index f96b0c8..f5dea16 100644
--- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
+++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
@@ -79,3 +79,15 @@
bias-pull-up;
};
};
+
+&usbphy0 {
+ status = "okay";
+};
+
+&usb2 {
+ status = "okay";
+};
+
+&usb2_0_dwc {
+ dr_mode = "host";
+};
--
2.7.4


2023-07-22 05:49:43

by Bjorn Andersson

[permalink] [raw]
Subject: Re: [PATCH v5 5/6] arm64: dts: qcom: ipq5332: Enable USB

On Fri, Jul 21, 2023 at 10:05:30AM +0530, Varadarajan Narayanan wrote:
> Enable USB2 in host mode.
>
> Signed-off-by: Varadarajan Narayanan <[email protected]>
> ---
> v1:
> Enable usb-phy node
> ---
> arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> index f96b0c8..f5dea16 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> +++ b/arch/arm64/boot/dts/qcom/ipq5332-rdp468.dts
> @@ -79,3 +79,15 @@
> bias-pull-up;
> };
> };
> +
> +&usbphy0 {
> + status = "okay";

Is this phy not powered? Should there be some regulators controlled?

Regards,
Bjorn