2023-09-28 08:34:27

by Bartosz Golaszewski

[permalink] [raw]
Subject: Re: [PATCH] hte: allow building modules with COMPILE_TEST enabled

On Thu, Sep 28, 2023 at 5:31 AM Dipen Patel <[email protected]> wrote:
>
> On 9/25/23 1:37 AM, Bartosz Golaszewski wrote:
> > On Mon, Sep 11, 2023 at 11:46 AM Bartosz Golaszewski <[email protected]> wrote:
> >>
> >> From: Bartosz Golaszewski <[email protected]>
> >>
> >> Allow building all HTE modules with COMPILE_TEST Kconfig option enabled.
> >>
> >> Signed-off-by: Bartosz Golaszewski <[email protected]>
> >> Acked-by: Linus Walleij <[email protected]>
> >> ---
> >> This was part of a wider series but since this is independent, I'm sending
> >> it separately.
> >>
> >> drivers/hte/Kconfig | 4 ++--
> >> 1 file changed, 2 insertions(+), 2 deletions(-)
> >>
> >> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
> >> index cf29e0218bae..083e67492bf2 100644
> >> --- a/drivers/hte/Kconfig
> >> +++ b/drivers/hte/Kconfig
> >> @@ -16,7 +16,7 @@ if HTE
> >>
> >> config HTE_TEGRA194
> >> tristate "NVIDIA Tegra194 HTE Support"
> >> - depends on ARCH_TEGRA_194_SOC
> >> + depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
> >> help
> >> Enable this option for integrated hardware timestamping engine also
> >> known as generic timestamping engine (GTE) support on NVIDIA Tegra194
> >> @@ -25,7 +25,7 @@ config HTE_TEGRA194
> >>
> >> config HTE_TEGRA194_TEST
> >> tristate "NVIDIA Tegra194 HTE Test"
> >> - depends on HTE_TEGRA194
> >> + depends on (HTE_TEGRA194 || COMPILE_TEST)
> >> help
> >> The NVIDIA Tegra194 GTE test driver demonstrates how to use HTE
> >> framework to timestamp GPIO and LIC IRQ lines.
> >> --
> >> 2.39.2
> >>
> >
> > Hi Dipen!
> >
> > Any comments on this, the other patch with a comment update as well as
> > the one addressing usage of gpiochip_find() in HTE drivers?
> Sorry for the late response, This looks good to me. I will review and test
> rest other patches.
>
> >
> > Bart
> Acked-by: Dipen Patel <[email protected]>

Do you want me to take it through the GPIO tree or your own? Either
way no GPIO patches depend on it.

Bart


2023-09-30 09:17:19

by Dipen Patel

[permalink] [raw]
Subject: Re: [PATCH] hte: allow building modules with COMPILE_TEST enabled

On 9/27/23 11:53 PM, Bartosz Golaszewski wrote:
> On Thu, Sep 28, 2023 at 5:31 AM Dipen Patel <[email protected]> wrote:
>>
>> On 9/25/23 1:37 AM, Bartosz Golaszewski wrote:
>>> On Mon, Sep 11, 2023 at 11:46 AM Bartosz Golaszewski <[email protected]> wrote:
>>>>
>>>> From: Bartosz Golaszewski <[email protected]>
>>>>
>>>> Allow building all HTE modules with COMPILE_TEST Kconfig option enabled.
>>>>
>>>> Signed-off-by: Bartosz Golaszewski <[email protected]>
>>>> Acked-by: Linus Walleij <[email protected]>
>>>> ---
>>>> This was part of a wider series but since this is independent, I'm sending
>>>> it separately.
>>>>
>>>> drivers/hte/Kconfig | 4 ++--
>>>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>>>
>>>> diff --git a/drivers/hte/Kconfig b/drivers/hte/Kconfig
>>>> index cf29e0218bae..083e67492bf2 100644
>>>> --- a/drivers/hte/Kconfig
>>>> +++ b/drivers/hte/Kconfig
>>>> @@ -16,7 +16,7 @@ if HTE
>>>>
>>>> config HTE_TEGRA194
>>>> tristate "NVIDIA Tegra194 HTE Support"
>>>> - depends on ARCH_TEGRA_194_SOC
>>>> + depends on (ARCH_TEGRA_194_SOC || COMPILE_TEST)
>>>> help
>>>> Enable this option for integrated hardware timestamping engine also
>>>> known as generic timestamping engine (GTE) support on NVIDIA Tegra194
>>>> @@ -25,7 +25,7 @@ config HTE_TEGRA194
>>>>
>>>> config HTE_TEGRA194_TEST
>>>> tristate "NVIDIA Tegra194 HTE Test"
>>>> - depends on HTE_TEGRA194
>>>> + depends on (HTE_TEGRA194 || COMPILE_TEST)
>>>> help
>>>> The NVIDIA Tegra194 GTE test driver demonstrates how to use HTE
>>>> framework to timestamp GPIO and LIC IRQ lines.
>>>> --
>>>> 2.39.2
>>>>
>>>
>>> Hi Dipen!
>>>
>>> Any comments on this, the other patch with a comment update as well as
>>> the one addressing usage of gpiochip_find() in HTE drivers?
>> Sorry for the late response, This looks good to me. I will review and test
>> rest other patches.
>>
>>>
>>> Bart
>> Acked-by: Dipen Patel <[email protected]>
>
> Do you want me to take it through the GPIO tree or your own? Either
> way no GPIO patches depend on it.
This patch I should be able to push, assuming it is for 6.7 timeframe. Do other HTE patches depend on
any of your GPIO patches?

>
> Bart