2019-05-21 15:05:33

by Neil Armstrong

[permalink] [raw]
Subject: [PATCH 0/3] clk: meson: add support for Amlogic G12A

The Amlogic G12B SoC is very similar with the G12A SoC, sharing
most of the features and architecture.
G12B clock tree is very close, the main differences are :
- SYS_PLL is used for the second cluster (otherwise used fir the first on G12a)
- SYS_PLL1 is used for the first cluster (instead of SYS_PLL on G12a)
- A duplicate CPU tree is added for the second cluster
- G12A has additional clocks like for CSI an other components, not handled yet

Dependencies :
- Patch 1, 3 : None
- Patch 2 : Depends on Guillaume's Temperature sensor Clock patches at [1]

This patchset is a spinoff of the v2 Odroid-N2 megapatchset at [2]

Changes since original pathset :
- Added missing sys1_pll div16, cpub div16 and cpub atb/axi/ahb/trace clocks
- Rewrote "This patch .." in commit messages

[1] https://lkml.kernel.org/r/[email protected]
[2] https://lkml.kernel.org/r/[email protected]

Neil Armstrong (3):
dt-bindings: clk: meson: add g12b periph clock controller bindings
clk: meson: g12a: Add support for G12B CPUB clocks
clk: meson: g12a: mark fclk_div3 as critical

.../bindings/clock/amlogic,gxbb-clkc.txt | 1 +
drivers/clk/meson/g12a.c | 659 ++++++++++++++++++
drivers/clk/meson/g12a.h | 33 +-
3 files changed, 692 insertions(+), 1 deletion(-)

--
2.21.0



2019-05-21 15:07:19

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 0/3] clk: meson: add support for Amlogic G12A

On 21/05/2019 17:01, Neil Armstrong wrote:
> The Amlogic G12B SoC is very similar with the G12A SoC, sharing
> most of the features and architecture.
> G12B clock tree is very close, the main differences are :
> - SYS_PLL is used for the second cluster (otherwise used fir the first on G12a)
> - SYS_PLL1 is used for the first cluster (instead of SYS_PLL on G12a)
> - A duplicate CPU tree is added for the second cluster
> - G12A has additional clocks like for CSI an other components, not handled yet
>
> Dependencies :
> - Patch 1, 3 : None
> - Patch 2 : Depends on Guillaume's Temperature sensor Clock patches at [1]
>
> This patchset is a spinoff of the v2 Odroid-N2 megapatchset at [2]
>
> Changes since original pathset :
> - Added missing sys1_pll div16, cpub div16 and cpub atb/axi/ahb/trace clocks
> - Rewrote "This patch .." in commit messages
>
> [1] https://lkml.kernel.org/r/[email protected]
> [2] https://lkml.kernel.org/r/[email protected]
>
> Neil Armstrong (3):
> dt-bindings: clk: meson: add g12b periph clock controller bindings
> clk: meson: g12a: Add support for G12B CPUB clocks
> clk: meson: g12a: mark fclk_div3 as critical
>
> .../bindings/clock/amlogic,gxbb-clkc.txt | 1 +
> drivers/clk/meson/g12a.c | 659 ++++++++++++++++++
> drivers/clk/meson/g12a.h | 33 +-
> 3 files changed, 692 insertions(+), 1 deletion(-)
>

The subject is wrong, it should be "clk: meson: add support for Amlogic G12B"

Neil

2019-05-21 15:23:27

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 0/3] clk: meson: add support for Amlogic G12A

On 21/05/2019 17:01, Neil Armstrong wrote:
> The Amlogic G12B SoC is very similar with the G12A SoC, sharing
> most of the features and architecture.
> G12B clock tree is very close, the main differences are :
> - SYS_PLL is used for the second cluster (otherwise used fir the first on G12a)
> - SYS_PLL1 is used for the first cluster (instead of SYS_PLL on G12a)
> - A duplicate CPU tree is added for the second cluster
> - G12A has additional clocks like for CSI an other components, not handled yet
>
> Dependencies :
> - Patch 1, 3 : None
> - Patch 2 : Depends on Guillaume's Temperature sensor Clock patches at [1]
>
> This patchset is a spinoff of the v2 Odroid-N2 megapatchset at [2]
>
> Changes since original pathset :
> - Added missing sys1_pll div16, cpub div16 and cpub atb/axi/ahb/trace clocks
> - Rewrote "This patch .." in commit messages
>
> [1] https://lkml.kernel.org/r/[email protected]
> [2] https://lkml.kernel.org/r/[email protected]
>
> Neil Armstrong (3):
> dt-bindings: clk: meson: add g12b periph clock controller bindings
> clk: meson: g12a: Add support for G12B CPUB clocks
> clk: meson: g12a: mark fclk_div3 as critical
>
> .../bindings/clock/amlogic,gxbb-clkc.txt | 1 +
> drivers/clk/meson/g12a.c | 659 ++++++++++++++++++
> drivers/clk/meson/g12a.h | 33 +-
> 3 files changed, 692 insertions(+), 1 deletion(-)
>

And I forgot Martins reviews...
It should still apply to patch 1, patch 2 has changed with new clocks.

Neil

2019-05-21 15:37:41

by Jerome Brunet

[permalink] [raw]
Subject: Re: [PATCH 0/3] clk: meson: add support for Amlogic G12A

On Tue, 2019-05-21 at 17:21 +0200, Neil Armstrong wrote:
> On 21/05/2019 17:01, Neil Armstrong wrote:
> > The Amlogic G12B SoC is very similar with the G12A SoC, sharing
> > most of the features and architecture.
> > G12B clock tree is very close, the main differences are :
> > - SYS_PLL is used for the second cluster (otherwise used fir the first on G12a)
> > - SYS_PLL1 is used for the first cluster (instead of SYS_PLL on G12a)
> > - A duplicate CPU tree is added for the second cluster
> > - G12A has additional clocks like for CSI an other components, not handled yet
> >
> > Dependencies :
> > - Patch 1, 3 : None
> > - Patch 2 : Depends on Guillaume's Temperature sensor Clock patches at [1]
> >
> > This patchset is a spinoff of the v2 Odroid-N2 megapatchset at [2]
> >
> > Changes since original pathset :
> > - Added missing sys1_pll div16, cpub div16 and cpub atb/axi/ahb/trace clocks
> > - Rewrote "This patch .." in commit messages
> >
> > [1] https://lkml.kernel.org/r/[email protected]
> > [2] https://lkml.kernel.org/r/[email protected]
> >
> > Neil Armstrong (3):
> > dt-bindings: clk: meson: add g12b periph clock controller bindings
> > clk: meson: g12a: Add support for G12B CPUB clocks
> > clk: meson: g12a: mark fclk_div3 as critical
> >
> > .../bindings/clock/amlogic,gxbb-clkc.txt | 1 +
> > drivers/clk/meson/g12a.c | 659 ++++++++++++++++++
> > drivers/clk/meson/g12a.h | 33 +-
> > 3 files changed, 692 insertions(+), 1 deletion(-)
> >
>
> And I forgot Martins reviews...
> It should still apply to patch 1, patch 2 has changed with new clocks.

You probably want to change the series title as well, s/G12A/G12B maybe ?

>
> Neil