2006-09-24 23:00:28

by Grant Coady

[permalink] [raw]
Subject: 2.6.18-mm1 make oldconfig missed SATA

Hi there,

2.6.18-mm1 make oldconfig didn't pull SATA config from 2.6.18 old screen to
the new libata screen, caught me out -- this may be an issue for 2.6.19
upgraders that a quick make oldconfig rebuild will fail to boot?

Grant.


2006-09-25 00:12:15

by Jeff Garzik

[permalink] [raw]
Subject: Re: 2.6.18-mm1 make oldconfig missed SATA

Grant Coady wrote:
> 2.6.18-mm1 make oldconfig didn't pull SATA config from 2.6.18 old screen to
> the new libata screen, caught me out -- this may be an issue for 2.6.19
> upgraders that a quick make oldconfig rebuild will fail to boot?

The symbols changed. No facility for upgrading .config symbols...
people who config their own kernels are expected to handle such things...

Jeff


2006-09-25 00:38:51

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: 2.6.18-mm1 make oldconfig missed SATA

On Sun, 24 Sep 2006 20:12:10 EDT, Jeff Garzik said:
> Grant Coady wrote:
> > 2.6.18-mm1 make oldconfig didn't pull SATA config from 2.6.18 old screen to

> > the new libata screen, caught me out -- this may be an issue for 2.6.19
> > upgraders that a quick make oldconfig rebuild will fail to boot?
>
> The symbols changed. No facility for upgrading .config symbols...
> people who config their own kernels are expected to handle such things...

I remember getting hit with this several times in the last few -mm's as I
did bisecting and kept crossing over the patch that did that. Fortunately,
'make oldconfig' was nice enough to keep me honest and prompt me for the new
symbol names.

What the Kbuild system *could* use is, for the end of 'make oldconfig', a
report like this for 'y' or 'm' symbols that have evaporated:

The following enabled symbols found in the .config were not defined in any Kconfig file:
CONFIG_FROOBY
CONFIG_DEBUG_FROOBY

So people aren't totally mystified Admittedly, I've only gotten bit by
silently dissapearing symbols 4-5 times since 2.5.55 or so, but the times
it happened it would have been nice to know....

(OK, I admit it - at least once of those 4-5 times it was because I ran
'make oldconfig' and I hadn't applied a local patch that added a Kconfig option.
Even in that case, a "Yo, dood, something went poof" msg would have saved me
a lot of bang-head-against-wall debugging. :)


Attachments:
(No filename) (226.00 B)

2006-09-25 01:24:11

by Grant Coady

[permalink] [raw]
Subject: Re: 2.6.18-mm1 make oldconfig missed SATA

On Sun, 24 Sep 2006 20:12:10 -0400, Jeff Garzik <[email protected]> wrote:

>Grant Coady wrote:
>> 2.6.18-mm1 make oldconfig didn't pull SATA config from 2.6.18 old screen to
>> the new libata screen, caught me out -- this may be an issue for 2.6.19
>> upgraders that a quick make oldconfig rebuild will fail to boot?
>
>The symbols changed. No facility for upgrading .config symbols...
>people who config their own kernels are expected to handle such things...

Oh sure, way back I used to run `make oldconfig; make menuconfig` and check
the config -- I guess complacency sets in and it is a ((Surprise!))

Grant.

2006-09-25 09:26:04

by Michael Tokarev

[permalink] [raw]
Subject: Re: 2.6.18-mm1 make oldconfig missed SATA

[email protected] wrote:
> On Sun, 24 Sep 2006 20:12:10 EDT, Jeff Garzik said:
>> Grant Coady wrote:
>>> 2.6.18-mm1 make oldconfig didn't pull SATA config from 2.6.18 old screen to
>
>>> the new libata screen, caught me out -- this may be an issue for 2.6.19
>>> upgraders that a quick make oldconfig rebuild will fail to boot?
>> The symbols changed. No facility for upgrading .config symbols...
>> people who config their own kernels are expected to handle such things...
>
> I remember getting hit with this several times in the last few -mm's as I
> did bisecting and kept crossing over the patch that did that. Fortunately,
> 'make oldconfig' was nice enough to keep me honest and prompt me for the new
> symbol names.
>
> What the Kbuild system *could* use is, for the end of 'make oldconfig', a
> report like this for 'y' or 'm' symbols that have evaporated:
>
> The following enabled symbols found in the .config were not defined in any Kconfig file:
> CONFIG_FROOBY
> CONFIG_DEBUG_FROOBY
>
> So people aren't totally mystified Admittedly, I've only gotten bit by
> silently dissapearing symbols 4-5 times since 2.5.55 or so, but the times
> it happened it would have been nice to know....

It already does that, but prints them in the beginning, not after config.
Try make silentoldconfig and see the first screen of warnings when it will
ask the first question.

/mjt

2006-09-25 13:32:31

by Valdis Klētnieks

[permalink] [raw]
Subject: Re: 2.6.18-mm1 make oldconfig missed SATA

On Mon, 25 Sep 2006 13:25:54 +0400, Michael Tokarev said:
> [email protected] wrote:
> > So people aren't totally mystified Admittedly, I've only gotten bit by
> > silently dissapearing symbols 4-5 times since 2.5.55 or so, but the times
> > it happened it would have been nice to know....
>
> It already does that, but prints them in the beginning, not after config.

Damn, I *never* noticed, because it was scrolled away. ;)

> Try make silentoldconfig and see the first screen of warnings when it will
> ask the first question.

I saw the recent help patches for that - how long has it been in there and I
didn't notice? (Though I admit I say that one and just moved along, thinking
that it was an upstream push of RedHat's linux-2.6-build-nonintconfig.patch
they carry in Fedora, but actually *looking* at that patch, it's something
different).


Attachments:
(No filename) (226.00 B)