On Thu, 7 Jul 2022 00:00:32 -0700, William Zhang <[email protected]> wrote:
> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
> CONFIG_ARCH_BCM_63XX from the makefile
>
> Signed-off-by: William Zhang <[email protected]>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
On 7.07.2022 09:00, William Zhang wrote:
> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
> CONFIG_ARCH_BCM_63XX from the makefile
>
> Signed-off-by: William Zhang <[email protected]>
> ---
>
> (no changes since v1)
>
> arch/arm/boot/dts/Makefile | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 38d9c60aece7..1bf8e2f8ee68 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
> bcm47189-luxul-xap-810.dtb \
> bcm47189-tenda-ac9.dtb \
> bcm947189acdbmr.dtb
> -dtb-$(CONFIG_ARCH_BCM_63XX) += \
> - bcm963138dvt.dtb
> dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
> bcm911360_entphn.dtb \
> bcm911360k.dtb \
> @@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
> bcm7445-bcm97445svmb.dtb
> dtb-$(CONFIG_ARCH_BCMBCA) += \
> bcm947622.dtb \
> + bcm963138dvt.dtb \
> bcm963148.dtb \
> bcm963178.dtb \
> bcm96756.dtb \
Do we want to mix all that DT files? Are ARCH_BCM_63XX (ex-)users
interested in compiling all of them?
For IPROC SoCs we have separated symbols: ARCH_BCM_CYGNUS / ARCH_BCM_HR2
/ ARCH_BCM_NSP / ARCH_BCM_5301X and we compile arch specific DT files
only.
On 7/13/22 08:26, Rafał Miłecki wrote:
> On 7.07.2022 09:00, William Zhang wrote:
>> Use CONFIG_ARCH_BCMBCA to build all the BCMBCA SoC dts and remove
>> CONFIG_ARCH_BCM_63XX from the makefile
>>
>> Signed-off-by: William Zhang <[email protected]>
>> ---
>>
>> (no changes since v1)
>>
>> arch/arm/boot/dts/Makefile | 3 +--
>> 1 file changed, 1 insertion(+), 2 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
>> index 38d9c60aece7..1bf8e2f8ee68 100644
>> --- a/arch/arm/boot/dts/Makefile
>> +++ b/arch/arm/boot/dts/Makefile
>> @@ -147,8 +147,6 @@ dtb-$(CONFIG_ARCH_BCM_53573) += \
>> bcm47189-luxul-xap-810.dtb \
>> bcm47189-tenda-ac9.dtb \
>> bcm947189acdbmr.dtb
>> -dtb-$(CONFIG_ARCH_BCM_63XX) += \
>> - bcm963138dvt.dtb
>> dtb-$(CONFIG_ARCH_BCM_CYGNUS) += \
>> bcm911360_entphn.dtb \
>> bcm911360k.dtb \
>> @@ -184,6 +182,7 @@ dtb-$(CONFIG_ARCH_BRCMSTB) += \
>> bcm7445-bcm97445svmb.dtb
>> dtb-$(CONFIG_ARCH_BCMBCA) += \
>> bcm947622.dtb \
>> + bcm963138dvt.dtb \
>> bcm963148.dtb \
>> bcm963178.dtb \
>> bcm96756.dtb \
>
> Do we want to mix all that DT files? Are ARCH_BCM_63XX (ex-)users
> interested in compiling all of them?
>
> For IPROC SoCs we have separated symbols: ARCH_BCM_CYGNUS / ARCH_BCM_HR2
> / ARCH_BCM_NSP / ARCH_BCM_5301X and we compile arch specific DT files
> only.
I am fine with that and build systems (buildroot and OpenWrt at least)
typically offer a way to produce a device specific image that will
contain a single DTB fit for the target device.
What we would be optimizing for would be build time vs. coverage, as a
maintainer I favor coverage as it allows me to build everyone in one
sweep. We could make the building of the 63138 conditional upon
BCMBCA_CORTEXA9 if that bothers you.
--
Florian