2011-04-08 13:39:10

by Peter Pan(潘卫平)

Subject: [PATCH] bonding:set save_load to 0 when initializing

It is unnecessary to set save_load to 1 here,
as the tx_hashtbl is just kzalloced.

Signed-off-by: Weiping Pan(潘卫平) <[email protected]>
---
drivers/net/bonding/bond_alb.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
index 9bc5de3..ab69e5a 100644
--- a/drivers/net/bonding/bond_alb.c
+++ b/drivers/net/bonding/bond_alb.c
@@ -176,7 +176,7 @@ static int tlb_initialize(struct bonding *bond)
bond_info->tx_hashtbl = new_hashtbl;

for (i = 0; i < TLB_HASH_TABLE_SIZE; i++) {
- tlb_init_table_entry(&bond_info->tx_hashtbl[i], 1);
+ tlb_init_table_entry(&bond_info->tx_hashtbl[i], 0);
}

_unlock_tx_hashtbl(bond);
--
1.7.4

2011-04-11 18:56:56

by Jay Vosburgh

Subject: Re: [PATCH] bonding:set save_load to 0 when initializing

>It is unnecessary to set save_load to 1 here,
>as the tx_hashtbl is just kzalloced.
>
>Signed-off-by: Weiping Pan(潘卫平) <[email protected]>

I don't think this will cause any behavioral change, but I'll
grant is more correct in intent (there's no load information to save at
this point).

Signed-off-by: Jay Vosburgh <[email protected]>

>---
> drivers/net/bonding/bond_alb.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_alb.c b/drivers/net/bonding/bond_alb.c
>index 9bc5de3..ab69e5a 100644
>--- a/drivers/net/bonding/bond_alb.c
>+++ b/drivers/net/bonding/bond_alb.c
>@@ -176,7 +176,7 @@ static int tlb_initialize(struct bonding *bond)
> bond_info->tx_hashtbl = new_hashtbl;
>
> for (i = 0; i < TLB_HASH_TABLE_SIZE; i++) {
>- tlb_init_table_entry(&bond_info->tx_hashtbl[i], 1);
>+ tlb_init_table_entry(&bond_info->tx_hashtbl[i], 0);
> }
>
> _unlock_tx_hashtbl(bond);
>--
>1.7.4
>

2011-04-11 20:16:59

by David Miller

Subject: Re: [PATCH] bonding:set save_load to 0 when initializing

From: Jay Vosburgh <[email protected]>
Date: Mon, 11 Apr 2011 11:56:47 -0700

>
>>It is unnecessary to set save_load to 1 here,
>>as the tx_hashtbl is just kzalloced.
>>
>>Signed-off-by: Weiping Pan(潘卫平) <[email protected]>
>
> I don't think this will cause any behavioral change, but I'll
> grant is more correct in intent (there's no load information to save at
> this point).
>
> Signed-off-by: Jay Vosburgh <[email protected]>

Applied.
????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m????????????I?