2017-06-23 05:42:59

by Arvind Yadav

[permalink] [raw]
Subject: [PATCH] fbdev: omapfb: constify ctrl_caps, color_caps, panel_attr_grp and ctrl_attr_grp

File size before:
text data bss dec hex filename
13007 1536 156 14699 396b drivers/video/fbdev/omap/omapfb_main.o

File size After adding 'const':
text data bss dec hex filename
13135 1408 156 14699 396b drivers/video/fbdev/omap/omapfb_main.o

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/video/fbdev/omap/omapfb_main.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/video/fbdev/omap/omapfb_main.c b/drivers/video/fbdev/omap/omapfb_main.c
index f4cbfb3..3479a47 100644
--- a/drivers/video/fbdev/omap/omapfb_main.c
+++ b/drivers/video/fbdev/omap/omapfb_main.c
@@ -62,7 +62,7 @@ struct caps_table_struct {
const char *name;
};

-static struct caps_table_struct ctrl_caps[] = {
+static const struct caps_table_struct ctrl_caps[] = {
{ OMAPFB_CAPS_MANUAL_UPDATE, "manual update" },
{ OMAPFB_CAPS_TEARSYNC, "tearing synchronization" },
{ OMAPFB_CAPS_PLANE_RELOCATE_MEM, "relocate plane memory" },
@@ -74,7 +74,7 @@ struct caps_table_struct {
{ OMAPFB_CAPS_SET_BACKLIGHT, "backlight setting" },
};

-static struct caps_table_struct color_caps[] = {
+static const struct caps_table_struct color_caps[] = {
{ 1 << OMAPFB_COLOR_RGB565, "RGB565", },
{ 1 << OMAPFB_COLOR_YUV422, "YUV422", },
{ 1 << OMAPFB_COLOR_YUV420, "YUV420", },
@@ -1384,7 +1384,7 @@ static DEVICE_ATTR(backlight_level, 0664,
NULL,
};

-static struct attribute_group panel_attr_grp = {
+static const struct attribute_group panel_attr_grp = {
.name = "panel",
.attrs = panel_attrs,
};
@@ -1406,7 +1406,7 @@ static ssize_t omapfb_show_ctrl_name(struct device *dev,
NULL,
};

-static struct attribute_group ctrl_attr_grp = {
+static const struct attribute_group ctrl_attr_grp = {
.name = "ctrl",
.attrs = ctrl_attrs,
};
--
1.9.1


Subject: Re: [PATCH] fbdev: omapfb: constify ctrl_caps, color_caps, panel_attr_grp and ctrl_attr_grp

On Friday, June 23, 2017 11:12:14 AM Arvind Yadav wrote:
> File size before:
> text data bss dec hex filename
> 13007 1536 156 14699 396b drivers/video/fbdev/omap/omapfb_main.o
>
> File size After adding 'const':
> text data bss dec hex filename
> 13135 1408 156 14699 396b drivers/video/fbdev/omap/omapfb_main.o
>
> Signed-off-by: Arvind Yadav <[email protected]>

Patch queued for 4.13, thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics