2016-12-14 11:50:14

by Rolf Eike Beer

Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests

>From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001
From: Rolf Eike Beer <[email protected]>
Date: Wed, 14 Dec 2016 09:58:12 +0100
Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests

Nothing in this minimal script seems to require bash. We often run these tests
on embedded devices where the only shell available is the busybox ash.

Signed-off-by: Rolf Eike Beer <[email protected]>
---
tools/testing/selftests/bpf/test_kmod.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/testing/selftests/bpf/test_kmod.sh b/tools/testing/selftests/bpf/test_kmod.sh
index 92e627a..6d58cca 100755
--- a/tools/testing/selftests/bpf/test_kmod.sh
+++ b/tools/testing/selftests/bpf/test_kmod.sh
@@ -1,4 +1,4 @@
-#!/bin/bash
+#!/bin/sh

SRC_TREE=../../../../

--
2.8.3


--
Rolf Eike Beer, emlix GmbH, http://www.emlix.com
Fon +49 551 30664-0, Fax +49 551 30664-11
Bertha-von-Suttner-Str. 9, 37085 Göttingen, Germany
Sitz der Gesellschaft: Göttingen, Amtsgericht Göttingen HR B 3160
Geschäftsführung: Heike Jordan, Dr. Uwe Kracke – Ust-IdNr.: DE 205 198 055

emlix – smart embedded open source

2016-12-14 11:03:50

by Daniel Borkmann

Subject: Re: [PATCH 2/3] selftests: do not require bash to run bpf tests

On 12/14/2016 11:58 AM, Rolf Eike Beer wrote:
> From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001
> From: Rolf Eike Beer <[email protected]>
> Date: Wed, 14 Dec 2016 09:58:12 +0100
> Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests
>
> Nothing in this minimal script seems to require bash. We often run these tests
> on embedded devices where the only shell available is the busybox ash.
>
> Signed-off-by: Rolf Eike Beer <[email protected]>

Acked-by: Daniel Borkmann <[email protected]>

2016-12-14 14:29:33

by Shuah Khan

Subject: Re: [PATCH 2/3] selftests: do not require bash to run bpf tests

On 12/14/2016 04:03 AM, Daniel Borkmann wrote:
> On 12/14/2016 11:58 AM, Rolf Eike Beer wrote:
>> From b9d6c1b7427d708ef2d4d57aac17b700b3694d71 Mon Sep 17 00:00:00 2001
>> From: Rolf Eike Beer <[email protected]>
>> Date: Wed, 14 Dec 2016 09:58:12 +0100
>> Subject: [PATCH 2/3] selftests: do not require bash to run bpf tests
>>
>> Nothing in this minimal script seems to require bash. We often run these tests
>> on embedded devices where the only shell available is the busybox ash.
>>
>> Signed-off-by: Rolf Eike Beer <[email protected]>
>
> Acked-by: Daniel Borkmann <[email protected]>

Thanks. I will get these into 4.10-rc1 or rc2

-- Shuah