2016-03-28 17:15:56

by Tirdea, Irina

[permalink] [raw]

Subject: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values

---

When reading gyroscope axes using iio buffers, the values
returned are always 0. In the interrupt handler, the return
value of the read operation is returned to the user instead
of the value read. Return the value read to the user.

This is also fixed in commit 82d8e5da1a33 ("iio:
accel: bmg160: optimize transfers in trigger handler").

Signed-off-by: Irina Tirdea <[email protected]>
---
drivers/iio/gyro/bmg160_core.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
index 295cf1d..e165ce9 100644
--- a/drivers/iio/gyro/bmg160_core.c
+++ b/drivers/iio/gyro/bmg160_core.c
@@ -781,7 +781,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
mutex_unlock(&data->mutex);
goto err;
}
- data->buffer[i++] = ret;
+ data->buffer[i++] = val;
}
mutex_unlock(&data->mutex);

--
1.9.1

2016-04-03 10:23:43

by Jonathan Cameron

[permalink] [raw]

Subject: Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values

---

On 28/03/16 18:15, Irina Tirdea wrote:
> When reading gyroscope axes using iio buffers, the values
> returned are always 0. In the interrupt handler, the return
> value of the read operation is returned to the user instead
> of the value read. Return the value read to the user.
>
> This is also fixed in commit 82d8e5da1a33 ("iio:
> accel: bmg160: optimize transfers in trigger handler").
>
> Signed-off-by: Irina Tirdea <[email protected]>
Ouch. Applied and marked for stable.

Jonathan
> ---
> drivers/iio/gyro/bmg160_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index 295cf1d..e165ce9 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -781,7 +781,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
> mutex_unlock(&data->mutex);
> goto err;
> }
> - data->buffer[i++] = ret;
> + data->buffer[i++] = val;
> }
> mutex_unlock(&data->mutex);
>
>

2016-04-07 06:49:58

by Markus Pargmann

[permalink] [raw]

Subject: Re: [PATCH 1/1] iio: gyro: bmg160: fix buffer read values

---

Hi,

On Monday 28 March 2016 20:15:46 Irina Tirdea wrote:
> When reading gyroscope axes using iio buffers, the values
> returned are always 0. In the interrupt handler, the return
> value of the read operation is returned to the user instead
> of the value read. Return the value read to the user.
>
> This is also fixed in commit 82d8e5da1a33 ("iio:
> accel: bmg160: optimize transfers in trigger handler").
>
> Signed-off-by: Irina Tirdea <[email protected]>

Thanks a lot for fixing all the bugs I introduced.

Best Regards,

Markus

> ---
> drivers/iio/gyro/bmg160_core.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/iio/gyro/bmg160_core.c b/drivers/iio/gyro/bmg160_core.c
> index 295cf1d..e165ce9 100644
> --- a/drivers/iio/gyro/bmg160_core.c
> +++ b/drivers/iio/gyro/bmg160_core.c
> @@ -781,7 +781,7 @@ static irqreturn_t bmg160_trigger_handler(int irq, void *p)
> mutex_unlock(&data->mutex);
> goto err;
> }
> - data->buffer[i++] = ret;
> + data->buffer[i++] = val;
> }
> mutex_unlock(&data->mutex);
>
>

--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

---

Attachments:

signature.asc (819.00 B)
This is a digitally signed message part.