2016-11-02 14:14:13

by Chris J Arges

Subject: [PATCH] igb: Workaround for igb i210 firmware issue.

Sometimes firmware may not properly initialize I347AT4_PAGE_SELECT causing
the probe of an igb i210 NIC to fail. This patch adds an addition zeroing of
this register during igb_get_phy_id to workaround this issue.

Thanks for Jochen Henneberg for the idea and original patch.

Signed-off-by: Chris J Arges <[email protected]>
---
drivers/net/ethernet/intel/igb/e1000_phy.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/drivers/net/ethernet/intel/igb/e1000_phy.c b/drivers/net/ethernet/intel/igb/e1000_phy.c
index 5b54254..93ec2d0 100644
--- a/drivers/net/ethernet/intel/igb/e1000_phy.c
+++ b/drivers/net/ethernet/intel/igb/e1000_phy.c
@@ -77,6 +77,10 @@ s32 igb_get_phy_id(struct e1000_hw *hw)
s32 ret_val = 0;
u16 phy_id;

+ /* ensure phy page selection to fix misconfigured i210 */
+ if (hw->mac.type == e1000_i210)
+ phy->ops.write_reg(hw, I347AT4_PAGE_SELECT, 0);
+
ret_val = phy->ops.read_reg(hw, PHY_ID1, &phy_id);
if (ret_val)
goto out;
--
2.7.4

2016-11-07 23:55:39

by Brown, Aaron F

Subject: RE: [PATCH] igb: Workaround for igb i210 firmware issue.

> From: [email protected] [mailto:netdev-
> [email protected]] On Behalf Of Chris J Arges
> Sent: Wednesday, November 2, 2016 7:14 AM
> To: [email protected]
> Cc: [email protected]; Chris J Arges
> <[email protected]>; Kirsher, Jeffrey T
> <[email protected]>; [email protected]; linux-
> [email protected]
> Subject: [PATCH] igb: Workaround for igb i210 firmware issue.
>
> Sometimes firmware may not properly initialize I347AT4_PAGE_SELECT
> causing
> the probe of an igb i210 NIC to fail. This patch adds an addition zeroing of
> this register during igb_get_phy_id to workaround this issue.
>
> Thanks for Jochen Henneberg for the idea and original patch.
>
> Signed-off-by: Chris J Arges <[email protected]>
> ---
> drivers/net/ethernet/intel/igb/e1000_phy.c | 4 ++++
> 1 file changed, 4 insertions(+)

Tested-by: Aaron Brown <[email protected]>