2018-11-01 07:05:34

by Joe Perches

Subject: [PATCH] igb: Fix format with line continuation whitespace

The line continuation unintentionally adds whitespace so
instead use a coalesced format to remove the whitespace.

Miscellanea:

o Use a more typical style for ternaries and arguments
for this logging message

Signed-off-by: Joe Perches <[email protected]>
---
drivers/net/ethernet/intel/igb/igb_main.c | 13 ++++++-------
1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
index 5df88ad8ac81..3a3410f03d04 100644
--- a/drivers/net/ethernet/intel/igb/igb_main.c
+++ b/drivers/net/ethernet/intel/igb/igb_main.c
@@ -1850,13 +1850,12 @@ static void igb_config_tx_modes(struct igb_adapter *adapter, int queue)
* configuration' in respect to these parameters.
*/

- netdev_dbg(netdev, "Qav Tx mode: cbs %s, launchtime %s, queue %d \
- idleslope %d sendslope %d hiCredit %d \
- locredit %d\n",
- (ring->cbs_enable) ? "enabled" : "disabled",
- (ring->launchtime_enable) ? "enabled" : "disabled", queue,
- ring->idleslope, ring->sendslope, ring->hicredit,
- ring->locredit);
+ netdev_dbg(netdev, "Qav Tx mode: cbs %s, launchtime %s, queue %d idleslope %d sendslope %d hiCredit %d locredit %d\n",
+ ring->cbs_enable ? "enabled" : "disabled",
+ ring->launchtime_enable ? "enabled" : "disabled",
+ queue,
+ ring->idleslope, ring->sendslope,
+ ring->hicredit, ring->locredit);
}

static int igb_save_txtime_params(struct igb_adapter *adapter, int queue,

2018-11-15 00:18:10

by Brown, Aaron F

Subject: RE: [PATCH] igb: Fix format with line continuation whitespace

> From: [email protected] [mailto:netdev-
> [email protected]] On Behalf Of Joe Perches
> Sent: Thursday, November 1, 2018 12:04 AM
> To: Kirsher, Jeffrey T <[email protected]>
> Cc: David S. Miller <[email protected]>; intel-wired-
> [email protected]; [email protected]; [email protected]
> Subject: [PATCH] igb: Fix format with line continuation whitespace
>
> The line continuation unintentionally adds whitespace so
> instead use a coalesced format to remove the whitespace.
>
> Miscellanea:
>
> o Use a more typical style for ternaries and arguments
> for this logging message
>
> Signed-off-by: Joe Perches <[email protected]>
> ---
> drivers/net/ethernet/intel/igb/igb_main.c | 13 ++++++-------
> 1 file changed, 6 insertions(+), 7 deletions(-)

Tested-by: Aaron Brown <[email protected]>

2018-11-15 01:06:05

by Vinicius Costa Gomes

Subject: Re: [PATCH] igb: Fix format with line continuation whitespace

Joe Perches <[email protected]> writes:

> The line continuation unintentionally adds whitespace so
> instead use a coalesced format to remove the whitespace.
>
> Miscellanea:
>
> o Use a more typical style for ternaries and arguments
> for this logging message
>
> Signed-off-by: Joe Perches <[email protected]>

Acked-by: Vinicius Costa Gomes <[email protected]>


Cheers,
--
Vinicius