2023-09-29 18:04:19

by Tom Lendacky

[permalink] [raw]
Subject: Re: [PATCH] arm/arm64: dts: Removed undocumented and unused "pl022,hierarchy" property

On 9/28/23 14:08, Rob Herring wrote:
> The "pl022,hierarchy" is not documented, all instances use are 0 and
> isn't handled in the kernel driver, so let's just remove it.
>
> Signed-off-by: Rob Herring <[email protected]>

Acked-by: Tom Lendacky <[email protected]>

> ---
> Arnd, Please apply this directly.
>
> arch/arm/boot/dts/st/spear1310-evb.dts | 2 --
> arch/arm/boot/dts/st/spear1340-evb.dts | 2 --
> arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts | 1 -
> arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts | 1 -
> arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts | 2 --
> 5 files changed, 8 deletions(-)
>
> diff --git a/arch/arm/boot/dts/st/spear1310-evb.dts b/arch/arm/boot/dts/st/spear1310-evb.dts
> index 05408df38203..18191a87f07c 100644
> --- a/arch/arm/boot/dts/st/spear1310-evb.dts
> +++ b/arch/arm/boot/dts/st/spear1310-evb.dts
> @@ -352,7 +352,6 @@ stmpe610@0 {
> #size-cells = <0>;
> spi-max-frequency = <1000000>;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0>;
> @@ -385,7 +384,6 @@ flash@1 {
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> diff --git a/arch/arm/boot/dts/st/spear1340-evb.dts b/arch/arm/boot/dts/st/spear1340-evb.dts
> index 7700f2afc128..cea624fc745c 100644
> --- a/arch/arm/boot/dts/st/spear1340-evb.dts
> +++ b/arch/arm/boot/dts/st/spear1340-evb.dts
> @@ -445,7 +445,6 @@ flash@0 {
> spi-max-frequency = <12000000>;
> spi-cpol;
> spi-cpha;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0x2>;
> @@ -461,7 +460,6 @@ stmpe610@1 {
> spi-max-frequency = <1000000>;
> spi-cpha;
> reg = <1>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable;
> pl022,com-mode = <0>;
> diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> index 21149acb6b31..1a65f1ec183d 100644
> --- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> +++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b0.dts
> @@ -64,7 +64,6 @@ sdcard0: sdcard@0 {
> reg = <0>;
> spi-max-frequency = <20000000>;
> voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,com-mode = <0x0>;
> pl022,rx-level-trig = <0>;
> diff --git a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> index 99205ae1b46b..52f8d36295a8 100644
> --- a/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> +++ b/arch/arm64/boot/dts/amd/amd-overdrive-rev-b1.dts
> @@ -76,7 +76,6 @@ sdcard0: sdcard@0 {
> reg = <0>;
> spi-max-frequency = <20000000>;
> voltage-ranges = <3200 3400>;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,com-mode = <0x0>;
> pl022,rx-level-trig = <0>;
> diff --git a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> index fbf0392b8371..dec5a110f1e8 100644
> --- a/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> +++ b/arch/arm64/boot/dts/broadcom/northstar2/ns2-svk.dts
> @@ -113,7 +113,6 @@ slic@0 {
> spi-max-frequency = <5000000>;
> spi-cpha;
> spi-cpol;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable = <0>;
> pl022,com-mode = <0>;
> @@ -137,7 +136,6 @@ at25@0 {
> at25,page-size = <64>;
> spi-cpha;
> spi-cpol;
> - pl022,hierarchy = <0>;
> pl022,interface = <0>;
> pl022,slave-tx-disable = <0>;
> pl022,com-mode = <0>;