2019-05-26 01:21:18

by Geordan Neukum

[permalink] [raw]
Subject: [PATCH 7/8] staging: kpc2000: kpc_i2c: fail probe if unable to map I/O space

The kpc2000 driver does not verify whether or not mapping the I/O
space succeeded during probe time. Make the driver verify that the
mapping operation was successful before potentially using that area
in the future.

Signed-off-by: Geordan Neukum <[email protected]>
---
drivers/staging/kpc2000/kpc2000_i2c.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/staging/kpc2000/kpc2000_i2c.c b/drivers/staging/kpc2000/kpc2000_i2c.c
index 452052bf9476..51e91653e183 100644
--- a/drivers/staging/kpc2000/kpc2000_i2c.c
+++ b/drivers/staging/kpc2000/kpc2000_i2c.c
@@ -591,6 +591,8 @@ static int pi2c_probe(struct platform_device *pldev)
return -ENXIO;

priv->smba = (unsigned long)ioremap_nocache(res->start, resource_size(res));
+ if (!priv->smba)
+ return -ENOMEM;

platform_set_drvdata(pldev, priv);

--
2.21.0