2024-04-11 07:35:13

by Mihai Sain

Subject: [PATCH 01/13] ARM: dts: microchip: sama7g5ek: Remove the empty line 50

Remove the empty line 50 from gpio-keys node.

Signed-off-by: Mihai Sain <[email protected]>
---
arch/arm/boot/dts/microchip/at91-sama7g5ek.dts | 1 -
1 file changed, 1 deletion(-)

diff --git a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
index 217e9b96c61e..e34ee887b7f8 100644
--- a/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
+++ b/arch/arm/boot/dts/microchip/at91-sama7g5ek.dts
@@ -47,7 +47,6 @@ main_xtal {

gpio-keys {
compatible = "gpio-keys";
-
pinctrl-names = "default";
pinctrl-0 = <&pinctrl_key_gpio_default>;

--
2.44.0

2024-04-11 07:47:06

by Krzysztof Kozlowski

Subject: Re: [PATCH 01/13] ARM: dts: microchip: sama7g5ek: Remove the empty line 50

On 11/04/2024 09:33, Mihai Sain wrote:
> Remove the empty line 50 from gpio-keys node.

Why? Commit msg *must* say why you are doing this.

I don't see any reason for this. You do not make code readable, you do
not explain the issue being addressed.

Best regards,
Krzysztof