On Fri, Apr 1, 2022 at 6:58 AM Zi Yan <[email protected]> wrote:
>
> +extern bool find_buddy_page_pfn(struct page *page, unsigned int order,
> + struct page **buddy, unsigned long *buddy_pfn);
Wouldn't it make more sense to just return the 'struct page *buddy'
here, instead of the 'bool'?
So a NULL buddy means the obvious "no buddy found".
I dislike those "pass return value by reference" in general, and the
above has _two_ of them.
We can get rid of at least one very obviously.
Linus
On 1 Apr 2022, at 12:31, Linus Torvalds wrote:
> On Fri, Apr 1, 2022 at 6:58 AM Zi Yan <[email protected]> wrote:
>>
>> +extern bool find_buddy_page_pfn(struct page *page, unsigned int order,
>> + struct page **buddy, unsigned long *buddy_pfn);
>
> Wouldn't it make more sense to just return the 'struct page *buddy'
> here, instead of the 'bool'?
>
> So a NULL buddy means the obvious "no buddy found".
>
> I dislike those "pass return value by reference" in general, and the
> above has _two_ of them.
>
> We can get rid of at least one very obviously.
Sure. We can get rid of both and calculate buddy_pfn from buddy after
a successful call.
--
Best Regards,
Yan, Zi