2007-08-29 16:41:35

by Bret Towe

[permalink] [raw]
Subject: linux-2.6.23-rc4 ppc build failure

while trying to build a fresh kernel for my mini after upgrading from gutsy
(and forgetting to save my .config) I hit the below build error
2.6.23-rc3 I did work under feisty but that is with a different .config
so not sure if that makes any difference or not
I've not bisected cause it takes so long on this computer...
attached is the config I'm working off now

arch/powerpc/platforms/built-in.o: In function `pmac_probe':
setup.c:(.init.text+0xbba): undefined reference to `pmac_ide_get_base'
setup.c:(.init.text+0xbbe): undefined reference to `pmac_ide_init_hwif_ports'
setup.c:(.init.text+0xbc6): undefined reference to `pmac_ide_get_base'
setup.c:(.init.text+0xbca): undefined reference to `pmac_ide_init_hwif_ports'
make[1]: *** [.tmp_vmlinux1] Error 1
make[1]: Leaving directory `/usr/src/linux-2.6'


Attachments:
(No filename) (809.00 B)
config (51.32 kB)
Download all attachments

2007-08-29 17:00:44

by Felipe Balbi

[permalink] [raw]
Subject: Re: linux-2.6.23-rc4 ppc build failure

Hi,

On 8/29/07, Bret Towe <[email protected]> wrote:
> while trying to build a fresh kernel for my mini after upgrading from gutsy
> (and forgetting to save my .config) I hit the below build error

The .config you can get from /boot/config-`uname -r`

> 2.6.23-rc3 I did work under feisty but that is with a different .config
> so not sure if that makes any difference or not
> I've not bisected cause it takes so long on this computer...
> attached is the config I'm working off now
>
> arch/powerpc/platforms/built-in.o: In function `pmac_probe':
> setup.c:(.init.text+0xbba): undefined reference to `pmac_ide_get_base'
> setup.c:(.init.text+0xbbe): undefined reference to `pmac_ide_init_hwif_ports'
> setup.c:(.init.text+0xbc6): undefined reference to `pmac_ide_get_base'
> setup.c:(.init.text+0xbca): undefined reference to `pmac_ide_init_hwif_ports'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make[1]: Leaving directory `/usr/src/linux-2.6'
>
>


--
Best Regards,

Felipe Balbi
[email protected]

2007-08-29 19:32:30

by Bret Towe

[permalink] [raw]
Subject: Re: linux-2.6.23-rc4 ppc build failure

On 8/29/07, Felipe Balbi <[email protected]> wrote:
> Hi,
>
> On 8/29/07, Bret Towe <[email protected]> wrote:
> > while trying to build a fresh kernel for my mini after upgrading from gutsy
> > (and forgetting to save my .config) I hit the below build error
>
> The .config you can get from /boot/config-`uname -r`

yes I know the one thats attached is based off that
just slimed down trying to keep the compile time down as much as possable

> > 2.6.23-rc3 I did work under feisty but that is with a different .config
> > so not sure if that makes any difference or not
> > I've not bisected cause it takes so long on this computer...
> > attached is the config I'm working off now
> >
> > arch/powerpc/platforms/built-in.o: In function `pmac_probe':
> > setup.c:(.init.text+0xbba): undefined reference to `pmac_ide_get_base'
> > setup.c:(.init.text+0xbbe): undefined reference to `pmac_ide_init_hwif_ports'
> > setup.c:(.init.text+0xbc6): undefined reference to `pmac_ide_get_base'
> > setup.c:(.init.text+0xbca): undefined reference to `pmac_ide_init_hwif_ports'
> > make[1]: *** [.tmp_vmlinux1] Error 1
> > make[1]: Leaving directory `/usr/src/linux-2.6'
> >
> >
>
>
> --
> Best Regards,
>
> Felipe Balbi
> [email protected]
>

2007-08-30 10:41:20

by Felipe Balbi

[permalink] [raw]
Subject: Re: linux-2.6.23-rc4 ppc build failure

Hi,

On 8/29/07, Bret Towe <[email protected]> wrote:
> On 8/29/07, Felipe Balbi <[email protected]> wrote:
> > Hi,
> >
> > On 8/29/07, Bret Towe <[email protected]> wrote:
> > > while trying to build a fresh kernel for my mini after upgrading from gutsy
> > > (and forgetting to save my .config) I hit the below build error
> >
> > The .config you can get from /boot/config-`uname -r`
>
> yes I know the one thats attached is based off that
> just slimed down trying to keep the compile time down as much as possable

Well, I don't have ppc cross-compiler... so I can't try this for you.
What I can tell you is that it doesn't seem like there was any change
regarding those functions. But even though, you're selecting the
needed Kconfig Macros.

Maybe someone who uses PPC arch could help better ???

>
> > > 2.6.23-rc3 I did work under feisty but that is with a different .config
> > > so not sure if that makes any difference or not
> > > I've not bisected cause it takes so long on this computer...
> > > attached is the config I'm working off now
> > >
> > > arch/powerpc/platforms/built-in.o: In function `pmac_probe':
> > > setup.c:(.init.text+0xbba): undefined reference to `pmac_ide_get_base'
> > > setup.c:(.init.text+0xbbe): undefined reference to `pmac_ide_init_hwif_ports'
> > > setup.c:(.init.text+0xbc6): undefined reference to `pmac_ide_get_base'
> > > setup.c:(.init.text+0xbca): undefined reference to `pmac_ide_init_hwif_ports'
> > > make[1]: *** [.tmp_vmlinux1] Error 1
> > > make[1]: Leaving directory `/usr/src/linux-2.6'
> > >
> > >
> >
> >
> > --
> > Best Regards,
> >
> > Felipe Balbi
> > [email protected]
> >
>


--
Best Regards,

Felipe Balbi
[email protected]

2007-08-30 21:57:00

by Bret Towe

[permalink] [raw]
Subject: Re: linux-2.6.23-rc4 ppc build failure

On 8/29/07, Bret Towe <[email protected]> wrote:
> while trying to build a fresh kernel for my mini after upgrading from gutsy
> (and forgetting to save my .config) I hit the below build error
> 2.6.23-rc3 I did work under feisty but that is with a different .config
> so not sure if that makes any difference or not
> I've not bisected cause it takes so long on this computer...
> attached is the config I'm working off now
>
> arch/powerpc/platforms/built-in.o: In function `pmac_probe':
> setup.c:(.init.text+0xbba): undefined reference to `pmac_ide_get_base'
> setup.c:(.init.text+0xbbe): undefined reference to `pmac_ide_init_hwif_ports'
> setup.c:(.init.text+0xbc6): undefined reference to `pmac_ide_get_base'
> setup.c:(.init.text+0xbca): undefined reference to `pmac_ide_init_hwif_ports'
> make[1]: *** [.tmp_vmlinux1] Error 1
> make[1]: Leaving directory `/usr/src/linux-2.6'
>
>

turns out the issue was I didn't have 'Enhanced IDE/MFM/RLL
disk/cdrom/tape/floppy support' selected (symbol BLK_DEV_IDE) it was
set as module
current code requires it to be built in
guess drivers/ide/Kconfig needs a touch up?

2007-08-31 04:03:33

by Tony Breeds

[permalink] [raw]
Subject: Re: linux-2.6.23-rc4 ppc build failure

On Thu, Aug 30, 2007 at 02:56:50PM -0700, Bret Towe wrote:
> On 8/29/07, Bret Towe <[email protected]> wrote:
> > while trying to build a fresh kernel for my mini after upgrading from gutsy
> > (and forgetting to save my .config) I hit the below build error
> > 2.6.23-rc3 I did work under feisty but that is with a different .config
> > so not sure if that makes any difference or not
> > I've not bisected cause it takes so long on this computer...
> > attached is the config I'm working off now

So how did you generate the new .config? Did you start with a defconfig
of some sort and then alter to personal taste?

I ask because if we have other users our there that have working system
with BLK_DEV_IDE=m it'd be nice to have make oldconfig fix them. If
it's just a matter of not letting people get into that state then
something like the patch below will probably help.

Ensure that BLK_DEV_IDE is built-in befoer allowing BLK_DEV_IDE_PMAC to
be selected.

Signed-off-by: Tony Breeds <[email protected]>

---

drivers/ide/Kconfig | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
index e049f65..e55be26 100644
--- a/drivers/ide/Kconfig
+++ b/drivers/ide/Kconfig
@@ -780,7 +780,7 @@ endif

config BLK_DEV_IDE_PMAC
bool "Builtin PowerMac IDE support"
- depends on PPC_PMAC && IDE=y
+ depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
help
This driver provides support for the built-in IDE controller on
most of the recent Apple Power Macintoshes and PowerBooks.

Yours Tony

linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!

2007-08-31 05:27:10

by Bret Towe

[permalink] [raw]
Subject: Re: linux-2.6.23-rc4 ppc build failure

On 8/30/07, Tony Breeds <[email protected]> wrote:
> On Thu, Aug 30, 2007 at 02:56:50PM -0700, Bret Towe wrote:
> > On 8/29/07, Bret Towe <[email protected]> wrote:
> > > while trying to build a fresh kernel for my mini after upgrading from gutsy
> > > (and forgetting to save my .config) I hit the below build error
> > > 2.6.23-rc3 I did work under feisty but that is with a different .config
> > > so not sure if that makes any difference or not
> > > I've not bisected cause it takes so long on this computer...
> > > attached is the config I'm working off now
>
> So how did you generate the new .config? Did you start with a defconfig
> of some sort and then alter to personal taste?

took the ubuntu config for the current kernel and starting getting rid
of everything i don't need
so the ubuntu config must of had the item set to M before hand

> I ask because if we have other users our there that have working system
> with BLK_DEV_IDE=m it'd be nice to have make oldconfig fix them. If
> it's just a matter of not letting people get into that state then
> something like the patch below will probably help.

I was thinking the same thing
would you like a test of this?

> Ensure that BLK_DEV_IDE is built-in befoer allowing BLK_DEV_IDE_PMAC to
> be selected.

s/befoer/before ?

> Signed-off-by: Tony Breeds <[email protected]>
>
> ---
>
> drivers/ide/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
> index e049f65..e55be26 100644
> --- a/drivers/ide/Kconfig
> +++ b/drivers/ide/Kconfig
> @@ -780,7 +780,7 @@ endif
>
> config BLK_DEV_IDE_PMAC
> bool "Builtin PowerMac IDE support"
> - depends on PPC_PMAC && IDE=y
> + depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
> help
> This driver provides support for the built-in IDE controller on
> most of the recent Apple Power Macintoshes and PowerBooks.
>
> Yours Tony
>
> linux.conf.au http://linux.conf.au/ || http://lca2008.linux.org.au/
> Jan 28 - Feb 02 2008 The Australian Linux Technical Conference!
>
>

Subject: Re: linux-2.6.23-rc4 ppc build failure

On Friday 31 August 2007, Tony Breeds wrote:
> On Thu, Aug 30, 2007 at 02:56:50PM -0700, Bret Towe wrote:
> > On 8/29/07, Bret Towe <[email protected]> wrote:
> > > while trying to build a fresh kernel for my mini after upgrading from gutsy
> > > (and forgetting to save my .config) I hit the below build error
> > > 2.6.23-rc3 I did work under feisty but that is with a different .config
> > > so not sure if that makes any difference or not
> > > I've not bisected cause it takes so long on this computer...
> > > attached is the config I'm working off now
>
> So how did you generate the new .config? Did you start with a defconfig
> of some sort and then alter to personal taste?

The problem might be related with switching CONFIG_IDE to use menuconfig.

> I ask because if we have other users our there that have working system
> with BLK_DEV_IDE=m it'd be nice to have make oldconfig fix them. If
> it's just a matter of not letting people get into that state then
> something like the patch below will probably help.

Unlikely that there are working BLK_DEV_IDE=m setups - these missing
symbols (pmac_ide_get_base and friends) have never been exported (IIRC).

> Ensure that BLK_DEV_IDE is built-in befoer allowing BLK_DEV_IDE_PMAC to
> be selected.
>
> Signed-off-by: Tony Breeds <[email protected]>

applied with s/befoer/before/ as spotted by Bret

> ---
>
> drivers/ide/Kconfig | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/ide/Kconfig b/drivers/ide/Kconfig
> index e049f65..e55be26 100644
> --- a/drivers/ide/Kconfig
> +++ b/drivers/ide/Kconfig
> @@ -780,7 +780,7 @@ endif
>
> config BLK_DEV_IDE_PMAC
> bool "Builtin PowerMac IDE support"
> - depends on PPC_PMAC && IDE=y
> + depends on PPC_PMAC && IDE=y && BLK_DEV_IDE=y
> help
> This driver provides support for the built-in IDE controller on
> most of the recent Apple Power Macintoshes and PowerBooks.