Hi all,
After merging the spi tree, today's linux-next build (arm
multi_v7_defconfig) produced this warning:
drivers/spi/spi-atmel.c: In function 'atmel_spi_probe':
drivers/spi/spi-atmel.c:1680:1: warning: label 'out_free' defined but not used [-Wunused-label]
1680 | out_free:
| ^~~~~~~~
Introduced by commit
2d9a744685bc ("spi: atmel: No need to call spi_master_put() if spi_alloc_master() failed")
--
Cheers,
Stephen Rothwell
Very sorry for that, I will re-send v2 later.
"Stephen Rothwell" <[email protected]>wrote:
> Hi all,
>
> After merging the spi tree, today's linux-next build (arm
> multi_v7_defconfig) produced this warning:
>
> drivers/spi/spi-atmel.c: In function 'atmel_spi_probe':
> drivers/spi/spi-atmel.c:1680:1: warning: label 'out_free' defined but not used [-Wunused-label]
> 1680 | out_free:
> | ^~~~~~~~
>
> Introduced by commit
>
> 2d9a744685bc ("spi: atmel: No need to call spi_master_put() if spi_alloc_master() failed")
>
> --
> Cheers,
> Stephen Rothwell
Hi, Browm, Stephen
Firstly, feel sorry for the problem introduced by me. I think I must modify my bad,but should I send another patch to delete the label "out_free" or
re-send patch of v2(which maybe need to go back)?
Could you give me some advices? Sorry again.
Thanks
"Peng Fan" <[email protected]>wrote:
> Very sorry for that, I will re-send v2 later.
>
> "Stephen Rothwell" <[email protected]>wrote:
> > Hi all,
> >
> > After merging the spi tree, today's linux-next build (arm
> > multi_v7_defconfig) produced this warning:
> >
> > drivers/spi/spi-atmel.c: In function 'atmel_spi_probe':
> > drivers/spi/spi-atmel.c:1680:1: warning: label 'out_free' defined but not used [-Wunused-label]
> > 1680 | out_free:
> > | ^~~~~~~~
> >
> > Introduced by commit
> >
> > 2d9a744685bc ("spi: atmel: No need to call spi_master_put() if spi_alloc_master() failed")
> >
> > --
> > Cheers,
> > Stephen Rothwell
On Thu, Jul 09, 2020 at 03:50:47PM +0800, Peng Fan wrote:
> Hi, Browm, Stephen
> Firstly, feel sorry for the problem introduced by me. I think I must modify my bad,but should I send another patch to delete the label "out_free" or
> re-send patch of v2(which maybe need to go back)?
> Could you give me some advices? Sorry again.
You should send a patch on top of what's already applied but actually
Colin Ian King sent a patch for this already which I can use so no need
to do anything, thanks for staying on top of of this though.