2024-02-26 12:30:18

by Krzysztof Kozlowski

[permalink] [raw]
Subject: [PATCH] dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

dtschema defines label as string, so $ref in other bindings is
redundant.

Signed-off-by: Krzysztof Kozlowski <[email protected]>
---
.../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml | 1 -
1 file changed, 1 deletion(-)

diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
index 5efceb313879..c384bf0bb25d 100644
--- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
+++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
@@ -49,7 +49,6 @@ patternProperties:
$ref: input.yaml#
properties:
label:
- $ref: /schemas/types.yaml#/definitions/string
description: Descriptive name of the key

linux,code: true
--
2.34.1



2024-02-26 17:32:04

by Jernej Škrabec

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
> dtschema defines label as string, so $ref in other bindings is
> redundant.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Acked-by: Jernej Skrabec <[email protected]>

I already send PR for 6.9. Do you mind if it waits on next cycle?

Best regards,
Jernej

> ---
> .../bindings/input/allwinner,sun4i-a10-lradc-keys.yaml | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> index 5efceb313879..c384bf0bb25d 100644
> --- a/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> +++ b/Documentation/devicetree/bindings/input/allwinner,sun4i-a10-lradc-keys.yaml
> @@ -49,7 +49,6 @@ patternProperties:
> $ref: input.yaml#
> properties:
> label:
> - $ref: /schemas/types.yaml#/definitions/string
> description: Descriptive name of the key
>
> linux,code: true
>





2024-02-27 03:50:22

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

On Mon, Feb 26, 2024 at 06:31:38PM +0100, Jernej Škrabec wrote:
> Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
> > dtschema defines label as string, so $ref in other bindings is
> > redundant.
> >
> > Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Acked-by: Jernej Skrabec <[email protected]>
>
> I already send PR for 6.9. Do you mind if it waits on next cycle?

This should go via input tree, not allwinner.

Acked-by: Rob Herring <[email protected]>

2024-02-27 06:48:30

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

On 26/02/2024 18:31, Jernej Škrabec wrote:
> Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
>> dtschema defines label as string, so $ref in other bindings is
>> redundant.
>>
>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>
> Acked-by: Jernej Skrabec <[email protected]>
>
> I already send PR for 6.9. Do you mind if it waits on next cycle?

Yes.

Best regards,
Krzysztof


2024-02-27 06:49:15

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

On 27/02/2024 07:48, Krzysztof Kozlowski wrote:
> On 26/02/2024 18:31, Jernej Škrabec wrote:
>> Dne ponedeljek, 26. februar 2024 ob 13:29:34 CET je Krzysztof Kozlowski napisal(a):
>>> dtschema defines label as string, so $ref in other bindings is
>>> redundant.
>>>
>>> Signed-off-by: Krzysztof Kozlowski <[email protected]>
>>
>> Acked-by: Jernej Skrabec <[email protected]>
>>
>> I already send PR for 6.9. Do you mind if it waits on next cycle?
>
> Yes.

Damn English. I don't mind, but as Rob pointed this is patch for input.

Best regards,
Krzysztof


2024-03-05 17:52:44

by Dmitry Torokhov

[permalink] [raw]
Subject: Re: [PATCH] dt-bindings: input: allwinner,sun4i-a10-lrad: drop redundant type from label

On Mon, Feb 26, 2024 at 01:29:34PM +0100, Krzysztof Kozlowski wrote:
> dtschema defines label as string, so $ref in other bindings is
> redundant.
>
> Signed-off-by: Krzysztof Kozlowski <[email protected]>

Applied, thank you.

--
Dmitry