2021-01-27 19:51:15

by Bjorn Helgaas

Subject: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers

From: Bjorn Helgaas <[email protected]>

Use PCI #defines for PCIe Device Control register values instead of
hard-coding bit positions. No functional change intended.

Signed-off-by: Bjorn Helgaas <[email protected]>
---
drivers/block/mtip32xx/mtip32xx.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/block/mtip32xx/mtip32xx.c b/drivers/block/mtip32xx/mtip32xx.c
index 53ac59d19ae5..543eb30a3bc0 100644
--- a/drivers/block/mtip32xx/mtip32xx.c
+++ b/drivers/block/mtip32xx/mtip32xx.c
@@ -3932,8 +3932,8 @@ static void mtip_disable_link_opts(struct driver_data *dd, struct pci_dev *pdev)
pci_read_config_word(pdev,
pos + PCI_EXP_DEVCTL,
&pcie_dev_ctrl);
- if (pcie_dev_ctrl & (1 << 11) ||
- pcie_dev_ctrl & (1 << 4)) {
+ if (pcie_dev_ctrl & PCI_EXP_DEVCTL_NOSNOOP_EN ||
+ pcie_dev_ctrl & PCI_EXP_DEVCTL_RELAX_EN) {
dev_info(&dd->pdev->dev,
"Disabling ERO/No-Snoop on bridge device %04x:%04x\n",
pdev->vendor, pdev->device);
--
2.25.1

2021-01-27 20:07:56

by Chaitanya Kulkarni

Subject: Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers

On 1/26/21 14:14, Bjorn Helgaas wrote:
> From: Bjorn Helgaas <[email protected]>
>
> Use PCI #defines for PCIe Device Control register values instead of
> hard-coding bit positions. No functional change intended.
>
> Signed-off-by: Bjorn Helgaas <[email protected]>

I've verified the values present in the include/uapi/linux/pci_regs.h
matches open coded bit shift values. LGTM.

Reviewed-by: Chaitanya Kulkarni <[email protected]>

2021-01-27 21:37:04

by Chaitanya Kulkarni

Subject: Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers

> On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni <[email protected]> wrote:
>
> On 1/26/21 14:14, Bjorn Helgaas wrote:
>> From: Bjorn Helgaas <[email protected]>
>>
>> Use PCI #defines for PCIe Device Control register values instead of
>> hard-coding bit positions. No functional change intended.
>>
>> Signed-off-by: Bjorn Helgaas <[email protected]>
>
> I've verified the values present in the include/uapi/linux/pci_regs.h
> matches open coded bit shift values. LGTM.
>
> Reviewed-by: Chaitanya Kulkarni <[email protected]>
>
Something is seriously wrong. I sent out this in the morning and it got delivered right now.
>

2021-01-28 00:03:46

by Bjorn Helgaas

Subject: Re: [PATCH 1/2] mtip32xx: use PCI #defines instead of numbers

On Wed, Jan 27, 2021 at 07:58:26AM +0000, Chaitanya Kulkarni wrote:
> > On Jan 26, 2021, at 11:41 PM, Chaitanya Kulkarni <[email protected]> wrote:
> > On 1/26/21 14:14, Bjorn Helgaas wrote:
> >> From: Bjorn Helgaas <[email protected]>
> >>
> >> Use PCI #defines for PCIe Device Control register values instead of
> >> hard-coding bit positions. No functional change intended.
> >>
> >> Signed-off-by: Bjorn Helgaas <[email protected]>
> >
> > I've verified the values present in the include/uapi/linux/pci_regs.h
> > matches open coded bit shift values. LGTM.
> >
> > Reviewed-by: Chaitanya Kulkarni <[email protected]>
> >
> Something is seriously wrong. I sent out this in the morning and it
> got delivered right now.

I noticed that, too. Seems like the mailing list is really backed up.
Thanks a lot for taking a look at this!

Bjorn