2018-02-09 09:04:56

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 00/10] thermal: Remove "cooling-{min|max}-level" properties

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a cooling devices is found by cooling-device's driver itself.

Also note that a very small number of platforms that support cooling
devices currently contain these properties in their dts files. Most of
them don't specify them (as no one is going to use them anyway).

Only two type of cooling devices are using these properties currently:
cpu-cooling and gpio-fan. This series first updates all the dts files to
not specify the min/max cooling states and then removes the bindings.

The maintainers are requested to apply the relevant patches to their
trees directly as there is no dependency between the patches.

--
viresh

Viresh Kumar (10):
ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes
ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes
ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes
ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node
ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node
dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties
dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ----
.../devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ----
Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
arch/arm/boot/dts/dra7.dtsi | 2 --
arch/arm/boot/dts/exynos4210.dtsi | 2 --
arch/arm/boot/dts/exynos4412.dtsi | 2 --
arch/arm/boot/dts/exynos5250.dtsi | 2 --
arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ----------------
arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ----------------
arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
arch/arm/boot/dts/mt7623.dtsi | 2 --
arch/arm/boot/dts/omap443x.dtsi | 2 --
arch/arm/boot/dts/omap4460.dtsi | 2 --
arch/arm/boot/dts/omap5.dtsi | 2 --
arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 1 -
arch/arm/boot/dts/sun4i-a10.dtsi | 2 --
arch/arm/boot/dts/sun5i-a13.dtsi | 2 --
arch/arm/boot/dts/sun6i-a31.dtsi | 2 --
arch/arm/boot/dts/sun7i-a20.dtsi | 2 --
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 6 ------
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 --
21 files changed, 1 insertion(+), 90 deletions(-)

--
2.15.0.194.g9af6a3dea062



2018-02-09 09:00:21

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of kernel currently and the max cooling state of a
CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused bindings.

Signed-off-by: Viresh Kumar <[email protected]>
---
Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
index 1719d47a5e2f..cc553f0952c5 100644
--- a/Documentation/devicetree/bindings/thermal/thermal.txt
+++ b/Documentation/devicetree/bindings/thermal/thermal.txt
@@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to
the different fan speeds possible. Cooling states are referred to by
single unsigned integers, where larger numbers mean greater heat
dissipation. The precise set of cooling states associated with a device
-(as referred to by the cooling-min-level and cooling-max-level
-properties) should be defined in a particular device's binding.
+should be defined in a particular device's binding.
For more examples of cooling devices, refer to the example sections below.

Required properties:
@@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below.
See Cooling device maps section below for more details
on how consumers refer to cooling devices.

-Optional properties:
-- cooling-min-level: An integer indicating the smallest
- Type: unsigned cooling state accepted. Typically 0.
- Size: one cell
-
-- cooling-max-level: An integer indicating the largest
- Type: unsigned cooling state accepted.
- Size: one cell
-
* Trip points

The trip node is a node to describe a point in the temperature domain
@@ -226,8 +216,6 @@ cpus {
396000 950000
198000 850000
>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
#cooling-cells = <2>; /* min followed by max */
};
...
@@ -241,8 +229,6 @@ cpus {
*/
fan0: fan@48 {
...
- cooling-min-level = <0>;
- cooling-max-level = <9>;
#cooling-cells = <2>; /* min followed by max */
};
};
--
2.15.0.194.g9af6a3dea062


2018-02-09 09:00:34

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of kernel currently and the max cooling state of a
CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused bindings.

Signed-off-by: Viresh Kumar <[email protected]>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ----
1 file changed, 4 deletions(-)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
index dd3929e85dec..332aed8f4597 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
@@ -18,8 +18,6 @@ under node /cpus/cpu@0.
in unit of nanoseconds.
- voltage-tolerance: Specify the CPU voltage tolerance in percentage.
- #cooling-cells:
-- cooling-min-level:
-- cooling-max-level:
Please refer to Documentation/devicetree/bindings/thermal/thermal.txt.

Examples:
@@ -40,8 +38,6 @@ cpus {
>;
clock-latency = <61036>; /* two CLK32 periods */
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <2>;
};

cpu@1 {
--
2.15.0.194.g9af6a3dea062


2018-02-09 09:00:55

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.

Moreover, the entries are incorrect here as min level is 4 and the max
level is 0.

Remove the unused properties from the CPU nodes.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
index 6a180d1926e8..fca8e4ee98e7 100644
--- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
+++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
@@ -88,8 +88,6 @@
next-level-cache = <&CLUSTER0_L2>;
clocks = <&stub_clock 0>;
operating-points-v2 = <&cpu_opp_table>;
- cooling-min-level = <4>;
- cooling-max-level = <0>;
#cooling-cells = <2>; /* min followed by max */
cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
dynamic-power-coefficient = <311>;
--
2.15.0.194.g9af6a3dea062


2018-02-09 09:01:18

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
gpio-fan cooling device is found by referring to the
"gpio-fan,speed-map" instead.

Remove the unused properties from the gpio-fan node.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 658215c9822c..8ee4a693c438 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -59,8 +59,6 @@
1 1
2 2
3 3>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
#cooling-cells = <2>;
};

--
2.15.0.194.g9af6a3dea062


2018-02-09 09:02:18

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused properties from the CPU nodes.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
1 file changed, 4 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
index 1448c3dba08e..658215c9822c 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
+++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
@@ -209,14 +209,10 @@
};

&cpu0 {
- cooling-min-level = <0>;
- cooling-max-level = <6>;
#cooling-cells = <2>;
};

&cpu4 {
- cooling-min-level = <0>;
- cooling-max-level = <4>;
#cooling-cells = <2>;
};

--
2.15.0.194.g9af6a3dea062


2018-02-09 09:02:32

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
gpio-fan cooling device is found by referring to the
"gpio-fan,speed-map" instead.

Remove the unused properties from the gpio-fan node.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
1 file changed, 2 deletions(-)

diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
index 08568ce24d06..727d16eb02d9 100644
--- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
+++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
@@ -78,8 +78,6 @@
gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
<&gpio0 12 GPIO_ACTIVE_HIGH>;
gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>;
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>;
};

--
2.15.0.194.g9af6a3dea062


2018-02-09 09:02:35

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused properties from the CPU nodes.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts | 1 -
arch/arm/boot/dts/sun4i-a10.dtsi | 2 --
arch/arm/boot/dts/sun5i-a13.dtsi | 2 --
arch/arm/boot/dts/sun6i-a31.dtsi | 2 --
arch/arm/boot/dts/sun7i-a20.dtsi | 2 --
5 files changed, 9 deletions(-)

diff --git a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
index 49247fbe6acd..e3d1d0f63caf 100644
--- a/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
+++ b/arch/arm/boot/dts/sun4i-a10-olinuxino-lime.dts
@@ -97,7 +97,6 @@
864000 1300000
624000 1250000
>;
- cooling-max-level = <2>;
};

&de {
diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
index 4f2f2eea0755..77e8436beed4 100644
--- a/arch/arm/boot/dts/sun4i-a10.dtsi
+++ b/arch/arm/boot/dts/sun4i-a10.dtsi
@@ -123,8 +123,6 @@
624000 1250000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
};
};

diff --git a/arch/arm/boot/dts/sun5i-a13.dtsi b/arch/arm/boot/dts/sun5i-a13.dtsi
index 4e830f5cb7f1..b1d827765530 100644
--- a/arch/arm/boot/dts/sun5i-a13.dtsi
+++ b/arch/arm/boot/dts/sun5i-a13.dtsi
@@ -116,8 +116,6 @@
432000 1200000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <5>;
};

&pio {
diff --git a/arch/arm/boot/dts/sun6i-a31.dtsi b/arch/arm/boot/dts/sun6i-a31.dtsi
index 72d3fe44ecaf..c72992556a86 100644
--- a/arch/arm/boot/dts/sun6i-a31.dtsi
+++ b/arch/arm/boot/dts/sun6i-a31.dtsi
@@ -113,8 +113,6 @@
480000 1000000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <3>;
};

cpu@1 {
diff --git a/arch/arm/boot/dts/sun7i-a20.dtsi b/arch/arm/boot/dts/sun7i-a20.dtsi
index bd0cd3204273..a3a6ce489fda 100644
--- a/arch/arm/boot/dts/sun7i-a20.dtsi
+++ b/arch/arm/boot/dts/sun7i-a20.dtsi
@@ -116,8 +116,6 @@
144000 1000000
>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <6>;
};

cpu@1 {
--
2.15.0.194.g9af6a3dea062


2018-02-09 09:02:38

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 03/10] ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused properties from the CPU nodes.

Signed-off-by: Viresh Kumar <[email protected]>
---
Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ----
arch/arm/boot/dts/mt7623.dtsi | 2 --
2 files changed, 6 deletions(-)

diff --git a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
index f6403089edcf..d36f07e0a2bb 100644
--- a/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
+++ b/Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt
@@ -21,8 +21,6 @@ Binding for MediaTek's CPUFreq driver
flow is handled by hardware, hence no software "voltage tracking" is
needed.
- #cooling-cells:
-- cooling-min-level:
-- cooling-max-level:
Please refer to Documentation/devicetree/bindings/thermal/thermal.txt
for detail.

@@ -67,8 +65,6 @@ Binding for MediaTek's CPUFreq driver
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cpu_opp_table>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
};
cpu@1 {
device_type = "cpu";
diff --git a/arch/arm/boot/dts/mt7623.dtsi b/arch/arm/boot/dts/mt7623.dtsi
index b750da5362f7..8e7c65464c9d 100644
--- a/arch/arm/boot/dts/mt7623.dtsi
+++ b/arch/arm/boot/dts/mt7623.dtsi
@@ -87,8 +87,6 @@
clock-names = "cpu", "intermediate";
operating-points-v2 = <&cpu_opp_table>;
#cooling-cells = <2>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
clock-frequency = <1300000000>;
};

--
2.15.0.194.g9af6a3dea062


2018-02-09 09:03:06

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused properties from the CPU nodes.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm/boot/dts/dra7.dtsi | 2 --
arch/arm/boot/dts/omap443x.dtsi | 2 --
arch/arm/boot/dts/omap4460.dtsi | 2 --
arch/arm/boot/dts/omap5.dtsi | 2 --
4 files changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi
index e4a420f16800..f4ddd86f2c77 100644
--- a/arch/arm/boot/dts/dra7.dtsi
+++ b/arch/arm/boot/dts/dra7.dtsi
@@ -92,8 +92,6 @@
clock-latency = <300000>; /* From omap-cpufreq driver */

/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */

vbb-supply = <&abb_mpu>;
diff --git a/arch/arm/boot/dts/omap443x.dtsi b/arch/arm/boot/dts/omap443x.dtsi
index 03c8ad91ddac..cbcdcb4e7d1c 100644
--- a/arch/arm/boot/dts/omap443x.dtsi
+++ b/arch/arm/boot/dts/omap443x.dtsi
@@ -24,8 +24,6 @@
clock-latency = <300000>; /* From legacy driver */

/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <3>;
#cooling-cells = <2>; /* min followed by max */
};
};
diff --git a/arch/arm/boot/dts/omap4460.dtsi b/arch/arm/boot/dts/omap4460.dtsi
index c43f2a2d0a1e..ad97493e4e46 100644
--- a/arch/arm/boot/dts/omap4460.dtsi
+++ b/arch/arm/boot/dts/omap4460.dtsi
@@ -22,8 +22,6 @@
clock-latency = <300000>; /* From legacy driver */

/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
};
};
diff --git a/arch/arm/boot/dts/omap5.dtsi b/arch/arm/boot/dts/omap5.dtsi
index 35d4298da83d..511606c17a04 100644
--- a/arch/arm/boot/dts/omap5.dtsi
+++ b/arch/arm/boot/dts/omap5.dtsi
@@ -55,8 +55,6 @@
clock-latency = <300000>; /* From omap-cpufreq driver */

/* cooling options */
- cooling-min-level = <0>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
};
cpu@1 {
--
2.15.0.194.g9af6a3dea062


2018-02-09 09:03:13

by Viresh Kumar

[permalink] [raw]
Subject: [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes

The "cooling-min-level" and "cooling-max-level" properties are not
parsed by any part of the kernel currently and the max cooling state of
a CPU cooling device is found by referring to the cpufreq table instead.

Remove the unused properties from the CPU nodes.

Signed-off-by: Viresh Kumar <[email protected]>
---
arch/arm/boot/dts/exynos4210.dtsi | 2 --
arch/arm/boot/dts/exynos4412.dtsi | 2 --
arch/arm/boot/dts/exynos5250.dtsi | 2 --
arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ----------------
arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ----------------
5 files changed, 38 deletions(-)

diff --git a/arch/arm/boot/dts/exynos4210.dtsi b/arch/arm/boot/dts/exynos4210.dtsi
index cc978cf28267..58ab34a233da 100644
--- a/arch/arm/boot/dts/exynos4210.dtsi
+++ b/arch/arm/boot/dts/exynos4210.dtsi
@@ -49,8 +49,6 @@
400000 975000
200000 950000
>;
- cooling-min-level = <4>;
- cooling-max-level = <2>;
#cooling-cells = <2>; /* min followed by max */
};

diff --git a/arch/arm/boot/dts/exynos4412.dtsi b/arch/arm/boot/dts/exynos4412.dtsi
index e4ad2fc0329e..5f5cc12f2075 100644
--- a/arch/arm/boot/dts/exynos4412.dtsi
+++ b/arch/arm/boot/dts/exynos4412.dtsi
@@ -42,8 +42,6 @@
clocks = <&clock CLK_ARM_CLK>;
clock-names = "cpu";
operating-points-v2 = <&cpu0_opp_table>;
- cooling-min-level = <13>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
};

diff --git a/arch/arm/boot/dts/exynos5250.dtsi b/arch/arm/boot/dts/exynos5250.dtsi
index 56626d1a4235..bb4180ef7885 100644
--- a/arch/arm/boot/dts/exynos5250.dtsi
+++ b/arch/arm/boot/dts/exynos5250.dtsi
@@ -77,8 +77,6 @@
300000 937500
200000 925000
>;
- cooling-min-level = <15>;
- cooling-max-level = <9>;
#cooling-cells = <2>; /* min followed by max */
};
cpu@1 {
diff --git a/arch/arm/boot/dts/exynos5420-cpus.dtsi b/arch/arm/boot/dts/exynos5420-cpus.dtsi
index 123f0cef658d..a8e449471304 100644
--- a/arch/arm/boot/dts/exynos5420-cpus.dtsi
+++ b/arch/arm/boot/dts/exynos5420-cpus.dtsi
@@ -30,8 +30,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -43,8 +41,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -56,8 +52,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -69,8 +63,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -83,8 +75,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -96,8 +86,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -109,8 +97,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -122,8 +108,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <7>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
diff --git a/arch/arm/boot/dts/exynos5422-cpus.dtsi b/arch/arm/boot/dts/exynos5422-cpus.dtsi
index c593809c7f08..7c130a00d1a8 100644
--- a/arch/arm/boot/dts/exynos5422-cpus.dtsi
+++ b/arch/arm/boot/dts/exynos5422-cpus.dtsi
@@ -29,8 +29,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -42,8 +40,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -55,8 +51,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -68,8 +62,6 @@
clock-frequency = <1000000000>;
cci-control-port = <&cci_control0>;
operating-points-v2 = <&cluster_a7_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <11>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <539>;
};
@@ -82,8 +74,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -95,8 +85,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -108,8 +96,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
@@ -121,8 +107,6 @@
clock-frequency = <1800000000>;
cci-control-port = <&cci_control1>;
operating-points-v2 = <&cluster_a15_opp_table>;
- cooling-min-level = <0>;
- cooling-max-level = <15>;
#cooling-cells = <2>; /* min followed by max */
capacity-dmips-mhz = <1024>;
};
--
2.15.0.194.g9af6a3dea062


2018-02-09 09:06:06

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 08/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for gpio-fan node

On 09/02/2018 09:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> gpio-fan cooling device is found by referring to the
> "gpio-fan,speed-map" instead.
>
> Remove the unused properties from the gpio-fan node.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 658215c9822c..8ee4a693c438 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -59,8 +59,6 @@
> 1 1
> 2 2
> 3 3>;
> - cooling-min-level = <0>;
> - cooling-max-level = <3>;
> #cooling-cells = <2>;
> };
>
>

Acked-by: Neil Armstrong <[email protected]>

2018-02-09 09:06:15

by Neil Armstrong

[permalink] [raw]
Subject: Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes

On 09/02/2018 09:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> index 1448c3dba08e..658215c9822c 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> @@ -209,14 +209,10 @@
> };
>
> &cpu0 {
> - cooling-min-level = <0>;
> - cooling-max-level = <6>;
> #cooling-cells = <2>;
> };
>
> &cpu4 {
> - cooling-min-level = <0>;
> - cooling-max-level = <4>;
> #cooling-cells = <2>;
> };
>
>

Acked-by: Neil Armstrong <[email protected]>

2018-02-12 17:18:23

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes

* Viresh Kumar <[email protected]> [180209 00:59]:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.

It seem this patch needs to wait before we can apply, right?

Regards,

Tony

2018-02-12 17:20:29

by Tony Lindgren

[permalink] [raw]
Subject: Re: [PATCH 02/10] ARM: dts: omap: Remove "cooling-{min|max}-level" for CPU nodes

* Tony Lindgren <[email protected]> [180212 09:17]:
> * Viresh Kumar <[email protected]> [180209 00:59]:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of the kernel currently and the max cooling state of
> > a CPU cooling device is found by referring to the cpufreq table instead.
> >
> > Remove the unused properties from the CPU nodes.
>
> It seem this patch needs to wait before we can apply, right?

Oh sorry it's already unused :) Will pick this up for v4.17 thanks.

Tony

2018-02-13 09:14:44

by Maxime Ripard

[permalink] [raw]
Subject: Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes

On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <[email protected]>

Applied, thanks!
Maxime

--
Maxime Ripard, Bootlin (formerly Free Electrons)
Embedded Linux and Kernel engineering
http://bootlin.com


Attachments:
(No filename) (545.00 B)
signature.asc (849.00 B)
Download all attachments

2018-02-13 09:20:40

by Chen-Yu Tsai

[permalink] [raw]
Subject: Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes

On Tue, Feb 13, 2018 at 5:13 PM, Maxime Ripard
<[email protected]> wrote:
> On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote:
>> The "cooling-min-level" and "cooling-max-level" properties are not
>> parsed by any part of the kernel currently and the max cooling state of
>> a CPU cooling device is found by referring to the cpufreq table instead.

That doesn't mean that other systems aren't using it. It's still part of
the device tree binding. Last I checked, while they are optional, they
aren't deprecated.

Any comments from the device tree maintainers?

>>
>> Remove the unused properties from the CPU nodes.
>>
>> Signed-off-by: Viresh Kumar <[email protected]>
>
> Applied, thanks!
> Maxime
>
> --
> Maxime Ripard, Bootlin (formerly Free Electrons)
> Embedded Linux and Kernel engineering
> http://bootlin.com

2018-02-13 18:18:23

by Krzysztof Kozlowski

[permalink] [raw]
Subject: Re: [PATCH 01/10] ARM: dts: exynos: Remove "cooling-{min|max}-level" for CPU nodes

On Fri, Feb 09, 2018 at 02:28:01PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> arch/arm/boot/dts/exynos4210.dtsi | 2 --
> arch/arm/boot/dts/exynos4412.dtsi | 2 --
> arch/arm/boot/dts/exynos5250.dtsi | 2 --
> arch/arm/boot/dts/exynos5420-cpus.dtsi | 16 ----------------
> arch/arm/boot/dts/exynos5422-cpus.dtsi | 16 ----------------
> 5 files changed, 38 deletions(-)
>

Thanks, applied.

Best regards,
Krzysztof


2018-02-14 03:13:54

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 04/10] ARM: dts: sun[4-7]i: Remove "cooling-{min|max}-level" for CPU nodes

On 13-02-18, 17:18, Chen-Yu Tsai wrote:
> On Tue, Feb 13, 2018 at 5:13 PM, Maxime Ripard
> <[email protected]> wrote:
> > On Fri, Feb 09, 2018 at 02:28:04PM +0530, Viresh Kumar wrote:
> >> The "cooling-min-level" and "cooling-max-level" properties are not
> >> parsed by any part of the kernel currently and the max cooling state of
> >> a CPU cooling device is found by referring to the cpufreq table instead.
>
> That doesn't mean that other systems aren't using it.

Are you aware of any systems which are using them ?

> It's still part of
> the device tree binding. Last I checked, while they are optional, they
> aren't deprecated.

Yeah, it isn't deprecated yet. Though the last patches of this series
tries to do something similar.

> Any comments from the device tree maintainers?

None yet.

--
viresh

2018-02-18 23:27:20

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 03/10] ARM: dts: mt7623: Remove "cooling-{min|max}-level" for CPU nodes

On Fri, Feb 09, 2018 at 02:28:03PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-mediatek.txt | 4 ----
> arch/arm/boot/dts/mt7623.dtsi | 2 --
> 2 files changed, 6 deletions(-)

Reviewed-by: Rob Herring <[email protected]>

2018-02-18 23:28:02

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 09/10] dt-bindings: cpufreq-dt: Remove "cooling-{min|max}-level" properties

On Fri, Feb 09, 2018 at 02:28:09PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of kernel currently and the max cooling state of a
> CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused bindings.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt | 4 ----
> 1 file changed, 4 deletions(-)

Reviewed-by: Rob Herring <[email protected]>

2018-02-18 23:30:03

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of kernel currently and the max cooling state of a
> CPU cooling device is found by referring to the cpufreq table instead.

What about non-CPU devices? A fan for example.

>
> Remove the unused bindings.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/thermal/thermal.txt b/Documentation/devicetree/bindings/thermal/thermal.txt
> index 1719d47a5e2f..cc553f0952c5 100644
> --- a/Documentation/devicetree/bindings/thermal/thermal.txt
> +++ b/Documentation/devicetree/bindings/thermal/thermal.txt
> @@ -55,8 +55,7 @@ of heat dissipation). For example a fan's cooling states correspond to
> the different fan speeds possible. Cooling states are referred to by
> single unsigned integers, where larger numbers mean greater heat
> dissipation. The precise set of cooling states associated with a device
> -(as referred to by the cooling-min-level and cooling-max-level
> -properties) should be defined in a particular device's binding.
> +should be defined in a particular device's binding.
> For more examples of cooling devices, refer to the example sections below.
>
> Required properties:
> @@ -69,15 +68,6 @@ For more examples of cooling devices, refer to the example sections below.
> See Cooling device maps section below for more details
> on how consumers refer to cooling devices.
>
> -Optional properties:
> -- cooling-min-level: An integer indicating the smallest
> - Type: unsigned cooling state accepted. Typically 0.
> - Size: one cell
> -
> -- cooling-max-level: An integer indicating the largest
> - Type: unsigned cooling state accepted.
> - Size: one cell
> -
> * Trip points
>
> The trip node is a node to describe a point in the temperature domain
> @@ -226,8 +216,6 @@ cpus {
> 396000 950000
> 198000 850000
> >;
> - cooling-min-level = <0>;
> - cooling-max-level = <3>;
> #cooling-cells = <2>; /* min followed by max */
> };
> ...
> @@ -241,8 +229,6 @@ cpus {
> */
> fan0: fan@48 {
> ...
> - cooling-min-level = <0>;
> - cooling-max-level = <9>;
> #cooling-cells = <2>; /* min followed by max */
> };
> };
> --
> 2.15.0.194.g9af6a3dea062
>

2018-02-19 03:44:38

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

On 18-02-18, 17:29, Rob Herring wrote:
> On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of kernel currently and the max cooling state of a
> > CPU cooling device is found by referring to the cpufreq table instead.
>
> What about non-CPU devices? A fan for example.

Even they aren't using these properties. The gpio-fan binding[1] for
example uses the "gpio-fan,speed-map" property instead to find the
number of states it supports.

--
viresh

[1] Documentation/devicetree/bindings/gpio/gpio-fan.txt

2018-02-19 18:02:22

by Rob Herring (Arm)

[permalink] [raw]
Subject: Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

On Mon, Feb 19, 2018 at 09:13:38AM +0530, Viresh Kumar wrote:
> On 18-02-18, 17:29, Rob Herring wrote:
> > On Fri, Feb 09, 2018 at 02:28:10PM +0530, Viresh Kumar wrote:
> > > The "cooling-min-level" and "cooling-max-level" properties are not
> > > parsed by any part of kernel currently and the max cooling state of a
> > > CPU cooling device is found by referring to the cpufreq table instead.
> >
> > What about non-CPU devices? A fan for example.
>
> Even they aren't using these properties. The gpio-fan binding[1] for
> example uses the "gpio-fan,speed-map" property instead to find the
> number of states it supports.

Okay.

Reviewed-by: Rob Herring <[email protected]>

2018-03-02 16:37:45

by Wei Xu

[permalink] [raw]
Subject: Re: [PATCH 05/10] ARM64: dts: hi6220: Remove "cooling-{min|max}-level" for CPU nodes

Hi Viresh,

On 2018/2/9 8:58, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Moreover, the entries are incorrect here as min level is 4 and the max
> level is 0.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---

Applied into hisilicon dt tree.
Thanks!

BR,
Wei

> arch/arm64/boot/dts/hisilicon/hi6220.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> index 6a180d1926e8..fca8e4ee98e7 100644
> --- a/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> +++ b/arch/arm64/boot/dts/hisilicon/hi6220.dtsi
> @@ -88,8 +88,6 @@
> next-level-cache = <&CLUSTER0_L2>;
> clocks = <&stub_clock 0>;
> operating-points-v2 = <&cpu_opp_table>;
> - cooling-min-level = <4>;
> - cooling-max-level = <0>;
> #cooling-cells = <2>; /* min followed by max */
> cpu-idle-states = <&CPU_SLEEP &CLUSTER_SLEEP>;
> dynamic-power-coefficient = <311>;
>


2018-03-12 04:34:03

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes

On 09-02-18, 10:03, Neil Armstrong wrote:
> On 09/02/2018 09:58, Viresh Kumar wrote:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of the kernel currently and the max cooling state of
> > a CPU cooling device is found by referring to the cpufreq table instead.
> >
> > Remove the unused properties from the CPU nodes.
> >
> > Signed-off-by: Viresh Kumar <[email protected]>
> > ---
> > arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
> > 1 file changed, 4 deletions(-)
> >
> > diff --git a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> > index 1448c3dba08e..658215c9822c 100644
> > --- a/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> > +++ b/arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts
> > @@ -209,14 +209,10 @@
> > };
> >
> > &cpu0 {
> > - cooling-min-level = <0>;
> > - cooling-max-level = <6>;
> > #cooling-cells = <2>;
> > };
> >
> > &cpu4 {
> > - cooling-min-level = <0>;
> > - cooling-max-level = <4>;
> > #cooling-cells = <2>;
> > };
> >
> >
>
> Acked-by: Neil Armstrong <[email protected]>

Is Kevin going to apply these for 4.17 ?

--
viresh

2018-03-12 04:36:48

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node

On 09-02-18, 14:28, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> gpio-fan cooling device is found by referring to the
> "gpio-fan,speed-map" instead.
>
> Remove the unused properties from the gpio-fan node.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> index 08568ce24d06..727d16eb02d9 100644
> --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> @@ -78,8 +78,6 @@
> gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
> <&gpio0 12 GPIO_ACTIVE_HIGH>;
> gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>;
> - cooling-min-level = <0>;
> - cooling-max-level = <2>;
> #cooling-cells = <2>;
> };
>

@Linus: Can you please pick this one for 4.17 ?

--
viresh

2018-03-12 04:40:37

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

On 09-02-18, 14:28, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of kernel currently and the max cooling state of a
> CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused bindings.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> Documentation/devicetree/bindings/thermal/thermal.txt | 16 +---------------
> 1 file changed, 1 insertion(+), 15 deletions(-)

@Zhang/Eduardo: Can you please pick this patch (10/10) as almost everything else
is already lined up for 4.17 ?

--
viresh

2018-03-20 02:05:39

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node

On 12-03-18, 10:05, Viresh Kumar wrote:
> On 09-02-18, 14:28, Viresh Kumar wrote:
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of the kernel currently and the max cooling state of
> > gpio-fan cooling device is found by referring to the
> > "gpio-fan,speed-map" instead.
> >
> > Remove the unused properties from the gpio-fan node.
> >
> > Signed-off-by: Viresh Kumar <[email protected]>
> > ---
> > arch/arm/boot/dts/gemini-dlink-dns-313.dts | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/gemini-dlink-dns-313.dts b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> > index 08568ce24d06..727d16eb02d9 100644
> > --- a/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> > +++ b/arch/arm/boot/dts/gemini-dlink-dns-313.dts
> > @@ -78,8 +78,6 @@
> > gpios = <&gpio0 11 GPIO_ACTIVE_HIGH>,
> > <&gpio0 12 GPIO_ACTIVE_HIGH>;
> > gpio-fan,speed-map = <0 0>, <3000 1>, <6000 2>;
> > - cooling-min-level = <0>;
> > - cooling-max-level = <2>;
> > #cooling-cells = <2>;
> > };
> >
>
> @Linus: Can you please pick this one for 4.17 ?

@Arnd/Olof: Can you please pick this one up as well ?

--
viresh

2018-03-20 02:06:03

by Viresh Kumar

[permalink] [raw]
Subject: Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes

On 09-02-18, 14:28, Viresh Kumar wrote:
> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> a CPU cooling device is found by referring to the cpufreq table instead.
>
> Remove the unused properties from the CPU nodes.
>
> Signed-off-by: Viresh Kumar <[email protected]>
> ---
> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
> 1 file changed, 4 deletions(-)

@Arnd: Can you please pick this and patch 8/10 from this series for 4.17 ? Both
are already Acked by Neil. I have just re-bounced both the messages to
[email protected]. Thanks.

--
viresh

2018-03-20 03:11:44

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node

On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <[email protected]> wrote:

> The "cooling-min-level" and "cooling-max-level" properties are not
> parsed by any part of the kernel currently and the max cooling state of
> gpio-fan cooling device is found by referring to the
> "gpio-fan,speed-map" instead.
>
> Remove the unused properties from the gpio-fan node.
>
> Signed-off-by: Viresh Kumar <[email protected]>

Acked-by: Linus Walleij <[email protected]>

I can queue it next week (different machine hosting the git tree)
but it is also OK if the ARM SoC maintainers want to pick it
directly for the ARM SoC DTS branch.

Yours,
Linus Walleij

2018-03-20 12:51:15

by Zhang, Rui

[permalink] [raw]
Subject: Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

On 一, 2018-03-12 at 10:08 +0530, Viresh Kumar wrote:
> On 09-02-18, 14:28, Viresh Kumar wrote:
> >
> > The "cooling-min-level" and "cooling-max-level" properties are not
> > parsed by any part of kernel currently and the max cooling state of
> > a
> > CPU cooling device is found by referring to the cpufreq table
> > instead.
> >
> > Remove the unused bindings.
> >
> > Signed-off-by: Viresh Kumar <[email protected]>
> > ---
> >  Documentation/devicetree/bindings/thermal/thermal.txt | 16 +----
> > -----------
> >  1 file changed, 1 insertion(+), 15 deletions(-)
> @Zhang/Eduardo: Can you please pick this patch (10/10) as almost
> everything else
> is already lined up for 4.17 ?

I think Eduardo should have reviewed all the DT thermal patches in the
list, but I didn't see his response about this one.

Eduardo,
did you miss this one?

thanks,
rui
>

2018-03-27 12:30:10

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node

On Tue, Mar 20, 2018 at 4:10 AM, Linus Walleij <[email protected]> wrote:
> On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <[email protected]> wrote:
>
>> The "cooling-min-level" and "cooling-max-level" properties are not
>> parsed by any part of the kernel currently and the max cooling state of
>> gpio-fan cooling device is found by referring to the
>> "gpio-fan,speed-map" instead.
>>
>> Remove the unused properties from the gpio-fan node.
>>
>> Signed-off-by: Viresh Kumar <[email protected]>
>
> Acked-by: Linus Walleij <[email protected]>
>
> I can queue it next week (different machine hosting the git tree)
> but it is also OK if the ARM SoC maintainers want to pick it
> directly for the ARM SoC DTS branch.

I've picked it up directly now, as we're about to run out of time
before the merge window.

Arnd

2018-03-27 12:30:58

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 07/10] ARM: dts: gemini: Remove "cooling-{min|max}-level" for gpio-fan node

On Tue, Mar 27, 2018 at 2:26 PM, Arnd Bergmann <[email protected]> wrote:
> On Tue, Mar 20, 2018 at 4:10 AM, Linus Walleij <[email protected]> wrote:
>> On Fri, Feb 9, 2018 at 9:58 AM, Viresh Kumar <[email protected]> wrote:
>>
>>> The "cooling-min-level" and "cooling-max-level" properties are not
>>> parsed by any part of the kernel currently and the max cooling state of
>>> gpio-fan cooling device is found by referring to the
>>> "gpio-fan,speed-map" instead.
>>>
>>> Remove the unused properties from the gpio-fan node.
>>>
>>> Signed-off-by: Viresh Kumar <[email protected]>
>>
>> Acked-by: Linus Walleij <[email protected]>
>>
>> I can queue it next week (different machine hosting the git tree)
>> but it is also OK if the ARM SoC maintainers want to pick it
>> directly for the ARM SoC DTS branch.
>
> I've picked it up directly now, as we're about to run out of time
> before the merge window.

Thanks, I was just about to queue it and send a pull request but now
I don't need to :)

Yours,
Linus Walleij

2018-03-27 12:33:53

by Arnd Bergmann

[permalink] [raw]
Subject: Re: [PATCH 06/10] ARM64: dts: meson: Remove "cooling-{min|max}-level" for CPU nodes

On Tue, Mar 20, 2018 at 2:37 AM, Viresh Kumar <[email protected]> wrote:
> On 09-02-18, 14:28, Viresh Kumar wrote:
>> The "cooling-min-level" and "cooling-max-level" properties are not
>> parsed by any part of the kernel currently and the max cooling state of
>> a CPU cooling device is found by referring to the cpufreq table instead.
>>
>> Remove the unused properties from the CPU nodes.
>>
>> Signed-off-by: Viresh Kumar <[email protected]>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-gxm-khadas-vim2.dts | 4 ----
>> 1 file changed, 4 deletions(-)
>
> @Arnd: Can you please pick this and patch 8/10 from this series for 4.17 ? Both
> are already Acked by Neil. I have just re-bounced both the messages to
> [email protected]. Thanks.

Picked up patches 6, 7 and 8 now. For some reason I didn't see patch 8
in my [email protected] inbox, but I found it on the mailing list.

Arnd

2018-03-27 13:47:30

by Eduardo Valentin

[permalink] [raw]
Subject: Re: [PATCH 10/10] dt-bindings: thermal: Remove "cooling-{min|max}-level" properties

On Tue, Mar 20, 2018 at 08:49:50PM +0800, Zhang Rui wrote:
> On 一, 2018-03-12 at 10:08 +0530, Viresh Kumar wrote:
> > On 09-02-18, 14:28, Viresh Kumar wrote:
> > >
> > > The "cooling-min-level" and "cooling-max-level" properties are not
> > > parsed by any part of kernel currently and the max cooling state of
> > > a
> > > CPU cooling device is found by referring to the cpufreq table
> > > instead.
> > >
> > > Remove the unused bindings.
> > >
> > > Signed-off-by: Viresh Kumar <[email protected]>
> > > ---
> > >  Documentation/devicetree/bindings/thermal/thermal.txt | 16 +----
> > > -----------
> > >  1 file changed, 1 insertion(+), 15 deletions(-)
> > @Zhang/Eduardo: Can you please pick this patch (10/10) as almost
> > everything else
> > is already lined up for 4.17 ?
>
> I think Eduardo should have reviewed all the DT thermal patches in the
> list, but I didn't see his response about this one.
>
> Eduardo,
> did you miss this one?

just applied and sending it in my pull request.

>
> thanks,
> rui
> >