Hi Linus,
Fairly small pull request for -rc3. I'm out of town the rest of this
week, so I made sure to clean out as much as possible from patchworks in
enough time for 0-day to chew through it (Yay! for 0-day being back
online! :-)). Jason might send through any emergency stuff that could
pop up, otherwise I'm back next week.
The only real thing of note is the siw ABI change. Since we just merged
siw *this* release, there are no prior kernel releases to maintain
kernel ABI with. I told Bernard that if there is anything else about
the siw ABI he thinks he might want to change before it goes set in
stone, he should get it in ASAP. The siw module was around for several
years outside the kernel tree, and it had to be revamped considerably
for inclusion upstream, so we are making no attempts to be backward
compatible with the out of tree version. Once 5.3 is actually released,
we will have our baseline ABI to maintain.
Here's the boiler plate:
The following changes since commit e21a712a9685488f5ce80495b37b9fdbe96c230d:
Linux 5.3-rc3 (2019-08-04 18:40:12 -0700)
are available in the Git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus
for you to fetch changes up to 2c8ccb37b08fe364f02a9914daca474d43151453:
RDMA/siw: Change CQ flags from 64->32 bits (2019-08-13 12:22:06 -0400)
----------------------------------------------------------------
Pull request for 5.3-rc3
- Fix a memory registration release flow issue that was causing a
WARN_ON (mlx5)
- If the counters for a port aren't allocated, then we can't do
operations on the non-existent counters (core)
- Check the right variable for error code result (mlx5)
- Fix a use after free issue (mlx5)
- Fix an off by one memory leak (siw)
- Actually return an error code on error (core)
- Allow siw to be built on 32bit arches (siw, ABI change, but OK since
siw was just merged this merge window and there is no prior released
kernel to maintain compatibility with and we also updated the
rdma-core user space package to match)
Signed-off-by: Doug Ledford <[email protected]>
----------------------------------------------------------------
Bernard Metzler (1):
RDMA/siw: Change CQ flags from 64->32 bits
Dan Carpenter (3):
IB/mlx5: Check the correct variable in error handling code
RDMA/siw: Fix a memory leak in siw_init_cpulist()
RDMA/core: Fix error code in stat_get_doit_qp()
Mark Zhang (1):
RDMA/counter: Prevent QP counter binding if counters unsupported
Yishai Hadas (2):
IB/mlx5: Fix implicit MR release flow
IB/mlx5: Fix use-after-free error while accessing ev_file pointer
drivers/infiniband/core/counters.c | 6 ++++++
drivers/infiniband/core/nldev.c | 8 ++++++--
drivers/infiniband/core/umem_odp.c | 4 ----
drivers/infiniband/hw/mlx5/devx.c | 11 ++++++-----
drivers/infiniband/hw/mlx5/odp.c | 24 +++++++++---------------
drivers/infiniband/sw/siw/Kconfig | 2 +-
drivers/infiniband/sw/siw/siw.h | 2 +-
drivers/infiniband/sw/siw/siw_main.c | 4 +---
drivers/infiniband/sw/siw/siw_qp.c | 14 ++++++++++----
drivers/infiniband/sw/siw/siw_verbs.c | 16 +++++++++++-----
include/uapi/rdma/siw-abi.h | 3 ++-
11 files changed, 53 insertions(+), 41 deletions(-)
--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD
The pull request you sent on Wed, 14 Aug 2019 10:59:07 -0400:
> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git tags/for-linus
has been merged into torvalds/linux.git:
https://git.kernel.org/torvalds/c/a8dba0531bc0ba8b65e77a4a858da4b6eeaa1b92
Thank you!
--
Deet-doot-dot, I am a bot.
https://korg.wiki.kernel.org/userdoc/prtracker
Hi Doug, Bernard,
On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <[email protected]> wrote:
> Fairly small pull request for -rc3. I'm out of town the rest of this
> week, so I made sure to clean out as much as possible from patchworks in
> enough time for 0-day to chew through it (Yay! for 0-day being back
> online! :-)). Jason might send through any emergency stuff that could
> pop up, otherwise I'm back next week.
>
> The only real thing of note is the siw ABI change. Since we just merged
> siw *this* release, there are no prior kernel releases to maintain
> kernel ABI with. I told Bernard that if there is anything else about
> the siw ABI he thinks he might want to change before it goes set in
> stone, he should get it in ASAP. The siw module was around for several
> years outside the kernel tree, and it had to be revamped considerably
> for inclusion upstream, so we are making no attempts to be backward
> compatible with the out of tree version. Once 5.3 is actually released,
> we will have our baseline ABI to maintain.
[...]
> - Allow siw to be built on 32bit arches (siw, ABI change, but OK since
> siw was just merged this merge window and there is no prior released
> kernel to maintain compatibility with and we also updated the
> rdma-core user space package to match)
> Bernard Metzler (1):
> RDMA/siw: Change CQ flags from 64->32 bits
Obviously none of this was ever compiled for a 32-bit platform?!?
Patch sent to kill the warnings.
But there may be deeper issues not exposed by them.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote:
> Hi Doug, Bernard,
>
> On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <[email protected]> wrote:
> > Fairly small pull request for -rc3. I'm out of town the rest of this
> > week, so I made sure to clean out as much as possible from patchworks in
> > enough time for 0-day to chew through it (Yay! for 0-day being back
> > online! :-)). Jason might send through any emergency stuff that could
> > pop up, otherwise I'm back next week.
> >
> > The only real thing of note is the siw ABI change. Since we just merged
> > siw *this* release, there are no prior kernel releases to maintain
> > kernel ABI with. I told Bernard that if there is anything else about
> > the siw ABI he thinks he might want to change before it goes set in
> > stone, he should get it in ASAP. The siw module was around for several
> > years outside the kernel tree, and it had to be revamped considerably
> > for inclusion upstream, so we are making no attempts to be backward
> > compatible with the out of tree version. Once 5.3 is actually released,
> > we will have our baseline ABI to maintain.
>
> [...]
>
> > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since
> > siw was just merged this merge window and there is no prior released
> > kernel to maintain compatibility with and we also updated the
> > rdma-core user space package to match)
>
> > Bernard Metzler (1):
> > RDMA/siw: Change CQ flags from 64->32 bits
>
> Obviously none of this was ever compiled for a 32-bit platform?!?
It is puzzling that 0-day or anyone testing linux-next hasn't noticed
this in that last 7 weeks are so..
Jason
Hi Jason,
On Mon, Aug 19, 2019 at 2:14 PM Jason Gunthorpe <[email protected]> wrote:
> On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote:
> > On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <[email protected]> wrote:
> > > Fairly small pull request for -rc3. I'm out of town the rest of this
> > > week, so I made sure to clean out as much as possible from patchworks in
> > > enough time for 0-day to chew through it (Yay! for 0-day being back
> > > online! :-)). Jason might send through any emergency stuff that could
> > > pop up, otherwise I'm back next week.
> > >
> > > The only real thing of note is the siw ABI change. Since we just merged
> > > siw *this* release, there are no prior kernel releases to maintain
> > > kernel ABI with. I told Bernard that if there is anything else about
> > > the siw ABI he thinks he might want to change before it goes set in
> > > stone, he should get it in ASAP. The siw module was around for several
> > > years outside the kernel tree, and it had to be revamped considerably
> > > for inclusion upstream, so we are making no attempts to be backward
> > > compatible with the out of tree version. Once 5.3 is actually released,
> > > we will have our baseline ABI to maintain.
> >
> > [...]
> >
> > > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since
> > > siw was just merged this merge window and there is no prior released
> > > kernel to maintain compatibility with and we also updated the
> > > rdma-core user space package to match)
> >
> > > Bernard Metzler (1):
> > > RDMA/siw: Change CQ flags from 64->32 bits
> >
> > Obviously none of this was ever compiled for a 32-bit platform?!?
>
> It is puzzling that 0-day or anyone testing linux-next hasn't noticed
> this in that last 7 weeks are so..
Fair enough. The autobuilders have become a bit overloaded lately.
Still, I would expect a commit that makes a last-minute ABI change to
enable support for 32-bit platforms, to actually compile cleanly on
these 32-bit platforms.
To me, this looks like a big red flag...
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- [email protected]
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
On Mon, Aug 19, 2019 at 02:29:46PM +0200, Geert Uytterhoeven wrote:
> Hi Jason,
>
> On Mon, Aug 19, 2019 at 2:14 PM Jason Gunthorpe <[email protected]> wrote:
> > On Mon, Aug 19, 2019 at 12:08:16PM +0200, Geert Uytterhoeven wrote:
> > > On Wed, Aug 14, 2019 at 5:00 PM Doug Ledford <[email protected]> wrote:
> > > > Fairly small pull request for -rc3. I'm out of town the rest of this
> > > > week, so I made sure to clean out as much as possible from patchworks in
> > > > enough time for 0-day to chew through it (Yay! for 0-day being back
> > > > online! :-)). Jason might send through any emergency stuff that could
> > > > pop up, otherwise I'm back next week.
> > > >
> > > > The only real thing of note is the siw ABI change. Since we just merged
> > > > siw *this* release, there are no prior kernel releases to maintain
> > > > kernel ABI with. I told Bernard that if there is anything else about
> > > > the siw ABI he thinks he might want to change before it goes set in
> > > > stone, he should get it in ASAP. The siw module was around for several
> > > > years outside the kernel tree, and it had to be revamped considerably
> > > > for inclusion upstream, so we are making no attempts to be backward
> > > > compatible with the out of tree version. Once 5.3 is actually released,
> > > > we will have our baseline ABI to maintain.
> > >
> > > [...]
> > >
> > > > - Allow siw to be built on 32bit arches (siw, ABI change, but OK since
> > > > siw was just merged this merge window and there is no prior released
> > > > kernel to maintain compatibility with and we also updated the
> > > > rdma-core user space package to match)
> > >
> > > > Bernard Metzler (1):
> > > > RDMA/siw: Change CQ flags from 64->32 bits
> > >
> > > Obviously none of this was ever compiled for a 32-bit platform?!?
> >
> > It is puzzling that 0-day or anyone testing linux-next hasn't noticed
> > this in that last 7 weeks are so..
>
> Fair enough. The autobuilders have become a bit overloaded lately.
>
> Still, I would expect a commit that makes a last-minute ABI change to
> enable support for 32-bit platforms, to actually compile cleanly on
> these 32-bit platforms.
> To me, this looks like a big red flag...
Again, I don't know why 0-day didn't report anything. I have success
logs from it saying it compiled a tree including siw on i386
allmodconfig - I don't know why you are seeing 32 bit warnings when
0-day is not reporting anything.
Jason
Hi Linus,
I didn't notice I was on my personal email identity when I sent the pull
request. Sorry about that. It's really me ;-)
On Fri, 2019-08-23 at 14:48 -0400, Doug Ledford wrote:
> Hi Linus,
>
> No beating around the bush: this is a monster pull request for an -rc5
> kernel. Intel hit me with a series of fixes for TID processing.
> Mellanox hit me with a series for their UMR memory support.
>
> And we had one fix for siw that fixes the 32bit build warnings and
> because of the number of casts that had to be changed to properly
> silence the warnings, that one patch alone is a full 40% of the LOC of
> this entire pull request. Given that this is the initial release
> kernel
> for siw, I'm trying to fix anything in it that we can, so that adds to
> the impetus to take fixes for it like this one.
>
> I had to do a rebase early in the week. Jason had thought he put a
> patch on the rc queue that he needed to be there so he could base some
> work off of it, and it had actually not been placed there. So he
> asked
> me (on Tuesday) to fix that up before pushing my wip branch to the
> official rc branch. I did, and that's why the early patches look like
> they were all committed at the same time on Tuesday. That bunch had
> been in my queue prior.
>
> The various patches all pass my test for being legitimate fixes and
> not
> attempts to slide new features or development into a late rc. Well,
> they were all fixes with the exception of a couple clean up patches
> people wrote for making the fixes they also wrote better (like a
> cleanup
> patch to move UMR checking into a function so that the remaining UMR
> fix
> patches can reference that function), so I left those in place too.
>
> My apologies for the LOC count and the number of patches here, it's
> just
> how the cards fell this cycle. I hope you agree with me that they're
> justified fixes.
>
> Here's the boilerplate:
>
> The following changes since commit
> d1abaeb3be7b5fa6d7a1fbbd2e14e3310005c4c1:
>
> Linux 5.3-rc5 (2019-08-18 14:31:08 -0700)
>
> are available in the Git repository at:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma.git
> tags/for-linus
>
> for you to fetch changes up to
> c536277e0db1ad2e9fbb9dfd940c3565a14d9c52:
>
> RDMA/siw: Fix 64/32bit pointer inconsistency (2019-08-23 12:08:27
> -0400)
>
> ----------------------------------------------------------------
> Pull request for 5.3-rc5
>
> - Fix siw buffer mapping issue
> - Fix siw 32/64 casting issues
> - Fix a KASAN access issue in bnxt_re
> - Fix several memory leaks (hfi1, mlx4)
> - Fix a NULL deref in cma_cleanup
> - Fixes for UMR memory support in mlx5 (4 patch series)
> - Fix namespace check for restrack
> - Fixes for counter support
> - Fixes for hfi1 TID processing (5 patch series)
> - Fix potential NULL deref in siw
> - Fix memory page calculations in mlx5
>
> Signed-off-by: Doug Ledford <[email protected]>
>
> ----------------------------------------------------------------
> Bernard Metzler (3):
> RDMA/siw: Fix potential NULL de-ref
> RDMA/siw: Fix SGL mapping issues
> RDMA/siw: Fix 64/32bit pointer inconsistency
>
> Ido Kalir (1):
> IB/core: Fix NULL pointer dereference when bind QP to counter
>
> Jason Gunthorpe (1):
> RDMA/mlx5: Fix MR npages calculation for IB_ACCESS_HUGETLB
>
> Kaike Wan (5):
> IB/hfi1: Drop stale TID RDMA packets
> IB/hfi1: Unsafe PSN checking for TID RDMA READ Resp packet
> IB/hfi1: Add additional checks when handling TID RDMA READ RESP
> packet
> IB/hfi1: Add additional checks when handling TID RDMA WRITE DATA
> packet
> IB/hfi1: Drop stale TID RDMA packets that cause TIDErr
>
> Leon Romanovsky (2):
> RDMA/counters: Properly implement PID checks
> RDMA/restrack: Rewrite PID namespace check to be reliable
>
> Moni Shoua (4):
> IB/mlx5: Consolidate use_umr checks into single function
> IB/mlx5: Report and handle ODP support properly
> IB/mlx5: Fix MR re-registration flow to use UMR properly
> IB/mlx5: Block MR WR if UMR is not possible
>
> Selvin Xavier (1):
> RDMA/bnxt_re: Fix stack-out-of-bounds in
> bnxt_qplib_rcfw_send_message
>
> Wenwen Wang (3):
> IB/mlx4: Fix memory leaks
> infiniband: hfi1: fix a memory leak bug
> infiniband: hfi1: fix memory leaks
>
> zhengbin (1):
> RDMA/cma: fix null-ptr-deref Read in cma_cleanup
>
> drivers/infiniband/core/cma.c | 6 ++-
> drivers/infiniband/core/counters.c | 10 ++--
> drivers/infiniband/core/nldev.c | 3 +-
> drivers/infiniband/core/restrack.c | 15 +++---
> drivers/infiniband/core/umem.c | 7 +--
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.c | 8 ++-
> drivers/infiniband/hw/bnxt_re/qplib_rcfw.h | 11 ++--
> drivers/infiniband/hw/hfi1/fault.c | 12 +++--
> drivers/infiniband/hw/hfi1/tid_rdma.c | 76 ++++++++++-----------
> ------
> drivers/infiniband/hw/mlx4/mad.c | 4 +-
> drivers/infiniband/hw/mlx5/main.c | 6 +--
> drivers/infiniband/hw/mlx5/mem.c | 5 +-
> drivers/infiniband/hw/mlx5/mlx5_ib.h | 14 +++++
> drivers/infiniband/hw/mlx5/mr.c | 7 ++-
> drivers/infiniband/hw/mlx5/odp.c | 17 ++++---
> drivers/infiniband/hw/mlx5/qp.c | 24 +++++++--
> drivers/infiniband/sw/siw/siw.h | 8 +--
> drivers/infiniband/sw/siw/siw_cm.c | 82 ++++++++++++++-------
> ---------
> drivers/infiniband/sw/siw/siw_cq.c | 5 +-
> drivers/infiniband/sw/siw/siw_mem.c | 14 ++---
> drivers/infiniband/sw/siw/siw_mem.h | 2 +-
> drivers/infiniband/sw/siw/siw_qp.c | 2 +-
> drivers/infiniband/sw/siw/siw_qp_rx.c | 26 +++++-----
> drivers/infiniband/sw/siw/siw_qp_tx.c | 80 ++++++++++++++-------
> --------
> drivers/infiniband/sw/siw/siw_verbs.c | 40 +++++++--------
> include/rdma/restrack.h | 3 +-
> 26 files changed, 248 insertions(+), 239 deletions(-)
>
--
Doug Ledford <[email protected]>
GPG KeyID: B826A3330E572FDD
Fingerprint = AE6B 1BDA 122B 23B4 265B 1274 B826 A333 0E57 2FDD