2023-12-07 15:24:32

by Michal Simek

Subject: [PATCH] soc: xilinx: Add error message for invalid payload received from IPI callback.

From: Naman Trivedi Manojbhai <[email protected]>

payload[0] of response buffer of zynqmp_pm_get_callback_data()
contains valid payload or error code in case of error.

Added error message to inform user about the error code received in
payload[0].

Signed-off-by: Naman Trivedi Manojbhai <[email protected]>
Signed-off-by: Michal Simek <[email protected]>
---

drivers/soc/xilinx/zynqmp_power.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
index abcf7e883279..07d735b38b49 100644
--- a/drivers/soc/xilinx/zynqmp_power.c
+++ b/drivers/soc/xilinx/zynqmp_power.c
@@ -86,6 +86,8 @@ static irqreturn_t zynqmp_pm_isr(int irq, void *data)
pr_err("%s Unsupported InitSuspendCb reason code %d\n",
__func__, payload[1]);
}
+ } else {
+ pr_err("%s() Unsupported Callback %d\n", __func__, payload[0]);
}

return IRQ_HANDLED;
--
2.36.1

2023-12-13 15:55:44

by Michal Simek

Subject: Re: [PATCH] soc: xilinx: Add error message for invalid payload received from IPI callback.

On 12/7/23 16:24, Michal Simek wrote:
> From: Naman Trivedi Manojbhai <[email protected]>
>
> payload[0] of response buffer of zynqmp_pm_get_callback_data()
> contains valid payload or error code in case of error.
>
> Added error message to inform user about the error code received in
> payload[0].
>
> Signed-off-by: Naman Trivedi Manojbhai <[email protected]>
> Signed-off-by: Michal Simek <[email protected]>
> ---
>
> drivers/soc/xilinx/zynqmp_power.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/soc/xilinx/zynqmp_power.c b/drivers/soc/xilinx/zynqmp_power.c
> index abcf7e883279..07d735b38b49 100644
> --- a/drivers/soc/xilinx/zynqmp_power.c
> +++ b/drivers/soc/xilinx/zynqmp_power.c
> @@ -86,6 +86,8 @@ static irqreturn_t zynqmp_pm_isr(int irq, void *data)
> pr_err("%s Unsupported InitSuspendCb reason code %d\n",
> __func__, payload[1]);
> }
> + } else {
> + pr_err("%s() Unsupported Callback %d\n", __func__, payload[0]);
> }
>
> return IRQ_HANDLED;

Applied.
M