2018-12-14 10:22:22

by jotun9935

Subject: [PATCH] partitions: fix coding style

From: Sungkyung Kim <[email protected]>

Fix coding style of osf.c

Signed-off-by: Sungkyung Kim <[email protected]>
---
block/partitions/osf.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/block/partitions/osf.c b/block/partitions/osf.c
index 4b873973d6c0..19f8e91979f0 100644
--- a/block/partitions/osf.c
+++ b/block/partitions/osf.c
@@ -22,7 +22,7 @@ int osf_partition(struct parsed_partitions *state)
unsigned char *data;
struct disklabel {
__le32 d_magic;
- __le16 d_type,d_subtype;
+ __le16 d_type, d_subtype;
u8 d_typename[16];
u8 d_packname[16];
__le32 d_secsize;
@@ -50,14 +50,14 @@ int osf_partition(struct parsed_partitions *state)
u8 p_frag;
__le16 p_cpg;
} d_partitions[MAX_OSF_PARTITIONS];
- } * label;
- struct d_partition * partition;
+ } *label;
+ struct d_partition *partition;

data = read_part_sector(state, 0, &sect);
if (!data)
return -1;

- label = (struct disklabel *) (data+64);
+ label = (struct disklabel *) (data + 64);
partition = label->d_partitions;
if (le32_to_cpu(label->d_magic) != DISKLABELMAGIC) {
put_dev_sector(sect);
@@ -74,7 +74,7 @@ int osf_partition(struct parsed_partitions *state)
}
for (i = 0 ; i < npartitions; i++, partition++) {
if (slot == state->limit)
- break;
+ break;
if (le32_to_cpu(partition->p_size))
put_partition(state, slot,
le32_to_cpu(partition->p_offset),
--
2.18.0

2018-12-14 10:58:17

by Mukesh Ojha

Subject: Re: [PATCH] partitions: fix coding style

Please read the guideline as well before sending patch.

you need to maintain patchset version as well, e.g: in which patchset
what is changed on whose comments.


-Mukesh


On 12/14/2018 3:49 PM, [email protected] wrote:
> From: Sungkyung Kim <[email protected]>
>
> Fix coding style of osf.c
>
> Signed-off-by: Sungkyung Kim <[email protected]>
> ---
> block/partitions/osf.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/block/partitions/osf.c b/block/partitions/osf.c
> index 4b873973d6c0..19f8e91979f0 100644
> --- a/block/partitions/osf.c
> +++ b/block/partitions/osf.c
> @@ -22,7 +22,7 @@ int osf_partition(struct parsed_partitions *state)
> unsigned char *data;
> struct disklabel {
> __le32 d_magic;
> - __le16 d_type,d_subtype;
> + __le16 d_type, d_subtype;
> u8 d_typename[16];
> u8 d_packname[16];
> __le32 d_secsize;
> @@ -50,14 +50,14 @@ int osf_partition(struct parsed_partitions *state)
> u8 p_frag;
> __le16 p_cpg;
> } d_partitions[MAX_OSF_PARTITIONS];
> - } * label;
> - struct d_partition * partition;
> + } *label;
> + struct d_partition *partition;
>
> data = read_part_sector(state, 0, &sect);
> if (!data)
> return -1;
>
> - label = (struct disklabel *) (data+64);
> + label = (struct disklabel *) (data + 64);
> partition = label->d_partitions;
> if (le32_to_cpu(label->d_magic) != DISKLABELMAGIC) {
> put_dev_sector(sect);
> @@ -74,7 +74,7 @@ int osf_partition(struct parsed_partitions *state)
> }
> for (i = 0 ; i < npartitions; i++, partition++) {
> if (slot == state->limit)
> - break;
> + break;
> if (le32_to_cpu(partition->p_size))
> put_partition(state, slot,
> le32_to_cpu(partition->p_offset),