2024-03-17 00:42:11

by Aren

Subject: [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node

The red, green, and blue LEDs currently in the device tree represent a
single RGB LED on the front of the PinePhone.

Signed-off-by: Aren Moynihan <[email protected]>
---

Changes in v3:
- add function property back to individual LED nodes to minimize
breaking changes

Changes in v2:
- remove function property from individual LED nodes

.../boot/dts/allwinner/sun50i-a64-pinephone.dtsi | 13 ++++++++++---
1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
index ad2476ee01e4..6eab61a12cd8 100644
--- a/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
+++ b/arch/arm64/boot/dts/allwinner/sun50i-a64-pinephone.dtsi
@@ -39,21 +39,21 @@ chosen {
leds {
compatible = "gpio-leds";

- led-0 {
+ led0: led-0 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_BLUE>;
gpios = <&pio 3 20 GPIO_ACTIVE_HIGH>; /* PD20 */
retain-state-suspended;
};

- led-1 {
+ led1: led-1 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_GREEN>;
gpios = <&pio 3 18 GPIO_ACTIVE_HIGH>; /* PD18 */
retain-state-suspended;
};

- led-2 {
+ led2: led-2 {
function = LED_FUNCTION_INDICATOR;
color = <LED_COLOR_ID_RED>;
gpios = <&pio 3 19 GPIO_ACTIVE_HIGH>; /* PD19 */
@@ -61,6 +61,13 @@ led-2 {
};
};

+ multi-led {
+ compatible = "leds-group-multicolor";
+ color = <LED_COLOR_ID_RGB>;
+ function = LED_FUNCTION_INDICATOR;
+ leds = <&led0>, <&led1>, <&led2>;
+ };
+
reg_ps: ps-regulator {
compatible = "regulator-fixed";
regulator-name = "ps";
--
2.44.0

2024-03-26 22:53:18

by Jernej Škrabec

Subject: Re: [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node

Dne nedelja, 17. marec 2024 ob 01:39:29 CET je Aren Moynihan napisal(a):
> The red, green, and blue LEDs currently in the device tree represent a
> single RGB LED on the front of the PinePhone.
>
> Signed-off-by: Aren Moynihan <[email protected]>

Acked-by: Jernej Skrabec <[email protected]>

Best regards,
Jernej

2024-04-15 21:08:12

by Jernej Škrabec

Subject: Re: [PATCH v3 2/2] arm64: dts: allwinner: pinephone: add multicolor LED node

Dne torek, 26. marec 2024 ob 23:44:39 GMT +2 je Jernej Škrabec napisal(a):
> Dne nedelja, 17. marec 2024 ob 01:39:29 CET je Aren Moynihan napisal(a):
> > The red, green, and blue LEDs currently in the device tree represent a
> > single RGB LED on the front of the PinePhone.
> >
> > Signed-off-by: Aren Moynihan <[email protected]>
>
> Acked-by: Jernej Skrabec <[email protected]>

Applied both, thanks!

Best regards,
Jernej