2015-08-17 11:51:39

by Valentin Rothberg

[permalink] [raw]
Subject: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix

Remove the 'CONFIG_' prefix of the Kconfig options PRESCAN_RXQ and
SDMA_VERBOSITY in Kconfig. Such prefix in Kconfig requires a double
'CONFIG_CONFIG_' prefix in Make and CPP syntax.

Since both options are referenced in the hfi1 source code as
CONFIG_{PRESCAN_RXQ, SDMA_VERBOSITY} the referencing #ifdef's can now be
compiled.

Signed-off-by: Valentin Rothberg <[email protected]>
---
Note that this issue was present since the driver's config files have
been added by commit 8214d07e6f21 ("IB/hfi1: add driver make/config
files"). This change does not introduce any build issues, but I cannot
test it.

I detected this issues with scripts/checkkconfigsymbols.py by diffing
next-20150814..next-20150817

drivers/staging/hfi1/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/hfi1/Kconfig b/drivers/staging/hfi1/Kconfig
index 87a385a02cba..fd25078ee923 100644
--- a/drivers/staging/hfi1/Kconfig
+++ b/drivers/staging/hfi1/Kconfig
@@ -18,14 +18,14 @@ config HFI1_VERBS_31BIT_PSN
---help---
Setting this enables 31 BIT PSN
For verbs RC/UC
-config CONFIG_SDMA_VERBOSITY
+config SDMA_VERBOSITY
bool "Config SDMA Verbosity"
depends on INFINIBAND_HFI1
default n
---help---
This is a configuration flag to enable verbose
SDMA debug
-config CONFIG_PRESCAN_RXQ
+config PRESCAN_RXQ
bool "Enable prescanning of the RX queue for ECNs"
depends on INFINIBAND_HFI1
default n
--
1.9.1


2015-08-17 13:16:16

by Marciniszyn, Mike

[permalink] [raw]
Subject: RE: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix

> Subject: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
> Signed-off-by: Valentin Rothberg <[email protected]>
> ---

Thanks for the patch!

Acked-by: Mike Marciniszyn <[email protected]>

2015-08-18 19:46:43

by Marciniszyn, Mike

[permalink] [raw]
Subject: RE: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix

> Subject: [PATCH] staging: hfi1: Kconfig: remove 'CONFIG_' prefix
>
> Remove the 'CONFIG_' prefix of the Kconfig options PRESCAN_RXQ and
> SDMA_VERBOSITY in Kconfig. Such prefix in Kconfig requires a double
> 'CONFIG_CONFIG_' prefix in Make and CPP syntax.
>

Doug, can you pull this one in?

There is a Kconfig checker that caught this one!

Mike