2021-03-27 09:57:51

by chenlifu

Subject: [PATCH -next] ARM: OMAP: Use DEFINE_SPINLOCK() for spinlock

From: Lifu Chen <[email protected]>

spinlock can be initialized automatically with DEFINE_SPINLOCK()
rather than explicitly calling spin_lock_init().

Reported-by: Hulk Robot <[email protected]>
Signed-off-by: Lifu Chen <[email protected]>
---
arch/arm/plat-omap/dma.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/arch/arm/plat-omap/dma.c b/arch/arm/plat-omap/dma.c
index 1eb59003bdec..9f11de46aaa9 100644
--- a/arch/arm/plat-omap/dma.c
+++ b/arch/arm/plat-omap/dma.c
@@ -85,7 +85,7 @@ static int dma_lch_count;
static int dma_chan_count;
static int omap_dma_reserve_channels;

-static spinlock_t dma_chan_lock;
+static DEFINE_SPINLOCK(dma_chan_lock);
static struct omap_dma_lch *dma_chan;

static inline void disable_lnk(int lch);
@@ -902,7 +902,6 @@ static int omap_system_dma_probe(struct platform_device *pdev)
if (!dma_chan)
return -ENOMEM;

- spin_lock_init(&dma_chan_lock);
for (ch = 0; ch < dma_chan_count; ch++) {
omap_clear_dma(ch);

2021-03-31 06:01:12

by Tony Lindgren

Subject: Re: [PATCH -next] ARM: OMAP: Use DEFINE_SPINLOCK() for spinlock

* Chen Lifu <[email protected]> [210327 11:53]:
> From: Lifu Chen <[email protected]>
>
> spinlock can be initialized automatically with DEFINE_SPINLOCK()
> rather than explicitly calling spin_lock_init().

Thanks applying into omap-for-v5.13/soc.

Tony

2021-03-31 09:07:06

by chenlifu

Subject: Re: [PATCH -next] ARM: OMAP: Use DEFINE_SPINLOCK() for spinlock

?? 2021/3/31 13:59, Tony Lindgren д??:
> * Chen Lifu <[email protected]> [210327 11:53]:
>> From: Lifu Chen <[email protected]>
>>
>> spinlock can be initialized automatically with DEFINE_SPINLOCK()
>> rather than explicitly calling spin_lock_init().
>
> Thanks applying into omap-for-v5.13/soc.
>
> Tony
> .
>

Thanks!

---
Chen Lifu