2022-06-20 22:22:54

by Paul E. McKenney

Subject: [PATCH rcu 05/12] rcu: Forbid RCU_STRICT_GRACE_PERIOD in TINY_RCU kernels

The RCU_STRICT_GRACE_PERIOD Kconfig option does nothing in kernels
built with CONFIG_TINY_RCU=y, so this commit adjusts the dependencies
to disallow this combination.

Signed-off-by: Paul E. McKenney <[email protected]>
---
kernel/rcu/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug
index 9b64e55d4f615..4da05beb13d79 100644
--- a/kernel/rcu/Kconfig.debug
+++ b/kernel/rcu/Kconfig.debug
@@ -121,7 +121,7 @@ config RCU_EQS_DEBUG

config RCU_STRICT_GRACE_PERIOD
bool "Provide debug RCU implementation with short grace periods"
- depends on DEBUG_KERNEL && RCU_EXPERT && NR_CPUS <= 4
+ depends on DEBUG_KERNEL && RCU_EXPERT && NR_CPUS <= 4 && !TINY_RCU
default n
select PREEMPT_COUNT if PREEMPT=n
help
--
2.31.1.189.g2e36527f23

2022-06-21 06:27:36

by Neeraj Upadhyay

Subject: Re: [PATCH rcu 05/12] rcu: Forbid RCU_STRICT_GRACE_PERIOD in TINY_RCU kernels

On 6/21/2022 3:50 AM, Paul E. McKenney wrote:
> The RCU_STRICT_GRACE_PERIOD Kconfig option does nothing in kernels
> built with CONFIG_TINY_RCU=y, so this commit adjusts the dependencies
> to disallow this combination.
>
> Signed-off-by: Paul E. McKenney <[email protected]>
> ---

Reviewed-by: Neeraj Upadhyay <[email protected]>


Thanks
Neeraj

> kernel/rcu/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/rcu/Kconfig.debug b/kernel/rcu/Kconfig.debug
> index 9b64e55d4f615..4da05beb13d79 100644
> --- a/kernel/rcu/Kconfig.debug
> +++ b/kernel/rcu/Kconfig.debug
> @@ -121,7 +121,7 @@ config RCU_EQS_DEBUG
>
> config RCU_STRICT_GRACE_PERIOD
> bool "Provide debug RCU implementation with short grace periods"
> - depends on DEBUG_KERNEL && RCU_EXPERT && NR_CPUS <= 4
> + depends on DEBUG_KERNEL && RCU_EXPERT && NR_CPUS <= 4 && !TINY_RCU
> default n
> select PREEMPT_COUNT if PREEMPT=n
> help