Fix BUG_ON() error if tps65910 VRTC regulator is used with out
rdev->desc->volt_table data. Recent changes in regulator core driver
which add support for "regulator_list_voltage_table" have BUG_ON() if
regulator descriptor do not have voltage table information. This patch
adds the voltage table information to fix the issue.
Signed-off-by: AnilKumar Ch <[email protected]>
---
drivers/regulator/tps65910-regulator.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/drivers/regulator/tps65910-regulator.c b/drivers/regulator/tps65910-regulator.c
index 793adda..1d2dd18 100644
--- a/drivers/regulator/tps65910-regulator.c
+++ b/drivers/regulator/tps65910-regulator.c
@@ -38,6 +38,11 @@ static const unsigned int VIO_VSEL_table[] = {
/* VSEL tables for TPS65910 specific LDOs and dcdc's */
+/* supported VRTC voltages in microvolts */
+static const unsigned int VRTC_VSEL_table[] = {
+ 1800000,
+};
+
/* supported VDD3 voltages in microvolts */
static const unsigned int VDD3_VSEL_table[] = {
5000000,
@@ -95,6 +100,8 @@ static struct tps_info tps65910_regs[] = {
{
.name = "vrtc",
.vin_name = "vcc7",
+ .n_voltages = ARRAY_SIZE(VRTC_VSEL_table),
+ .voltage_table = VRTC_VSEL_table,
.enable_time_us = 2200,
},
{
--
1.7.9.5
On Wed, Nov 14, 2012 at 11:24:39AM +0530, AnilKumar Ch wrote:
> Fix BUG_ON() error if tps65910 VRTC regulator is used with out
> rdev->desc->volt_table data. Recent changes in regulator core driver
> which add support for "regulator_list_voltage_table" have BUG_ON() if
> regulator descriptor do not have voltage table information. This patch
> adds the voltage table information to fix the issue.
This is already applied... got dropped from -next for a day for some
reason but it's there. When resending please do say why.
On Wed, Nov 14, 2012 at 11:49:14, Mark Brown wrote:
> On Wed, Nov 14, 2012 at 11:24:39AM +0530, AnilKumar Ch wrote:
> > Fix BUG_ON() error if tps65910 VRTC regulator is used with out
> > rdev->desc->volt_table data. Recent changes in regulator core driver
> > which add support for "regulator_list_voltage_table" have BUG_ON() if
> > regulator descriptor do not have voltage table information. This patch
> > adds the voltage table information to fix the issue.
>
> This is already applied... got dropped from -next for a day for some
> reason but it's there. When resending please do say why.
>
Hi Mark,
Sorry for the noise (My bad missed the version change details). I have
checked in regulator/for-next tree and not found, so resend the patch
thanks for you time.
Thanks
AnilKumar
On Wed, Nov 14, 2012 at 06:25:15AM +0000, AnilKumar, Chimata wrote:
> On Wed, Nov 14, 2012 at 11:49:14, Mark Brown wrote:
> > This is already applied... got dropped from -next for a day for some
> > reason but it's there. When resending please do say why.
> Sorry for the noise (My bad missed the version change details). I have
> checked in regulator/for-next tree and not found, so resend the patch
> thanks for you time.
Sure, no problem - the thing about saying why you're reposting is more
for future reference, if you follow my advice and repost when you think
something got forgotten or lost.