This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory
timings for RAM code 0 registered" warning message during of kernels
boot-up on Tegra20.
Signed-off-by: Dmitry Osipenko <[email protected]>
---
drivers/memory/tegra/mc.c | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index bd25faf6d13d..e56862495f36 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -664,12 +664,13 @@ static int tegra_mc_probe(struct platform_device *pdev)
}
isr = tegra_mc_irq;
- }
- err = tegra_mc_setup_timings(mc);
- if (err < 0) {
- dev_err(&pdev->dev, "failed to setup timings: %d\n", err);
- return err;
+ err = tegra_mc_setup_timings(mc);
+ if (err < 0) {
+ dev_err(&pdev->dev, "failed to setup timings: %d\n",
+ err);
+ return err;
+ }
}
mc->irq = platform_get_irq(pdev, 0);
--
2.18.0
On 19/07/18 14:24, Dmitry Osipenko wrote:
> This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory
> timings for RAM code 0 registered" warning message during of kernels
> boot-up on Tegra20.
Looking at the tegra20-emc.txt bindings doc [0], the 'nvidia,ram-code'
property is also valid for Tegra20. In fact, I see this warning on the
Tegra30 Cardhu because this property is not populated. So I think that
this warning is valid and harmless.
Cheers
Jon
[0] Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt
--
nvpublic
On Thursday, 19 July 2018 18:30:48 MSK Jon Hunter wrote:
> On 19/07/18 14:24, Dmitry Osipenko wrote:
> > This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory
> > timings for RAM code 0 registered" warning message during of kernels
> > boot-up on Tegra20.
>
> Looking at the tegra20-emc.txt bindings doc [0], the 'nvidia,ram-code'
> property is also valid for Tegra20. In fact, I see this warning on the
> Tegra30 Cardhu because this property is not populated. So I think that
> this warning is valid and harmless.
>
> Cheers
> Jon
>
> [0] Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt
That is the irrelevant binding, the relevant one for this driver is [0]. The
warning is valid for T30+, but not for T20.
[0] Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt
On 19/07/18 16:38, Dmitry Osipenko wrote:
> On Thursday, 19 July 2018 18:30:48 MSK Jon Hunter wrote:
>> On 19/07/18 14:24, Dmitry Osipenko wrote:
>>> This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory
>>> timings for RAM code 0 registered" warning message during of kernels
>>> boot-up on Tegra20.
>>
>> Looking at the tegra20-emc.txt bindings doc [0], the 'nvidia,ram-code'
>> property is also valid for Tegra20. In fact, I see this warning on the
>> Tegra30 Cardhu because this property is not populated. So I think that
>> this warning is valid and harmless.
>>
>> Cheers
>> Jon
>>
>> [0] Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt
>
> That is the irrelevant binding, the relevant one for this driver is [0]. The
> warning is valid for T30+, but not for T20.
>
> [0] Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.txt
Yes indeed, looks like we never supported this for Tegra20. OK, fine with me
I guess this was introduced during the consolidation of the MC drivers. Can
you add the appropriate fixes tag?
Otherwise ...
Acked-by: Jon Hunter <[email protected]>
Cheers
Jon
--
nvpublic
On Friday, 20 July 2018 11:02:04 MSK Jon Hunter wrote:
> On 19/07/18 16:38, Dmitry Osipenko wrote:
> > On Thursday, 19 July 2018 18:30:48 MSK Jon Hunter wrote:
> >> On 19/07/18 14:24, Dmitry Osipenko wrote:
> >>> This fixes irrelevant "tegra-mc 7000f000.memory-controller: no memory
> >>> timings for RAM code 0 registered" warning message during of kernels
> >>> boot-up on Tegra20.
> >>
> >> Looking at the tegra20-emc.txt bindings doc [0], the 'nvidia,ram-code'
> >> property is also valid for Tegra20. In fact, I see this warning on the
> >> Tegra30 Cardhu because this property is not populated. So I think that
> >> this warning is valid and harmless.
> >>
> >> Cheers
> >> Jon
> >>
> >> [0] Documentation/devicetree/bindings/arm/tegra/nvidia,tegra20-emc.txt
> >
> > That is the irrelevant binding, the relevant one for this driver is [0].
> > The warning is valid for T30+, but not for T20.
> >
> > [0]
> > Documentation/devicetree/bindings/memory-controllers/nvidia,tegra20-mc.tx
> > t
> Yes indeed, looks like we never supported this for Tegra20. OK, fine with me
> I guess this was introduced during the consolidation of the MC drivers. Can
> you add the appropriate fixes tag?
>
Sure, I can send v2 over next week.