Add generic Sunplus SP7021 based board defconfig
Signed-off-by: Qin Jian <[email protected]>
---
MAINTAINERS | 1 +
arch/arm/configs/multi_v7_defconfig | 1 +
arch/arm/configs/sp7021_defconfig | 61 +++++++++++++++++++++++++++++
3 files changed, 63 insertions(+)
create mode 100644 arch/arm/configs/sp7021_defconfig
diff --git a/MAINTAINERS b/MAINTAINERS
index 38890c055..93f4de6c1 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -2747,6 +2747,7 @@ F: Documentation/devicetree/bindings/arm/sunplus,sp7021.yaml
F: Documentation/devicetree/bindings/clock/sunplus,sp7021-clkc.yaml
F: Documentation/devicetree/bindings/interrupt-controller/sunplus,sp7021-intc.yaml
F: Documentation/devicetree/bindings/reset/sunplus,reset.yaml
+F: arch/arm/configs/sp7021_*defconfig
F: arch/arm/mach-sunplus/
F: drivers/clk/clk-sp7021.c
F: drivers/irqchip/irq-sp7021-intc.c
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index 8863fa969..a3bd9dbd8 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
CONFIG_MACH_SPEAR1340=y
CONFIG_ARCH_STI=y
CONFIG_ARCH_STM32=y
+CONFIG_ARCH_SUNPLUS=y
CONFIG_ARCH_SUNXI=y
CONFIG_ARCH_TEGRA=y
CONFIG_ARCH_UNIPHIER=y
diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
new file mode 100644
index 000000000..cda16d33a
--- /dev/null
+++ b/arch/arm/configs/sp7021_defconfig
@@ -0,0 +1,61 @@
+CONFIG_SYSVIPC=y
+CONFIG_NO_HZ_IDLE=y
+CONFIG_HIGH_RES_TIMERS=y
+CONFIG_PREEMPT=y
+CONFIG_IKCONFIG=y
+CONFIG_IKCONFIG_PROC=y
+CONFIG_LOG_BUF_SHIFT=14
+# CONFIG_RD_GZIP is not set
+# CONFIG_RD_BZIP2 is not set
+# CONFIG_RD_LZMA is not set
+# CONFIG_RD_XZ is not set
+# CONFIG_RD_LZO is not set
+# CONFIG_RD_LZ4 is not set
+CONFIG_CC_OPTIMIZE_FOR_SIZE=y
+CONFIG_PERF_EVENTS=y
+CONFIG_SLAB=y
+CONFIG_ARCH_SUNPLUS=y
+# CONFIG_VDSO is not set
+CONFIG_SMP=y
+CONFIG_HAVE_ARM_ARCH_TIMER=y
+CONFIG_THUMB2_KERNEL=y
+CONFIG_FORCE_MAX_ZONEORDER=12
+CONFIG_VFP=y
+CONFIG_NEON=y
+CONFIG_MODULES=y
+CONFIG_MODULE_UNLOAD=y
+CONFIG_MODVERSIONS=y
+# CONFIG_CORE_DUMP_DEFAULT_ELF_HEADERS is not set
+CONFIG_UEVENT_HELPER=y
+CONFIG_UEVENT_HELPER_PATH="/sbin/hotplug"
+CONFIG_DEVTMPFS=y
+CONFIG_DEVTMPFS_MOUNT=y
+CONFIG_BLK_DEV_LOOP=y
+CONFIG_INPUT_SPARSEKMAP=y
+CONFIG_INPUT_EVDEV=y
+# CONFIG_INPUT_KEYBOARD is not set
+# CONFIG_INPUT_MOUSE is not set
+# CONFIG_LEGACY_PTYS is not set
+# CONFIG_HW_RANDOM is not set
+# CONFIG_HWMON is not set
+CONFIG_STAGING=y
+# CONFIG_IOMMU_SUPPORT is not set
+CONFIG_RESET_CONTROLLER=y
+CONFIG_EXT4_FS=y
+# CONFIG_DNOTIFY is not set
+CONFIG_FANOTIFY=y
+CONFIG_VFAT_FS=y
+CONFIG_FAT_DEFAULT_IOCHARSET="utf8"
+CONFIG_EXFAT_FS=y
+CONFIG_TMPFS=y
+CONFIG_TMPFS_POSIX_ACL=y
+# CONFIG_MISC_FILESYSTEMS is not set
+CONFIG_NLS_CODEPAGE_437=y
+CONFIG_NLS_ASCII=y
+CONFIG_NLS_ISO8859_1=y
+CONFIG_NLS_UTF8=y
+CONFIG_PRINTK_TIME=y
+CONFIG_DYNAMIC_DEBUG=y
+CONFIG_MAGIC_SYSRQ=y
+CONFIG_DEBUG_FS=y
+CONFIG_DEBUG_USER=y
--
2.33.1
On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <[email protected]> wrote:
> Add generic Sunplus SP7021 based board defconfig
Here, you should explain why you need a custom defconfig for this SoC, as
most platforms are fine just using the generic one. Are you too memory
constrained,
or are there other problems?
> diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> index 8863fa969..a3bd9dbd8 100644
> --- a/arch/arm/configs/multi_v7_defconfig
> +++ b/arch/arm/configs/multi_v7_defconfig
> @@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
> CONFIG_MACH_SPEAR1340=y
> CONFIG_ARCH_STI=y
> CONFIG_ARCH_STM32=y
> +CONFIG_ARCH_SUNPLUS=y
> CONFIG_ARCH_SUNXI=y
> CONFIG_ARCH_TEGRA=y
> CONFIG_ARCH_UNIPHIER=y
Don't you need any drivers here?
> diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
> new file mode 100644
> index 000000000..cda16d33a
> --- /dev/null
> +++ b/arch/arm/configs/sp7021_defconfig
...
> +CONFIG_HAVE_ARM_ARCH_TIMER=y
I checked this one again, as most others don't enable it in the defconfig.
I don't remember if I recommended removing the 'select' from Kconfig
in a previous round, but as that is where other platforms have it, I'd add
it there as well.
> +CONFIG_STAGING=y
Do you actually enable any staging drivers here? If not, I'd drop that bit.
Arnd
> On Thu, Mar 31, 2022 at 10:29 AM Qin Jian <[email protected]> wrote:
> > Add generic Sunplus SP7021 based board defconfig
>
> Here, you should explain why you need a custom defconfig for this SoC, as
> most platforms are fine just using the generic one. Are you too memory
> constrained,
> or are there other problems?
>
For memory constrained board only.
> > diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
> > index 8863fa969..a3bd9dbd8 100644
> > --- a/arch/arm/configs/multi_v7_defconfig
> > +++ b/arch/arm/configs/multi_v7_defconfig
> > @@ -86,6 +86,7 @@ CONFIG_MACH_SPEAR1310=y
> > CONFIG_MACH_SPEAR1340=y
> > CONFIG_ARCH_STI=y
> > CONFIG_ARCH_STM32=y
> > +CONFIG_ARCH_SUNPLUS=y
> > CONFIG_ARCH_SUNXI=y
> > CONFIG_ARCH_TEGRA=y
> > CONFIG_ARCH_UNIPHIER=y
>
> Don't you need any drivers here?
>
Currently, all basic drivers auto enabled by mach-sunplus/Kconfig:
...
config SOC_SP7021
bool "Sunplus SP7021 SoC support"
depends on ARCH_SUNPLUS
default ARCH_SUNPLUS
select ARM_GIC
select ARM_PSCI
select PINCTRL
select PINCTRL_SPPCTL
select SERIAL_SUNPLUS
select SERIAL_SUNPLUS_CONSOLE
and driver's Kconfig:
...
config RESET_SUNPLUS
bool "Sunplus SoCs Reset Driver" if COMPILE_TEST
default ARCH_SUNPLUS
...
> > diff --git a/arch/arm/configs/sp7021_defconfig b/arch/arm/configs/sp7021_defconfig
> > new file mode 100644
> > index 000000000..cda16d33a
> > --- /dev/null
> > +++ b/arch/arm/configs/sp7021_defconfig
> ...
> > +CONFIG_HAVE_ARM_ARCH_TIMER=y
>
> I checked this one again, as most others don't enable it in the defconfig.
>
> I don't remember if I recommended removing the 'select' from Kconfig
> in a previous round, but as that is where other platforms have it, I'd add
> it there as well.
>
I'll move this to mach-sunplus/Kconfig.
> > +CONFIG_STAGING=y
>
> Do you actually enable any staging drivers here? If not, I'd drop that bit.
>
I’ll drop it.
Thanks all your comments.