2023-07-14 09:33:34

by Wang Ming

Subject: [PATCH net v2] net: bonding: Remove error checking for debugfs_create_dir()

It is expected that most callers should _ignore_ the errors
return by debugfs_create_dir() in bond_debug_reregister().

Signed-off-by: Wang Ming <[email protected]>
---
drivers/net/bonding/bond_debugfs.c | 3 ---
1 file changed, 3 deletions(-)

diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
index 594094526648..a41f765420dc 100644
--- a/drivers/net/bonding/bond_debugfs.c
+++ b/drivers/net/bonding/bond_debugfs.c
@@ -87,9 +87,6 @@ void bond_debug_reregister(struct bonding *bond)
void bond_create_debugfs(void)
{
bonding_debug_root = debugfs_create_dir("bonding", NULL);
-
- if (!bonding_debug_root)
- pr_warn("Warning: Cannot create bonding directory in debugfs\n");
}

void bond_destroy_debugfs(void)
--
2.25.1

2023-07-14 16:37:05

by Jay Vosburgh

Subject: Re: [PATCH net v2] net: bonding: Remove error checking for debugfs_create_dir()

Wang Ming <[email protected]> wrote:

>It is expected that most callers should _ignore_ the errors
>return by debugfs_create_dir() in bond_debug_reregister().

Why should the error be ignored? It's not a fatal error, in the
sense that the bond itself should be unregistered, but I'm not sure why
an error message that the debugfs registration failed is undesirable.

Also, the code in question is in bond_create_debugfs(), not
bond_debug_reregister(). The diff below looks a bit odd in that the
context line lists _reregister, but that's not the function being
changed.

I thought the v1 patch was fine.

-J

>Signed-off-by: Wang Ming <[email protected]>
>---
> drivers/net/bonding/bond_debugfs.c | 3 ---
> 1 file changed, 3 deletions(-)
>
>diff --git a/drivers/net/bonding/bond_debugfs.c b/drivers/net/bonding/bond_debugfs.c
>index 594094526648..a41f765420dc 100644
>--- a/drivers/net/bonding/bond_debugfs.c
>+++ b/drivers/net/bonding/bond_debugfs.c
>@@ -87,9 +87,6 @@ void bond_debug_reregister(struct bonding *bond)
> void bond_create_debugfs(void)
> {
> bonding_debug_root = debugfs_create_dir("bonding", NULL);
>-
>- if (!bonding_debug_root)
>- pr_warn("Warning: Cannot create bonding directory in debugfs\n");
> }
>
> void bond_destroy_debugfs(void)
>--
>2.25.1
>

---
-Jay Vosburgh, [email protected]