2023-09-21 00:23:24

by Konrad Dybcio

Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm4450: Add RPMH and Global clock controller

On 9/8/23 08:58, Tengfei Fan wrote:
> From: Ajit Pandey <[email protected]>
>
> Add device node for RPMH and Global clock controller on Qualcomm
> SM4450 platform.
>
> Signed-off-by: Ajit Pandey <[email protected]>
> Signed-off-by: Tengfei Fan <[email protected]>
> ---
> arch/arm64/boot/dts/qcom/sm4450.dtsi | 18 ++++++++++++++++++
> 1 file changed, 18 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi b/arch/arm64/boot/dts/qcom/sm4450.dtsi
> index eb544d875806..2395b1d655a2 100644
> --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
> @@ -3,6 +3,8 @@
> * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights reserved.
> */
>
> +#include <dt-bindings/clock/qcom,rpmh.h>
> +#include <dt-bindings/clock/qcom,sm4450-gcc.h>
> #include <dt-bindings/gpio/gpio.h>
> #include <dt-bindings/interrupt-controller/arm-gic.h>
> #include <dt-bindings/soc/qcom,rpmh-rsc.h>
> @@ -367,6 +369,22 @@
> apps_bcm_voter: bcm-voter {
> compatible = "qcom,bcm-voter";
> };
> +
> + rpmhcc: clock-controller {
> + compatible = "qcom,sm4450-rpmh-clk";
> + #clock-cells = <1>;
> + clock-names = "xo";
> + clocks = <&xo_board>;
property
property-names

please

Konrad

2023-09-22 10:34:33

by Tengfei Fan

Subject: Re: [PATCH 5/6] arm64: dts: qcom: sm4450: Add RPMH and Global clock controller

在 9/20/2023 10:33 PM, Konrad Dybcio 写道:
>
>
> On 9/8/23 08:58, Tengfei Fan wrote:
>> From: Ajit Pandey <[email protected]>
>>
>> Add device node for RPMH and Global clock controller on Qualcomm
>> SM4450 platform.
>>
>> Signed-off-by: Ajit Pandey <[email protected]>
>> Signed-off-by: Tengfei Fan <[email protected]>
>> ---
>>   arch/arm64/boot/dts/qcom/sm4450.dtsi | 18 ++++++++++++++++++
>>   1 file changed, 18 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> b/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> index eb544d875806..2395b1d655a2 100644
>> --- a/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sm4450.dtsi
>> @@ -3,6 +3,8 @@
>>    * Copyright (c) 2023, Qualcomm Innovation Center, Inc. All rights
>> reserved.
>>    */
>> +#include <dt-bindings/clock/qcom,rpmh.h>
>> +#include <dt-bindings/clock/qcom,sm4450-gcc.h>
>>   #include <dt-bindings/gpio/gpio.h>
>>   #include <dt-bindings/interrupt-controller/arm-gic.h>
>>   #include <dt-bindings/soc/qcom,rpmh-rsc.h>
>> @@ -367,6 +369,22 @@
>>               apps_bcm_voter: bcm-voter {
>>                   compatible = "qcom,bcm-voter";
>>               };
>> +
>> +            rpmhcc: clock-controller {
>> +                compatible = "qcom,sm4450-rpmh-clk";
>> +                #clock-cells = <1>;
>> +                clock-names = "xo";
>> +                clocks = <&xo_board>;
> property
> property-names
>
> please
>
> Konrad
Hi Konrad,
I will adjust these nodes.

--
Thx and BRs,
Tengfei Fan