2021-11-11 18:37:33

by Konrad Dybcio

Subject: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

The source group count was mistakenly assigned to both dst and src loops.
Fix it to make IPA probe and work again.

Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
Acked-by: AngeloGioacchino Del Regno <[email protected]>
Reviewed-by: Marijn Suijten <[email protected]>
Signed-off-by: Konrad Dybcio <[email protected]>
---
Changes since v1:
- Add a "Fixes:" tag, R-b, A-b and fix up the commit message
drivers/net/ipa/ipa_resource.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
index e3da95d69409..06cec7199382 100644
--- a/drivers/net/ipa/ipa_resource.c
+++ b/drivers/net/ipa/ipa_resource.c
@@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
return false;
}

- group_count = data->rsrc_group_src_count;
+ group_count = data->rsrc_group_dst_count;
if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
return false;

--
2.33.0

2021-11-11 21:25:29

by Alex Elder

Subject: Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

On 11/11/21 12:37 PM, Konrad Dybcio wrote:
> The source group count was mistakenly assigned to both dst and src loops.
> Fix it to make IPA probe and work again.

Looks good. Oops.

Reviewed-by: Alex Elder <[email protected]>

>
> Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
> Acked-by: AngeloGioacchino Del Regno <[email protected]>
> Reviewed-by: Marijn Suijten <[email protected]>
> Signed-off-by: Konrad Dybcio <[email protected]>
> ---
> Changes since v1:
> - Add a "Fixes:" tag, R-b, A-b and fix up the commit message
> drivers/net/ipa/ipa_resource.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/ipa/ipa_resource.c b/drivers/net/ipa/ipa_resource.c
> index e3da95d69409..06cec7199382 100644
> --- a/drivers/net/ipa/ipa_resource.c
> +++ b/drivers/net/ipa/ipa_resource.c
> @@ -52,7 +52,7 @@ static bool ipa_resource_limits_valid(struct ipa *ipa,
> return false;
> }
>
> - group_count = data->rsrc_group_src_count;
> + group_count = data->rsrc_group_dst_count;
> if (!group_count || group_count > IPA_RESOURCE_GROUP_MAX)
> return false;
>
>

2021-11-13 04:20:27

by patchwork-bot+netdevbpf

Subject: Re: [PATCH v2] net/ipa: ipa_resource: Fix wrong for loop range

Hello:

This patch was applied to netdev/net.git (master)
by Jakub Kicinski <[email protected]>:

On Thu, 11 Nov 2021 19:37:24 +0100 you wrote:
> The source group count was mistakenly assigned to both dst and src loops.
> Fix it to make IPA probe and work again.
>
> Fixes: 4fd704b3608a ("net: ipa: record number of groups in data")
> Acked-by: AngeloGioacchino Del Regno <[email protected]>
> Reviewed-by: Marijn Suijten <[email protected]>
> Signed-off-by: Konrad Dybcio <[email protected]>
>
> [...]

Here is the summary with links:
- [v2] net/ipa: ipa_resource: Fix wrong for loop range
https://git.kernel.org/netdev/net/c/27df68d579c6

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html