2018-09-19 21:53:03

by Nick Simonov

Subject: [PATCH] ALSA: xen-front: Refine indentations and constify snd_pcm_ops

snd_pcm_ops are not supposed to change. So mark the
non-const structs as const. Also, refine indentation
to ncrease readability.

Signed-off-by: Nick Simonov <[email protected]>
---
sound/xen/xen_snd_front_alsa.c | 46 +++++++++++++++++++++---------------------
1 file changed, 23 insertions(+), 23 deletions(-)

diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
index 129180e..2cbd967 100644
--- a/sound/xen/xen_snd_front_alsa.c
+++ b/sound/xen/xen_snd_front_alsa.c
@@ -637,31 +637,31 @@ static int alsa_pb_fill_silence(struct snd_pcm_substream *substream,
* to know when the buffer can be transferred to the backend.
*/

-static struct snd_pcm_ops snd_drv_alsa_playback_ops = {
- .open = alsa_open,
- .close = alsa_close,
- .ioctl = snd_pcm_lib_ioctl,
- .hw_params = alsa_hw_params,
- .hw_free = alsa_hw_free,
- .prepare = alsa_prepare,
- .trigger = alsa_trigger,
- .pointer = alsa_pointer,
- .copy_user = alsa_pb_copy_user,
- .copy_kernel = alsa_pb_copy_kernel,
- .fill_silence = alsa_pb_fill_silence,
+static const struct snd_pcm_ops snd_drv_alsa_playback_ops = {
+ .open = alsa_open,
+ .close = alsa_close,
+ .ioctl = snd_pcm_lib_ioctl,
+ .hw_params = alsa_hw_params,
+ .hw_free = alsa_hw_free,
+ .prepare = alsa_prepare,
+ .trigger = alsa_trigger,
+ .pointer = alsa_pointer,
+ .copy_user = alsa_pb_copy_user,
+ .copy_kernel = alsa_pb_copy_kernel,
+ .fill_silence = alsa_pb_fill_silence,
};

-static struct snd_pcm_ops snd_drv_alsa_capture_ops = {
- .open = alsa_open,
- .close = alsa_close,
- .ioctl = snd_pcm_lib_ioctl,
- .hw_params = alsa_hw_params,
- .hw_free = alsa_hw_free,
- .prepare = alsa_prepare,
- .trigger = alsa_trigger,
- .pointer = alsa_pointer,
- .copy_user = alsa_cap_copy_user,
- .copy_kernel = alsa_cap_copy_kernel,
+static const struct snd_pcm_ops snd_drv_alsa_capture_ops = {
+ .open = alsa_open,
+ .close = alsa_close,
+ .ioctl = snd_pcm_lib_ioctl,
+ .hw_params = alsa_hw_params,
+ .hw_free = alsa_hw_free,
+ .prepare = alsa_prepare,
+ .trigger = alsa_trigger,
+ .pointer = alsa_pointer,
+ .copy_user = alsa_cap_copy_user,
+ .copy_kernel = alsa_cap_copy_kernel,
};

static int new_pcm_instance(struct xen_snd_front_card_info *card_info,
--
2.7.4

2018-09-20 05:18:55

by Oleksandr Andrushchenko

Subject: Re: [PATCH] ALSA: xen-front: Refine indentations and constify snd_pcm_ops

On 09/20/2018 12:47 AM, Nick Simonov wrote:
> snd_pcm_ops are not supposed to change. So mark the
> non-const structs as const. Also, refine indentation
> to ncrease readability.
>
> Signed-off-by: Nick Simonov <[email protected]>
> ---
> sound/xen/xen_snd_front_alsa.c | 46 +++++++++++++++++++++---------------------
> 1 file changed, 23 insertions(+), 23 deletions(-)
>
> diff --git a/sound/xen/xen_snd_front_alsa.c b/sound/xen/xen_snd_front_alsa.c
> index 129180e..2cbd967 100644
> --- a/sound/xen/xen_snd_front_alsa.c
> +++ b/sound/xen/xen_snd_front_alsa.c
> @@ -637,31 +637,31 @@ static int alsa_pb_fill_silence(struct snd_pcm_substream *substream,
> * to know when the buffer can be transferred to the backend.
> */
>
> -static struct snd_pcm_ops snd_drv_alsa_playback_ops = {
> - .open = alsa_open,
> - .close = alsa_close,
> - .ioctl = snd_pcm_lib_ioctl,
> - .hw_params = alsa_hw_params,
> - .hw_free = alsa_hw_free,
> - .prepare = alsa_prepare,
> - .trigger = alsa_trigger,
> - .pointer = alsa_pointer,
> - .copy_user = alsa_pb_copy_user,
> - .copy_kernel = alsa_pb_copy_kernel,
> - .fill_silence = alsa_pb_fill_silence,
> +static const struct snd_pcm_ops snd_drv_alsa_playback_ops = {
> + .open = alsa_open,
> + .close = alsa_close,
> + .ioctl = snd_pcm_lib_ioctl,
> + .hw_params = alsa_hw_params,
> + .hw_free = alsa_hw_free,
> + .prepare = alsa_prepare,
> + .trigger = alsa_trigger,
> + .pointer = alsa_pointer,
> + .copy_user = alsa_pb_copy_user,
> + .copy_kernel = alsa_pb_copy_kernel,
> + .fill_silence = alsa_pb_fill_silence,
> };
>
> -static struct snd_pcm_ops snd_drv_alsa_capture_ops = {
> - .open = alsa_open,
> - .close = alsa_close,
> - .ioctl = snd_pcm_lib_ioctl,
> - .hw_params = alsa_hw_params,
> - .hw_free = alsa_hw_free,
> - .prepare = alsa_prepare,
> - .trigger = alsa_trigger,
> - .pointer = alsa_pointer,
> - .copy_user = alsa_cap_copy_user,
> - .copy_kernel = alsa_cap_copy_kernel,
> +static const struct snd_pcm_ops snd_drv_alsa_capture_ops = {
> + .open = alsa_open,
> + .close = alsa_close,
> + .ioctl = snd_pcm_lib_ioctl,
> + .hw_params = alsa_hw_params,
> + .hw_free = alsa_hw_free,
> + .prepare = alsa_prepare,
> + .trigger = alsa_trigger,
> + .pointer = alsa_pointer,
> + .copy_user = alsa_cap_copy_user,
> + .copy_kernel = alsa_cap_copy_kernel,
> };
>
> static int new_pcm_instance(struct xen_snd_front_card_info *card_info,
Thank you for the patch,
Reviewed-by: Oleksandr Andrushchenko <[email protected]>

2018-09-20 07:16:24

by Takashi Iwai

Subject: Re: [PATCH] ALSA: xen-front: Refine indentations and constify snd_pcm_ops

On Wed, 19 Sep 2018 23:47:10 +0200,
Nick Simonov wrote:
>
> snd_pcm_ops are not supposed to change. So mark the
> non-const structs as const. Also, refine indentation
> to ncrease readability.
>
> Signed-off-by: Nick Simonov <[email protected]>

Applied now, thanks.


Takashi