Fix memory leak in cpufreq stats.
When system enter sleep, non-boot CPUs will be disable.
Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
the CPU going down. This will cause memory leak.
signed-off-by: xiaobing tu <[email protected]>
signed-off-by: guifang tang <[email protected]>
diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
index b40ee14..3998316 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
cpufreq_update_policy(cpu);
break;
case CPU_DOWN_PREPARE:
+ case CPU_DOWN_PREPARE_FROZEN:
cpufreq_stats_free_sysfs(cpu);
break;
case CPU_DEAD:
Br
XiaoBing Tu
PSI@System Integration Shanghai
+alex
-----Original Message-----
From: Tu, Xiaobing
Sent: Monday, October 15, 2012 10:48 AM
To: '[email protected]'; '[email protected]'; '[email protected]'; '[email protected]'; '[email protected]'; '[email protected]'; '[email protected]'
Cc: Tang, Guifang; Tu, Xiaobing
Subject: Fix memory leak in cpufreq stats.
Fix memory leak in cpufreq stats.
When system enter sleep, non-boot CPUs will be disable.
Cpufreq stats sysfs is created when the CPU is up, but it is not freed when the CPU going down. This will cause memory leak.
signed-off-by: xiaobing tu <[email protected]>
signed-off-by: guifang tang <[email protected]>
diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c index b40ee14..3998316 100644
--- a/drivers/cpufreq/cpufreq_stats.c
+++ b/drivers/cpufreq/cpufreq_stats.c
@@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
cpufreq_update_policy(cpu);
break;
case CPU_DOWN_PREPARE:
+ case CPU_DOWN_PREPARE_FROZEN:
cpufreq_stats_free_sysfs(cpu);
break;
case CPU_DEAD:
Br
XiaoBing Tu
PSI@System Integration Shanghai
On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
>
> Fix memory leak in cpufreq stats.
>
> When system enter sleep, non-boot CPUs will be disable.
> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
> the CPU going down. This will cause memory leak.
> signed-off-by: xiaobing tu <[email protected]>
> signed-off-by: guifang tang <[email protected]>
I will push this patch for v3.7 in the -rc3 time frame if no one objects.
Thanks,
Rafael
> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> index b40ee14..3998316 100644
> --- a/drivers/cpufreq/cpufreq_stats.c
> +++ b/drivers/cpufreq/cpufreq_stats.c
> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> cpufreq_update_policy(cpu);
> break;
> case CPU_DOWN_PREPARE:
> + case CPU_DOWN_PREPARE_FROZEN:
> cpufreq_stats_free_sysfs(cpu);
> break;
> case CPU_DEAD:
>
> Br
> XiaoBing Tu
> PSI@System Integration Shanghai
>
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to [email protected]
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki <[email protected]> wrote:
> On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
>>
>> Fix memory leak in cpufreq stats.
>>
>> When system enter sleep, non-boot CPUs will be disable.
>> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
>> the CPU going down. This will cause memory leak.
>> signed-off-by: xiaobing tu <[email protected]>
>> signed-off-by: guifang tang <[email protected]>
>
> I will push this patch for v3.7 in the -rc3 time frame if no one objects.
>
> Thanks,
> Rafael
>
>
>> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
>> index b40ee14..3998316 100644
>> --- a/drivers/cpufreq/cpufreq_stats.c
>> +++ b/drivers/cpufreq/cpufreq_stats.c
>> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
>> cpufreq_update_policy(cpu);
>> break;
>> case CPU_DOWN_PREPARE:
>> + case CPU_DOWN_PREPARE_FROZEN:
>> cpufreq_stats_free_sysfs(cpu);
>> break;
>> case CPU_DEAD:
>>
>> Br
>> XiaoBing Tu
>> PSI@System Integration Shanghai
This patch, commited as e37736777254ce1abc85493a5cacbefe5983b896 since
v3.7, should also have gone to stable. It should apply all the way
back to 3.0.
On Mon, Mar 11, 2013 at 06:23:27PM -0700, Colin Cross wrote:
> On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki <[email protected]> wrote:
> > On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
> >>
> >> Fix memory leak in cpufreq stats.
> >>
> >> When system enter sleep, non-boot CPUs will be disable.
> >> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
> >> the CPU going down. This will cause memory leak.
> >> signed-off-by: xiaobing tu <[email protected]>
> >> signed-off-by: guifang tang <[email protected]>
> >
> > I will push this patch for v3.7 in the -rc3 time frame if no one objects.
> >
> > Thanks,
> > Rafael
> >
> >
> >> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> >> index b40ee14..3998316 100644
> >> --- a/drivers/cpufreq/cpufreq_stats.c
> >> +++ b/drivers/cpufreq/cpufreq_stats.c
> >> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> >> cpufreq_update_policy(cpu);
> >> break;
> >> case CPU_DOWN_PREPARE:
> >> + case CPU_DOWN_PREPARE_FROZEN:
> >> cpufreq_stats_free_sysfs(cpu);
> >> break;
> >> case CPU_DEAD:
> >>
> >> Br
> >> XiaoBing Tu
> >> PSI@System Integration Shanghai
>
> This patch, commited as e37736777254ce1abc85493a5cacbefe5983b896 since
> v3.7, should also have gone to stable. It should apply all the way
> back to 3.0.
Thanks, I'm queuing it for the 3.5 kernel.
Cheers,
--
Luis
On Mon, 2013-03-11 at 18:23 -0700, Colin Cross wrote:
> On Mon, Oct 15, 2012 at 1:30 PM, Rafael J. Wysocki <[email protected]> wrote:
> > On Monday 15 of October 2012 02:48:28 Tu, Xiaobing wrote:
> >>
> >> Fix memory leak in cpufreq stats.
> >>
> >> When system enter sleep, non-boot CPUs will be disable.
> >> Cpufreq stats sysfs is created when the CPU is up, but it is not freed when
> >> the CPU going down. This will cause memory leak.
> >> signed-off-by: xiaobing tu <[email protected]>
> >> signed-off-by: guifang tang <[email protected]>
> >
> > I will push this patch for v3.7 in the -rc3 time frame if no one objects.
> >
> > Thanks,
> > Rafael
> >
> >
> >> diff --git a/drivers/cpufreq/cpufreq_stats.c b/drivers/cpufreq/cpufreq_stats.c
> >> index b40ee14..3998316 100644
> >> --- a/drivers/cpufreq/cpufreq_stats.c
> >> +++ b/drivers/cpufreq/cpufreq_stats.c
> >> @@ -328,6 +328,7 @@ static int __cpuinit cpufreq_stat_cpu_callback(struct notifier_block *nfb,
> >> cpufreq_update_policy(cpu);
> >> break;
> >> case CPU_DOWN_PREPARE:
> >> + case CPU_DOWN_PREPARE_FROZEN:
> >> cpufreq_stats_free_sysfs(cpu);
> >> break;
> >> case CPU_DEAD:
> >>
> >> Br
> >> XiaoBing Tu
> >> PSI@System Integration Shanghai
>
> This patch, commited as e37736777254ce1abc85493a5cacbefe5983b896 since
> v3.7, should also have gone to stable. It should apply all the way
> back to 3.0.
Queued up for 3.2, thanks.
Ben.
--
Ben Hutchings
Usenet is essentially a HUGE group of people passing notes in class.
- Rachel Kadel, `A Quick Guide to Newsgroup Etiquette'