2018-03-08 09:39:34

by Arvind Yadav

Subject: [PATCH 0/2] rpmsg: use put_device() if device_register fail

if device_register() returned an error! Always use put_device()
to give up the reference initialized. unregister device for
other return error.


Arvind Yadav (2):
[PATCH 1/2] rpmsg: glink: use put_device() if device_register fail
[PATCH 2/2] rpmsg: smd: use put_device() if device_register fail

drivers/rpmsg/qcom_glink_smem.c | 3 ++-
drivers/rpmsg/qcom_smd.c | 3 ++-
2 files changed, 4 insertions(+), 2 deletions(-)

--
1.9.1

2018-03-08 09:38:33

by Arvind Yadav

Subject: [PATCH 1/2] rpmsg: glink: use put_device() if device_register fail

if device_register() returned an error! Always use put_device()
to give up the reference initialized. And unregister device for
other return error.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/rpmsg/qcom_glink_smem.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rpmsg/qcom_glink_smem.c b/drivers/rpmsg/qcom_glink_smem.c
index 892f2b9..3fa9d43 100644
--- a/drivers/rpmsg/qcom_glink_smem.c
+++ b/drivers/rpmsg/qcom_glink_smem.c
@@ -217,6 +217,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent,
ret = device_register(dev);
if (ret) {
pr_err("failed to register glink edge\n");
+ put_device(dev);
return ERR_PTR(ret);
}

@@ -299,7 +300,7 @@ struct qcom_glink *qcom_glink_smem_register(struct device *parent,
return glink;

err_put_dev:
- put_device(dev);
+ device_unregister(dev);

return ERR_PTR(ret);
}
--
1.9.1

2018-03-08 09:38:47

by Arvind Yadav

Subject: [PATCH 2/2] rpmsg: smd: use put_device() if device_register fail

if device_register() returned an error! Always use put_device()
to give up the reference initialized. unregister device for
other return error.

Signed-off-by: Arvind Yadav <[email protected]>
---
drivers/rpmsg/qcom_smd.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 92d0c6a..ff8101a 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1408,6 +1408,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent,
ret = device_register(&edge->dev);
if (ret) {
pr_err("failed to register smd edge\n");
+ put_device(&edge->dev);
return ERR_PTR(ret);
}

@@ -1428,7 +1429,7 @@ struct qcom_smd_edge *qcom_smd_register_edge(struct device *parent,
return edge;

unregister_dev:
- put_device(&edge->dev);
+ device_unregister(&edge->dev);
return ERR_PTR(ret);
}
EXPORT_SYMBOL(qcom_smd_register_edge);
--
1.9.1

2018-03-18 23:01:12

by Bjorn Andersson

Subject: Re: [PATCH 0/2] rpmsg: use put_device() if device_register fail

On Thu 08 Mar 01:36 PST 2018, Arvind Yadav wrote:

> if device_register() returned an error! Always use put_device()
> to give up the reference initialized. unregister device for
> other return error.
>

Patches applied.

Thanks,
Bjorn

>
> Arvind Yadav (2):
> [PATCH 1/2] rpmsg: glink: use put_device() if device_register fail
> [PATCH 2/2] rpmsg: smd: use put_device() if device_register fail
>
> drivers/rpmsg/qcom_glink_smem.c | 3 ++-
> drivers/rpmsg/qcom_smd.c | 3 ++-
> 2 files changed, 4 insertions(+), 2 deletions(-)
>
> --
> 1.9.1
>