2022-11-02 03:04:26

by Jinlong Chen

Subject: [PATCH v2 0/2] some random cleanups for blk-mq.c

Patch 1 improves the error handling blk_mq_alloc_rq_map(). Patch 2
improves readability of blk_mq_alloc_cached_request().

Changes in v2:
- drop wrong and worthless patches, suggested by Christoph, Jens and
Chaitanya
- remove silly goto-return-NULL in patch 1 (patch 2 originally), suggested
by Christoph and Jens

Jinlong Chen (2):
blk-mq: improve error handling in blk_mq_alloc_rq_map()
blk-mq: use if-else instead of goto in blk_mq_alloc_cached_request()

block/blk-mq.c | 46 ++++++++++++++++++++++++----------------------
1 file changed, 24 insertions(+), 22 deletions(-)

--
2.31.1

2022-11-02 03:51:15

by Jinlong Chen

Subject: Re: [PATCH v2 0/2] some random cleanups for blk-mq.c

> Patch 1 improves the error handling blk_mq_alloc_rq_map(). Patch 2
> improves readability of blk_mq_alloc_cached_request().
>
> Changes in v2:
> - drop wrong and worthless patches, suggested by Christoph, Jens and
> Chaitanya
> - remove silly goto-return-NULL in patch 1 (patch 2 originally), suggested
> by Christoph and Jens
>
> Jinlong Chen (2):
> blk-mq: improve error handling in blk_mq_alloc_rq_map()
> blk-mq: use if-else instead of goto in blk_mq_alloc_cached_request()
>
> block/blk-mq.c | 46 ++++++++++++++++++++++++----------------------
> 1 file changed, 24 insertions(+), 22 deletions(-)


Oops, I forgot the reviewed tag by Christoph!

Sorry!
Jinlong Chen

2022-11-02 15:04:14

by Jens Axboe

Subject: Re: [PATCH v2 0/2] some random cleanups for blk-mq.c

On Wed, 2 Nov 2022 10:52:28 +0800, Jinlong Chen wrote:
> Patch 1 improves the error handling blk_mq_alloc_rq_map(). Patch 2
> improves readability of blk_mq_alloc_cached_request().
>
> Changes in v2:
> - drop wrong and worthless patches, suggested by Christoph, Jens and
> Chaitanya
> - remove silly goto-return-NULL in patch 1 (patch 2 originally), suggested
> by Christoph and Jens
>
> [...]

Applied, thanks!

[1/2] blk-mq: improve error handling in blk_mq_alloc_rq_map()
commit: 7edfd68165b8dab8cde231728ff092a625469eb7
[2/2] blk-mq: use if-else instead of goto in blk_mq_alloc_cached_request()
commit: 4046728253751adb41b05e85ebd686210efde1ad

Best regards,
--
Jens Axboe