2019-04-02 12:29:29

by Christina Quast

Subject: [PATCH] fs: kernfs: Corrected spelling mistake

Signed-off-by: Christina Quast <[email protected]>
---
include/linux/kernfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index c8893f663470..e446ab97ee0c 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -64,7 +64,7 @@ enum kernfs_root_flag {
KERNFS_ROOT_CREATE_DEACTIVATED = 0x0001,

/*
- * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
+ * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
* succeeds regardless of the RW permissions. sysfs had an extra
* layer of enforcement where open(2) fails with -EACCES regardless
* of CAP_DAC_OVERRIDE if the permission doesn't have the
--
2.20.1

2019-04-02 12:05:22

by Mukesh Ojha

Subject: Re: [PATCH] fs: kernfs: Corrected spelling mistake

flies => files

On 4/2/2019 5:14 PM, Christina Quast wrote:
> Signed-off-by: Christina Quast <[email protected]>
Reviewed-by: Mukesh Ojha <[email protected]>

Cheers,
-Mukesh
> ---
> include/linux/kernfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
> index c8893f663470..e446ab97ee0c 100644
> --- a/include/linux/kernfs.h
> +++ b/include/linux/kernfs.h
> @@ -64,7 +64,7 @@ enum kernfs_root_flag {
> KERNFS_ROOT_CREATE_DEACTIVATED = 0x0001,
>
> /*
> - * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
> + * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
> * succeeds regardless of the RW permissions. sysfs had an extra
> * layer of enforcement where open(2) fails with -EACCES regardless
> * of CAP_DAC_OVERRIDE if the permission doesn't have the

2019-04-02 12:07:03

by Greg Kroah-Hartman

Subject: Re: [PATCH] fs: kernfs: Corrected spelling mistake

On Tue, Apr 02, 2019 at 01:44:14PM +0200, Christina Quast wrote:
> Signed-off-by: Christina Quast <[email protected]>

I can't take patches without any changelog text at all, sorry.

Please fix up and resend.

greg k-h

2019-04-02 12:38:19

by Christina Quast

Subject: [PATCH v2] fs: kernfs: Corrected spelling mistake

flies => files

Signed-off-by: Christina Quast <[email protected]>
---
include/linux/kernfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index c8893f663470..e446ab97ee0c 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -64,7 +64,7 @@ enum kernfs_root_flag {
KERNFS_ROOT_CREATE_DEACTIVATED = 0x0001,

/*
- * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
+ * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
* succeeds regardless of the RW permissions. sysfs had an extra
* layer of enforcement where open(2) fails with -EACCES regardless
* of CAP_DAC_OVERRIDE if the permission doesn't have the
--
2.20.1

2019-04-02 13:34:52

by Greg Kroah-Hartman

Subject: Re: [PATCH v2] fs: kernfs: Corrected spelling mistake

On Tue, Apr 02, 2019 at 02:27:06PM +0200, Christina Quast wrote:
> flies => files
>
> Signed-off-by: Christina Quast <[email protected]>
> ---
> include/linux/kernfs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

What changed from v1?

That always goes below the --- line.

Remember, kernel maintainers have the short term memory of a squirrel :)

thanks,

greg k-h

2019-04-02 15:46:09

by Christina Quast

Subject: [PATCH v2] fs: kernfs: Corrected spelling mistake

flies => files

Signed-off-by: Christina Quast <[email protected]>
---

Changes since v1:
* Added changelog text

include/linux/kernfs.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/kernfs.h b/include/linux/kernfs.h
index c8893f663470..e446ab97ee0c 100644
--- a/include/linux/kernfs.h
+++ b/include/linux/kernfs.h
@@ -64,7 +64,7 @@ enum kernfs_root_flag {
KERNFS_ROOT_CREATE_DEACTIVATED = 0x0001,

/*
- * For regular flies, if the opener has CAP_DAC_OVERRIDE, open(2)
+ * For regular files, if the opener has CAP_DAC_OVERRIDE, open(2)
* succeeds regardless of the RW permissions. sysfs had an extra
* layer of enforcement where open(2) fails with -EACCES regardless
* of CAP_DAC_OVERRIDE if the permission doesn't have the
--
2.20.1

2019-04-02 16:00:10

by Joe Perches

Subject: Re: [PATCH v2] fs: kernfs: Corrected spelling mistake

On Tue, 2019-04-02 at 15:08 +0200, Greg Kroah-Hartman wrote:
> Remember, kernel maintainers have the short term memory of a squirrel :)
^ some