This is the third time I send this patch. As I think it is an obvious
improvement, but has not been applied, please tell me what is wrong with
this patch and what I can do better.
PATCH 1: Remove expr_eliminate_dups2() and other related code.
This does not seem to actually affect the behaviour when using Kconfig files
from the mainline kernel. But there is a slight possibility that there are
configuration files in other branches or in other projects that use the Linux
Kernel configuration system that may be affected or may even rely on the
behaviour (although I did not find such a case when doing a quick check on
busybox, uClibc and openwrt). So, there is a tiny chance to break some
very exotic case (on the other hand, it is plausible that it actually fixes
any such case).
PATCH 2: When touching expr.c anyway, fix some comments and convert C99 style
comments to traditional ones.
Martin Walch (2):
kconfig: completely remove expr_eliminate_dups2() and related code
kconfig: trivial - adjust comments
scripts/kconfig/expr.c | 146 +++++++------------------------------------------
scripts/kconfig/expr.h | 3 -
2 files changed, 19 insertions(+), 130 deletions(-)
--
1.8.5.5