LinuxLists.cc - Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote:

Trim the replies and remove unneeded context. You want to get the
attention of other people, not force them to read entire email.

>> + mediatek,gce-client-reg:>> + $ref: /schemas/types.yaml#/definitions/phandle-array
>> + description: The register of display function block to be set by
>> gce.
>> + There are 4 arguments in this property, gce node, subsys id,
>> offset and
>> + register size. The subsys id is defined in the gce header of
>> each chips
>> + include/dt-bindings/gce/<chip>-gce.h, mapping to the register
>> of display
>> + function block.
>> + items:
>> + items:
>> + - description: phandle of GCE
>> + - description: GCE subsys id
>> + - description: register offset
>> + - description: register size
>> + minItems: 7
>> + maxItems: 7
>> +
>
> Hi Rob and krzysztof,
>
> I got the two messages when running dt_binding_check [1]. This binding
> patch was sent previously in [2].
>
> If I remove the following items/minItems/maxItems in the mediatek,gce-
> client property, the two message disappear. I don't know what's wrong
> with the original syntax. Do you have any suggestions for this?
>
> - items:
> - items:
> - - description: phandle of GCE
> - - description: GCE subsys id
> - - description: register offset
> - - description: register size
> - minItems: 7
> - maxItems: 7
>
>
> [1].
> Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.examp
> le.dtb
> /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
> ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
> hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7, 16384,
> 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, 7,
> 45056, 4096, 4294967295, 7, 49152, 4096] is too long
> From schema:

This looks like known issue with phandles with variable number of
arguments. Either we add it to the exceptions or just define it in
reduced way like in other cases - only maxItems: 1 without describing items.

Best regards,
Krzysztof

2023-03-16 06:19:33

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On Wed, 2023-03-15 at 08:16 +0100, Krzysztof Kozlowski wrote:
> On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote:
>
> Trim the replies and remove unneeded context. You want to get the
> attention of other people, not force them to read entire email.
>
> > > + mediatek,gce-client-reg:>> + $ref:
> > > /schemas/types.yaml#/definitions/phandle-array
> > > + description: The register of display function block to be
> > > set by
> > > gce.
> > > + There are 4 arguments in this property, gce node, subsys
> > > id,
> > > offset and
> > > + register size. The subsys id is defined in the gce header
> > > of
> > > each chips
> > > + include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > > register
> > > of display
> > > + function block.
> > > + items:
> > > + items:
> > > + - description: phandle of GCE
> > > + - description: GCE subsys id
> > > + - description: register offset
> > > + - description: register size
> > > + minItems: 7
> > > + maxItems: 7
> > > +
> >
> > Hi Rob and krzysztof,
> >
> > I got the two messages when running dt_binding_check [1]. This
> > binding
> > patch was sent previously in [2].
> >
> > If I remove the following items/minItems/maxItems in the
> > mediatek,gce-
> > client property, the two message disappear. I don't know what's
> > wrong
> > with the original syntax. Do you have any suggestions for this?
> >
> > - items:
> > - items:
> > - - description: phandle of GCE
> > - - description: GCE subsys id
> > - - description: register offset
> > - - description: register size
> > - minItems: 7
> > - maxItems: 7
> >
> >
> > [1].
> > Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
> > xamp
> > le.dtb
> > /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi
> > cetr
> > ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
> > hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7,
> > 16384,
> > 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
> > 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295,
> > 7,
> > 45056, 4096, 4294967295, 7, 49152, 4096] is too long
> > From schema:
>
> This looks like known issue with phandles with variable number of
> arguments. Either we add it to the exceptions or just define it in
> reduced way like in other cases - only maxItems: 1 without describing
> items.
>
>
> Best regards,
> Krzysztof

Hi Krzysztof,

Thanks for the comment.

But I have several items for this vendor property in the binding
example.
Can I remove maxItems? Change the mediatek,gce-client-reg as [1].

[1]
mediatek,gce-client-reg:
$ref: /schemas/types.yaml#/definitions/phandle-array
description: The register of display function block to be set by
gce.
There are 4 arguments in this property, gce node, subsys id,
offset and
register size. The subsys id is defined in the gce header of each
chips
include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
display
function block.

Regards,
Nancy

>

2023-03-16 06:31:19

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On 16/03/2023 07:19, Nancy Lin (林欣螢) wrote:
> On Wed, 2023-03-15 at 08:16 +0100, Krzysztof Kozlowski wrote:
>> On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote:
>>
>> Trim the replies and remove unneeded context. You want to get the
>> attention of other people, not force them to read entire email.
>>
>>>> + mediatek,gce-client-reg:>> + $ref:
>>>> /schemas/types.yaml#/definitions/phandle-array
>>>> + description: The register of display function block to be
>>>> set by
>>>> gce.
>>>> + There are 4 arguments in this property, gce node, subsys
>>>> id,
>>>> offset and
>>>> + register size. The subsys id is defined in the gce header
>>>> of
>>>> each chips
>>>> + include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>>> register
>>>> of display
>>>> + function block.
>>>> + items:
>>>> + items:
>>>> + - description: phandle of GCE
>>>> + - description: GCE subsys id
>>>> + - description: register offset
>>>> + - description: register size
>>>> + minItems: 7
>>>> + maxItems: 7
>>>> +
>>>
>>> Hi Rob and krzysztof,
>>>
>>> I got the two messages when running dt_binding_check [1]. This
>>> binding
>>> patch was sent previously in [2].
>>>
>>> If I remove the following items/minItems/maxItems in the
>>> mediatek,gce-
>>> client property, the two message disappear. I don't know what's
>>> wrong
>>> with the original syntax. Do you have any suggestions for this?
>>>
>>> - items:
>>> - items:
>>> - - description: phandle of GCE
>>> - - description: GCE subsys id
>>> - - description: register offset
>>> - - description: register size
>>> - minItems: 7
>>> - maxItems: 7
>>>
>>>
>>> [1].
>>> Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
>>> xamp
>>> le.dtb
>>> /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi
>>> cetr
>>> ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
>>> hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7,
>>> 16384,
>>> 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
>>> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295,
>>> 7,
>>> 45056, 4096, 4294967295, 7, 49152, 4096] is too long
>>> From schema:
>>
>> This looks like known issue with phandles with variable number of
>> arguments. Either we add it to the exceptions or just define it in
>> reduced way like in other cases - only maxItems: 1 without describing
>> items.
>>
>>
>> Best regards,
>> Krzysztof
>
>
> Hi Krzysztof,
>
> Thanks for the comment.
>
> But I have several items for this vendor property in the binding
> example.

Do you? I thought you have one phandle?

> Can I remove maxItems? Change the mediatek,gce-client-reg as [1].
>
> [1]
> mediatek,gce-client-reg:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> description: The register of display function block to be set by
> gce.
> There are 4 arguments in this property, gce node, subsys id,
> offset and
> register size. The subsys id is defined in the gce header of each
> chips
> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
> display
> function block.

No, this needs some constraints.

Best regards,
Krzysztof

2023-03-16 09:54:26

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

Il 16/03/23 07:31, Krzysztof Kozlowski ha scritto:
> On 16/03/2023 07:19, Nancy Lin (林欣螢) wrote:
>> On Wed, 2023-03-15 at 08:16 +0100, Krzysztof Kozlowski wrote:
>>> On 15/03/2023 04:45, Nancy Lin (林欣螢) wrote:
>>>

..snip..

>>>>
>>>>
>>>> [1].
>>>> Documentation/devicetree/bindings/display/mediatek/mediatek,ethdr.e
>>>> xamp
>>>> le.dtb
>>>> /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi
>>>> cetr
>>>> ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
>>>> hdr-engine@1c114000: mediatek,gce-client-reg:0: [4294967295, 7,
>>>> 16384,
>>>> 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
>>>> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295,
>>>> 7,
>>>> 45056, 4096, 4294967295, 7, 49152, 4096] is too long
>>>> From schema:
>>>
>>> This looks like known issue with phandles with variable number of
>>> arguments. Either we add it to the exceptions or just define it in
>>> reduced way like in other cases - only maxItems: 1 without describing
>>> items.
>>>

...

>>
>> But I have several items for this vendor property in the binding
>> example.
>
> Do you? I thought you have one phandle?
>
>> Can I remove maxItems? Change the mediatek,gce-client-reg as [1].
>>
>> [1]
>> mediatek,gce-client-reg:
>> $ref: /schemas/types.yaml#/definitions/phandle-array
>> description: The register of display function block to be set by
>> gce.
>> There are 4 arguments in this property, gce node, subsys id,
>> offset and
>> register size. The subsys id is defined in the gce header of each
>> chips
>> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
>> display
>> function block.
>
> No, this needs some constraints.

Hello Krzysztof, Nancy,

Since this series has reached v29, can we please reach an agreement on the bindings
to use here, so that we can get this finally upstreamed?

I will put some examples to try to get this issue resolved.

### Example 1: Constrain the number of GCE entries to *seven* array elements (7x4!)

mediatek,gce-client-reg:
$ref: /schemas/types.yaml#/definitions/phandle-array
maxItems: 1
description: The register of display function block to be set by gce.
There are 4 arguments in this property, gce node, subsys id, offset and
register size. The subsys id is defined in the gce header of each chips
include/dt-bindings/gce/<chip>-gce.h, mapping to the register of display
function block.
items:
minItems: 28
maxItems: 28
items: <----- this block doesn't seem to get checked :\
- description: phandle of GCE
- description: GCE subsys id
- description: register offset
- description: register size

### Example 2: Don't care about constraining the number of arguments

mediatek,gce-client-reg:
$ref: /schemas/types.yaml#/definitions/phandle-array
maxItems: 1
description: The register of display function block to be set by gce.
There are 4 arguments in this property, gce node, subsys id, offset and
register size. The subsys id is defined in the gce header of each chips
include/dt-bindings/gce/<chip>-gce.h, mapping to the register of display
function block.

Regards,
Angelo

2023-03-16 11:37:28

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:

> Hello Krzysztof, Nancy,
>
> Since this series has reached v29, can we please reach an agreement on the bindings
> to use here, so that we can get this finally upstreamed?
>
> I will put some examples to try to get this issue resolved.
>
> ### Example 1: Constrain the number of GCE entries to *seven* array elements (7x4!)
>
> mediatek,gce-client-reg:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> maxItems: 1
> description: The register of display function block to be set by gce.
> There are 4 arguments in this property, gce node, subsys id, offset and
> register size. The subsys id is defined in the gce header of each chips
> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of display
> function block.
> items:
> minItems: 28
> maxItems: 28
> items: <----- this block doesn't seem to get checked :\
> - description: phandle of GCE
> - description: GCE subsys id
> - description: register offset
> - description: register size

This is what we would like to have but it requires exception in
dtschema. Thus:

>
>
> ### Example 2: Don't care about constraining the number of arguments
>
> mediatek,gce-client-reg:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> maxItems: 1
> description: The register of display function block to be set by gce.
> There are 4 arguments in this property, gce node, subsys id, offset and
> register size. The subsys id is defined in the gce header of each chips
> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of display
> function block.

use this.

Best regards,
Krzysztof

2023-03-17 07:56:40

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
> On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
>
> > Hello Krzysztof, Nancy,
> >
> > Since this series has reached v29, can we please reach an agreement
> > on the bindings
> > to use here, so that we can get this finally upstreamed?
> >
> > I will put some examples to try to get this issue resolved.
> >
> > ### Example 1: Constrain the number of GCE entries to *seven* array
> > elements (7x4!)
> >
> > mediatek,gce-client-reg:
> > $ref: /schemas/types.yaml#/definitions/phandle-array
> > maxItems: 1
> > description: The register of display function block to be set
> > by gce.
> > There are 4 arguments in this property, gce node, subsys id,
> > offset and
> > register size. The subsys id is defined in the gce header of
> > each chips
> > include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > register of display
> > function block.
> > items:
> > minItems: 28
> > maxItems: 28
> > items: <----- this block doesn't seem to
> > get checked :\
> > - description: phandle of GCE
> > - description: GCE subsys id
> > - description: register offset
> > - description: register size
>
> This is what we would like to have but it requires exception in
> dtschema. Thus:
>
> >
> >
> > ### Example 2: Don't care about constraining the number of
> > arguments
> >
> > mediatek,gce-client-reg:
> > $ref: /schemas/types.yaml#/definitions/phandle-array
> > maxItems: 1
> > description: The register of display function block to be set
> > by gce.
> > There are 4 arguments in this property, gce node, subsys id,
> > offset and
> > register size. The subsys id is defined in the gce header of
> > each chips
> > include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > register of display
> > function block.
>
> use this.
>
> Best regards,
> Krzysztof

Hi Krzysztof, Angelo,

Thanks for the comment.
The Example 2 can pass dt_binding_check.

But the example in the binding has 7 items [1] and dts [2]. Does the
"maxItems: 1" affect any other schema or dts check?

[1]
+ mediatek,gce-client-reg = <&gce0 SUBSYS_1c11XXXX 0x4000 0x1000>,
+ <&gce0 SUBSYS_1c11XXXX 0x5000 0x1000>,
+ <&gce0 SUBSYS_1c11XXXX 0x7000 0x1000>,
+ <&gce0 SUBSYS_1c11XXXX 0x9000 0x1000>,
+ <&gce0 SUBSYS_1c11XXXX 0xa000 0x1000>,
+ <&gce0 SUBSYS_1c11XXXX 0xb000 0x1000>,
+ <&gce0 SUBSYS_1c11XXXX 0xc000 0x1000>;
>

[2] [v21,25/25] arm64: dts: mt8195: add display node for vdosys1

https://patchwork.kernel.org/project/linux-mediatek/patch/[email protected]/

Regards,
Nancy

2023-03-17 09:05:53

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On 17/03/2023 08:55, Nancy Lin (林欣螢) wrote:
> On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
>> On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
>>
>>> Hello Krzysztof, Nancy,
>>>
>>> Since this series has reached v29, can we please reach an agreement
>>> on the bindings
>>> to use here, so that we can get this finally upstreamed?
>>>
>>> I will put some examples to try to get this issue resolved.
>>>
>>> ### Example 1: Constrain the number of GCE entries to *seven* array
>>> elements (7x4!)
>>>
>>> mediatek,gce-client-reg:
>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>> maxItems: 1
>>> description: The register of display function block to be set
>>> by gce.
>>> There are 4 arguments in this property, gce node, subsys id,
>>> offset and
>>> register size. The subsys id is defined in the gce header of
>>> each chips
>>> include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>> register of display
>>> function block.
>>> items:
>>> minItems: 28
>>> maxItems: 28
>>> items: <----- this block doesn't seem to
>>> get checked :\
>>> - description: phandle of GCE
>>> - description: GCE subsys id
>>> - description: register offset
>>> - description: register size
>>
>> This is what we would like to have but it requires exception in
>> dtschema. Thus:
>>
>>>
>>>
>>> ### Example 2: Don't care about constraining the number of
>>> arguments
>>>
>>> mediatek,gce-client-reg:
>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>> maxItems: 1
>>> description: The register of display function block to be set
>>> by gce.
>>> There are 4 arguments in this property, gce node, subsys id,
>>> offset and
>>> register size. The subsys id is defined in the gce header of
>>> each chips
>>> include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>> register of display
>>> function block.
>>
>> use this.
>>
>> Best regards,
>> Krzysztof
>
>
> Hi Krzysztof, Angelo,
>
> Thanks for the comment.
> The Example 2 can pass dt_binding_check.
>
> But the example in the binding has 7 items [1] and dts [2]. Does the
> "maxItems: 1" affect any other schema or dts check?

Ah, then it should be maxItems: 7, not 1.

Best regards,
Krzysztof

2023-03-17 09:38:07

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

Il 17/03/23 10:03, Krzysztof Kozlowski ha scritto:
> On 17/03/2023 08:55, Nancy Lin (林欣螢) wrote:
>> On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
>>> On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
>>>
>>>> Hello Krzysztof, Nancy,
>>>>
>>>> Since this series has reached v29, can we please reach an agreement
>>>> on the bindings
>>>> to use here, so that we can get this finally upstreamed?
>>>>
>>>> I will put some examples to try to get this issue resolved.
>>>>
>>>> ### Example 1: Constrain the number of GCE entries to *seven* array
>>>> elements (7x4!)
>>>>
>>>> mediatek,gce-client-reg:
>>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>>> maxItems: 1
>>>> description: The register of display function block to be set
>>>> by gce.
>>>> There are 4 arguments in this property, gce node, subsys id,
>>>> offset and
>>>> register size. The subsys id is defined in the gce header of
>>>> each chips
>>>> include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>>> register of display
>>>> function block.
>>>> items:
>>>> minItems: 28
>>>> maxItems: 28
>>>> items: <----- this block doesn't seem to
>>>> get checked :\
>>>> - description: phandle of GCE
>>>> - description: GCE subsys id
>>>> - description: register offset
>>>> - description: register size
>>>
>>> This is what we would like to have but it requires exception in
>>> dtschema. Thus:
>>>
>>>>
>>>>
>>>> ### Example 2: Don't care about constraining the number of
>>>> arguments
>>>>
>>>> mediatek,gce-client-reg:
>>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>>> maxItems: 1
>>>> description: The register of display function block to be set
>>>> by gce.
>>>> There are 4 arguments in this property, gce node, subsys id,
>>>> offset and
>>>> register size. The subsys id is defined in the gce header of
>>>> each chips
>>>> include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>>> register of display
>>>> function block.
>>>
>>> use this.
>>>
>>> Best regards,
>>> Krzysztof
>>
>>
>> Hi Krzysztof, Angelo,
>>
>> Thanks for the comment.
>> The Example 2 can pass dt_binding_check.
>>
>> But the example in the binding has 7 items [1] and dts [2]. Does the
>> "maxItems: 1" affect any other schema or dts check?
>
> Ah, then it should be maxItems: 7, not 1.
>

Keep in mind for your v30:

maxItems: 7 will pass - but only if minItems is *not* 7 :-)

-> (so, do not declare minItems, as default is 1) <-

Regards,
Angelo

> Best regards,
> Krzysztof
>

2023-03-17 09:52:46

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

On Fri, 2023-03-17 at 10:37 +0100, AngeloGioacchino Del Regno wrote:
> Il 17/03/23 10:03, Krzysztof Kozlowski ha scritto:
> > On 17/03/2023 08:55, Nancy Lin (林欣螢) wrote:
> > > On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
> > > > On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
> > > >
> > > > > Hello Krzysztof, Nancy,
> > > > >
> > > > > Since this series has reached v29, can we please reach an
> > > > > agreement
> > > > > on the bindings
> > > > > to use here, so that we can get this finally upstreamed?
> > > > >
> > > > > I will put some examples to try to get this issue resolved.
> > > > >
> > > > > ### Example 1: Constrain the number of GCE entries to *seven*
> > > > > array
> > > > > elements (7x4!)
> > > > >
> > > > > mediatek,gce-client-reg:
> > > > > $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > > maxItems: 1
> > > > > description: The register of display function block to
> > > > > be set
> > > > > by gce.
> > > > > There are 4 arguments in this property, gce node,
> > > > > subsys id,
> > > > > offset and
> > > > > register size. The subsys id is defined in the gce
> > > > > header of
> > > > > each chips
> > > > > include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > > > > register of display
> > > > > function block.
> > > > > items:
> > > > > minItems: 28
> > > > > maxItems: 28
> > > > > items: <----- this block doesn't
> > > > > seem to
> > > > > get checked :\
> > > > > - description: phandle of GCE
> > > > > - description: GCE subsys id
> > > > > - description: register offset
> > > > > - description: register size
> > > >
> > > > This is what we would like to have but it requires exception in
> > > > dtschema. Thus:
> > > >
> > > > >
> > > > >
> > > > > ### Example 2: Don't care about constraining the number of
> > > > > arguments
> > > > >
> > > > > mediatek,gce-client-reg:
> > > > > $ref: /schemas/types.yaml#/definitions/phandle-array
> > > > > maxItems: 1
> > > > > description: The register of display function block to
> > > > > be set
> > > > > by gce.
> > > > > There are 4 arguments in this property, gce node,
> > > > > subsys id,
> > > > > offset and
> > > > > register size. The subsys id is defined in the gce
> > > > > header of
> > > > > each chips
> > > > > include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > > > > register of display
> > > > > function block.
> > > >
> > > > use this.
> > > >
> > > > Best regards,
> > > > Krzysztof
> > >
> > >
> > > Hi Krzysztof, Angelo,
> > >
> > > Thanks for the comment.
> > > The Example 2 can pass dt_binding_check.
> > >
> > > But the example in the binding has 7 items [1] and dts [2]. Does
> > > the
> > > "maxItems: 1" affect any other schema or dts check?
> >
> > Ah, then it should be maxItems: 7, not 1.
> >
>
> Keep in mind for your v30:
>
> maxItems: 7 will pass - but only if minItems is *not* 7 :-)
>
> -> (so, do not declare minItems, as default is 1) <-
>
> Regards,
> Angelo
>
Hi Angelo,

I still have one message [1] when runing dt_binding_check for "example
2 + maxItems: 7" [2].

[1]
/proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
hdr-engine@1c114000: mediatek,gce-client-reg: [[4294967295, 7, 16384,
4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, 7,
45056, 4096, 4294967295, 7, 49152, 4096]] is too short

[2]
mediatek,gce-client-reg:
$ref: /schemas/types.yaml#/definitions/phandle-array
maxItems: 7
description: The register of display function block to be set by
gce.
There are 4 arguments in this property, gce node, subsys id,
offset and
register size. The subsys id is defined in the gce header of
each chips
include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
display
function block.

Regards,
Nancy

> > Best regards,
> > Krzysztof
> >

2023-03-17 09:58:11

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

Il 17/03/23 10:52, Nancy Lin (林欣螢) ha scritto:
> On Fri, 2023-03-17 at 10:37 +0100, AngeloGioacchino Del Regno wrote:
>> Il 17/03/23 10:03, Krzysztof Kozlowski ha scritto:
>>> On 17/03/2023 08:55, Nancy Lin (林欣螢) wrote:
>>>> On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
>>>>> On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
>>>>>
>>>>>> Hello Krzysztof, Nancy,
>>>>>>
>>>>>> Since this series has reached v29, can we please reach an
>>>>>> agreement
>>>>>> on the bindings
>>>>>> to use here, so that we can get this finally upstreamed?
>>>>>>
>>>>>> I will put some examples to try to get this issue resolved.
>>>>>>
>>>>>> ### Example 1: Constrain the number of GCE entries to *seven*
>>>>>> array
>>>>>> elements (7x4!)
>>>>>>
>>>>>> mediatek,gce-client-reg:
>>>>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>>>>> maxItems: 1
>>>>>> description: The register of display function block to
>>>>>> be set
>>>>>> by gce.
>>>>>> There are 4 arguments in this property, gce node,
>>>>>> subsys id,
>>>>>> offset and
>>>>>> register size. The subsys id is defined in the gce
>>>>>> header of
>>>>>> each chips
>>>>>> include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>>>>> register of display
>>>>>> function block.
>>>>>> items:
>>>>>> minItems: 28
>>>>>> maxItems: 28
>>>>>> items: <----- this block doesn't
>>>>>> seem to
>>>>>> get checked :\
>>>>>> - description: phandle of GCE
>>>>>> - description: GCE subsys id
>>>>>> - description: register offset
>>>>>> - description: register size
>>>>>
>>>>> This is what we would like to have but it requires exception in
>>>>> dtschema. Thus:
>>>>>
>>>>>>
>>>>>>
>>>>>> ### Example 2: Don't care about constraining the number of
>>>>>> arguments
>>>>>>
>>>>>> mediatek,gce-client-reg:
>>>>>> $ref: /schemas/types.yaml#/definitions/phandle-array
>>>>>> maxItems: 1
>>>>>> description: The register of display function block to
>>>>>> be set
>>>>>> by gce.
>>>>>> There are 4 arguments in this property, gce node,
>>>>>> subsys id,
>>>>>> offset and
>>>>>> register size. The subsys id is defined in the gce
>>>>>> header of
>>>>>> each chips
>>>>>> include/dt-bindings/gce/<chip>-gce.h, mapping to the
>>>>>> register of display
>>>>>> function block.
>>>>>
>>>>> use this.
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>>
>>>> Hi Krzysztof, Angelo,
>>>>
>>>> Thanks for the comment.
>>>> The Example 2 can pass dt_binding_check.
>>>>
>>>> But the example in the binding has 7 items [1] and dts [2]. Does
>>>> the
>>>> "maxItems: 1" affect any other schema or dts check?
>>>
>>> Ah, then it should be maxItems: 7, not 1.
>>>
>>
>> Keep in mind for your v30:
>>
>> maxItems: 7 will pass - but only if minItems is *not* 7 :-)
>>
>> -> (so, do not declare minItems, as default is 1) <-
>>
>> Regards,
>> Angelo
>>
> Hi Angelo,
>
> I still have one message [1] when runing dt_binding_check for "example
> 2 + maxItems: 7" [2].
>
> [1]
> /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devicetr
> ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
> hdr-engine@1c114000: mediatek,gce-client-reg: [[4294967295, 7, 16384,
> 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
> 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295, 7,
> 45056, 4096, 4294967295, 7, 49152, 4096]] is too short
>
>
> [2]
> mediatek,gce-client-reg:
> $ref: /schemas/types.yaml#/definitions/phandle-array
> maxItems: 7
> description: The register of display function block to be set by
> gce.
> There are 4 arguments in this property, gce node, subsys id,
> offset and
> register size. The subsys id is defined in the gce header of
> each chips
> include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
> display
> function block.
>

Maybe I'm wrong about the "do not declare minItems"... try with

minItems: 1
maxItems: 7

...does it work now?

> Regards,
> Nancy
>
>
>>> Best regards,
>>> Krzysztof
>>>

2023-03-21 05:34:14

[permalink] [raw]

Subject: Re: [PATCH v29 1/7] dt-bindings: mediatek: add ethdr definition for mt8195

Dear Angelo,

Sorry for late reply.

On Fri, 2023-03-17 at 10:58 +0100, AngeloGioacchino Del Regno wrote:
> Il 17/03/23 10:52, Nancy Lin (林欣螢) ha scritto:
> > On Fri, 2023-03-17 at 10:37 +0100, AngeloGioacchino Del Regno
> > wrote:
> > > Il 17/03/23 10:03, Krzysztof Kozlowski ha scritto:
> > > > On 17/03/2023 08:55, Nancy Lin (林欣螢) wrote:
> > > > > On Thu, 2023-03-16 at 12:36 +0100, Krzysztof Kozlowski wrote:
> > > > > > On 16/03/2023 10:53, AngeloGioacchino Del Regno wrote:
> > > > > >
> > > > > > > Hello Krzysztof, Nancy,
> > > > > > >
> > > > > > > Since this series has reached v29, can we please reach an
> > > > > > > agreement
> > > > > > > on the bindings
> > > > > > > to use here, so that we can get this finally upstreamed?
> > > > > > >
> > > > > > > I will put some examples to try to get this issue
> > > > > > > resolved.
> > > > > > >
> > > > > > > ### Example 1: Constrain the number of GCE entries to
> > > > > > > *seven*
> > > > > > > array
> > > > > > > elements (7x4!)
> > > > > > >
> > > > > > > mediatek,gce-client-reg:
> > > > > > > $ref: /schemas/types.yaml#/definitions/phandle-
> > > > > > > array
> > > > > > > maxItems: 1
> > > > > > > description: The register of display function
> > > > > > > block to
> > > > > > > be set
> > > > > > > by gce.
> > > > > > > There are 4 arguments in this property, gce
> > > > > > > node,
> > > > > > > subsys id,
> > > > > > > offset and
> > > > > > > register size. The subsys id is defined in the
> > > > > > > gce
> > > > > > > header of
> > > > > > > each chips
> > > > > > > include/dt-bindings/gce/<chip>-gce.h, mapping to
> > > > > > > the
> > > > > > > register of display
> > > > > > > function block.
> > > > > > > items:
> > > > > > > minItems: 28
> > > > > > > maxItems: 28
> > > > > > > items: <----- this block
> > > > > > > doesn't
> > > > > > > seem to
> > > > > > > get checked :\
> > > > > > > - description: phandle of GCE
> > > > > > > - description: GCE subsys id
> > > > > > > - description: register offset
> > > > > > > - description: register size
> > > > > >
> > > > > > This is what we would like to have but it requires
> > > > > > exception in
> > > > > > dtschema. Thus:
> > > > > >
> > > > > > >
> > > > > > >
> > > > > > > ### Example 2: Don't care about constraining the number
> > > > > > > of
> > > > > > > arguments
> > > > > > >
> > > > > > > mediatek,gce-client-reg:
> > > > > > > $ref: /schemas/types.yaml#/definitions/phandle-
> > > > > > > array
> > > > > > > maxItems: 1
> > > > > > > description: The register of display function
> > > > > > > block to
> > > > > > > be set
> > > > > > > by gce.
> > > > > > > There are 4 arguments in this property, gce
> > > > > > > node,
> > > > > > > subsys id,
> > > > > > > offset and
> > > > > > > register size. The subsys id is defined in the
> > > > > > > gce
> > > > > > > header of
> > > > > > > each chips
> > > > > > > include/dt-bindings/gce/<chip>-gce.h, mapping to
> > > > > > > the
> > > > > > > register of display
> > > > > > > function block.
> > > > > >
> > > > > > use this.
> > > > > >
> > > > > > Best regards,
> > > > > > Krzysztof
> > > > >
> > > > >
> > > > > Hi Krzysztof, Angelo,
> > > > >
> > > > > Thanks for the comment.
> > > > > The Example 2 can pass dt_binding_check.
> > > > >
> > > > > But the example in the binding has 7 items [1] and dts [2].
> > > > > Does
> > > > > the
> > > > > "maxItems: 1" affect any other schema or dts check?
> > > >
> > > > Ah, then it should be maxItems: 7, not 1.
> > > >
> > >
> > > Keep in mind for your v30:
> > >
> > > maxItems: 7 will pass - but only if minItems is *not* 7 :-)
> > >
> > > -> (so, do not declare minItems, as default is 1) <-
> > >
> > > Regards,
> > > Angelo
> > >
> >
> > Hi Angelo,
> >
> > I still have one message [1] when runing dt_binding_check for
> > "example
> > 2 + maxItems: 7" [2].
> >
> > [1]
> > /proj/mtk19347/cros/src/third_party/kernel/v5.10/Documentation/devi
> > cetr
> > ee/bindings/display/mediatek/mediatek,ethdr.example.dtb:
> > hdr-engine@1c114000: mediatek,gce-client-reg: [[4294967295, 7,
> > 16384,
> > 4096, 4294967295, 7, 20480, 4096, 4294967295, 7, 28672, 4096,
> > 4294967295, 7, 36864, 4096, 4294967295, 7, 40960, 4096, 4294967295,
> > 7,
> > 45056, 4096, 4294967295, 7, 49152, 4096]] is too short
> >
> >
> > [2]
> > mediatek,gce-client-reg:
> > $ref: /schemas/types.yaml#/definitions/phandle-array
> > maxItems: 7
> > description: The register of display function block to be set
> > by
> > gce.
> > There are 4 arguments in this property, gce node, subsys
> > id,
> > offset and
> > register size. The subsys id is defined in the gce header
> > of
> > each chips
> > include/dt-bindings/gce/<chip>-gce.h, mapping to the
> > register of
> > display
> > function block.
> >
>
> Maybe I'm wrong about the "do not declare minItems"... try with
>
> minItems: 1
> maxItems: 7
>
>
> ...does it work now?
>

Yes, It works well with "example2 + minItems:1 + maxItems: 7" [1]

[1]
mediatek,gce-client-reg:
$ref: /schemas/types.yaml#/definitions/phandle-array
minItems: 1
maxItems: 7
description: The register of display function block to be set by
gce.
There are 4 arguments in this property, gce node, subsys id,
offset and
register size. The subsys id is defined in the gce header of each
chips
include/dt-bindings/gce/<chip>-gce.h, mapping to the register of
display
function block.

Regards,
Nancy

> > Regards,
> > Nancy
> >
> >
> > > > Best regards,
> > > > Krzysztof
> > > >
>
>
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> [email protected]
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

2023-03-21 09:55:17