2023-02-20 23:25:37

by Thomas Weißschuh

Subject: [PATCH] mm: slub: make kobj_type structure constant

Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
the driver core allows the usage of const struct kobj_type.

Take advantage of this to constify the structure definition to prevent
modification at runtime.

Signed-off-by: Thomas Weißschuh <[email protected]>
---
mm/slub.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/slub.c b/mm/slub.c
index 13459c69095a..be710dc4dc3e 100644
--- a/mm/slub.c
+++ b/mm/slub.c
@@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = {
.store = slab_attr_store,
};

-static struct kobj_type slab_ktype = {
+static const struct kobj_type slab_ktype = {
.sysfs_ops = &slab_sysfs_ops,
.release = kmem_cache_release,
};

---
base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f
change-id: 20230220-kobj_type-mm-slub-02d25836de84

Best regards,
--
Thomas Weißschuh <[email protected]>

2023-02-22 11:25:57

by Hyeonggon Yoo

Subject: Re: [PATCH] mm: slub: make kobj_type structure constant

On Mon, Feb 20, 2023 at 11:25:28PM +0000, Thomas Wei?schuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Wei?schuh <[email protected]>
> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 13459c69095a..be710dc4dc3e 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = {
> .store = slab_attr_store,
> };
>
> -static struct kobj_type slab_ktype = {
> +static const struct kobj_type slab_ktype = {
> .sysfs_ops = &slab_sysfs_ops,
> .release = kmem_cache_release,
> };
>
> ---

Acked-by: Hyeonggon Yoo <[email protected]>

Thanks!

> base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f
> change-id: 20230220-kobj_type-mm-slub-02d25836de84
>
> Best regards,
> --
> Thomas Wei?schuh <[email protected]>
>

2023-03-13 16:21:58

by Vlastimil Babka

Subject: Re: [PATCH] mm: slub: make kobj_type structure constant

On 2/21/23 00:25, Thomas Weißschuh wrote:
> Since commit ee6d3dd4ed48 ("driver core: make kobj_type constant.")
> the driver core allows the usage of const struct kobj_type.
>
> Take advantage of this to constify the structure definition to prevent
> modification at runtime.
>
> Signed-off-by: Thomas Weißschuh <[email protected]>

Thanks, added to slab/for-6.4/trivial

> ---
> mm/slub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mm/slub.c b/mm/slub.c
> index 13459c69095a..be710dc4dc3e 100644
> --- a/mm/slub.c
> +++ b/mm/slub.c
> @@ -6058,7 +6058,7 @@ static const struct sysfs_ops slab_sysfs_ops = {
> .store = slab_attr_store,
> };
>
> -static struct kobj_type slab_ktype = {
> +static const struct kobj_type slab_ktype = {
> .sysfs_ops = &slab_sysfs_ops,
> .release = kmem_cache_release,
> };
>
> ---
> base-commit: 5b0ed5964928b0aaf0d644c17c886c7f5ea4bb3f
> change-id: 20230220-kobj_type-mm-slub-02d25836de84
>
> Best regards,