2013-09-04 23:59:29

by Dave Jones

Subject: dvb-usb/technisat-usb2: Fix cut-n-paste thinko

This looks like it was cut and pasted from the code above which does similar checks on txlen,
but someone forgot to change the variable.

Signed-off-by: Dave Jones <[email protected]>

diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c b/drivers/media/usb/dvb-usb/technisat-usb2.c
index 40832a1..98d24ae 100644
--- a/drivers/media/usb/dvb-usb/technisat-usb2.c
+++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
@@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device *udev,
if (rxlen > 62) {
err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
device_addr);
- txlen = 62;
+ rxlen = 62;
}

b[0] = I2C_SPEED_100KHZ_BIT;

2013-09-05 07:28:17

by Patrick Boettcher

Subject: Re: dvb-usb/technisat-usb2: Fix cut-n-paste thinko

Hi Dave,

On Wednesday 04 September 2013 19:59:17 Dave Jones wrote:
> This looks like it was cut and pasted from the code above which does
> similar checks on txlen, but someone forgot to change the variable.

This someone would be me.

> Signed-off-by: Dave Jones <[email protected]>
>
> diff --git a/drivers/media/usb/dvb-usb/technisat-usb2.c
> b/drivers/media/usb/dvb-usb/technisat-usb2.c index 40832a1..98d24ae
> 100644
> --- a/drivers/media/usb/dvb-usb/technisat-usb2.c
> +++ b/drivers/media/usb/dvb-usb/technisat-usb2.c
> @@ -102,7 +102,7 @@ static int technisat_usb2_i2c_access(struct usb_device
> *udev, if (rxlen > 62) {
> err("i2c RX buffer can't exceed 62 bytes (dev 0x%02x)",
> device_addr);
> - txlen = 62;
> + rxlen = 62;
> }
>
> b[0] = I2C_SPEED_100KHZ_BIT;

Nice catch.

Mauro, feel free to add my signed-off-line, when integrating

Signed-off-by: Patrick Boettcher <[email protected]>



--
Patrick