2023-07-19 10:09:36

by Tengfei Fan

Subject: [PATCH 4/5] dt-bindings: arm: qcom: Document SM4450 SoC and boards

Document the SM8450 SoC binding and also the boards using it.

Signed-off-by: Tengfei Fan <[email protected]>
---
Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
index 450f616774e0..691e66612872 100644
--- a/Documentation/devicetree/bindings/arm/qcom.yaml
+++ b/Documentation/devicetree/bindings/arm/qcom.yaml
@@ -83,6 +83,7 @@ description: |
sm8350
sm8450
sm8550
+ sm4450

The 'board' element must be one of the following strings:

@@ -976,6 +977,11 @@ properties:
- qcom,sm8550-qrd
- const: qcom,sm8550

+ - items:
+ - enum:
+ - qcom,sm4450-qrd
+ - const: qcom,sm4450
+
# Board compatibles go above

qcom,msm-id:
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project

2023-07-19 10:28:44

by Dmitry Baryshkov

Subject: Re: [PATCH 4/5] dt-bindings: arm: qcom: Document SM4450 SoC and boards

On 19/07/2023 13:01, Tengfei Fan wrote:
> Document the SM8450 SoC binding and also the boards using it.
>
> Signed-off-by: Tengfei Fan <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..691e66612872 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -83,6 +83,7 @@ description: |
> sm8350
> sm8450
> sm8550
> + sm4450

Please sort properly

>
> The 'board' element must be one of the following strings:
>
> @@ -976,6 +977,11 @@ properties:
> - qcom,sm8550-qrd
> - const: qcom,sm8550
>
> + - items:
> + - enum:
> + - qcom,sm4450-qrd
> + - const: qcom,sm4450
> +

And here

> # Board compatibles go above
>
> qcom,msm-id:

--
With best wishes
Dmitry

2023-07-19 11:05:04

by Krzysztof Kozlowski

Subject: Re: [PATCH 4/5] dt-bindings: arm: qcom: Document SM4450 SoC and boards

On 19/07/2023 12:01, Tengfei Fan wrote:
> Document the SM8450 SoC binding and also the boards using it.
>
> Signed-off-by: Tengfei Fan <[email protected]>
> ---
> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
> index 450f616774e0..691e66612872 100644
> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
> @@ -83,6 +83,7 @@ description: |
> sm8350
> sm8450
> sm8550
> + sm4450
>
> The 'board' element must be one of the following strings:
>
> @@ -976,6 +977,11 @@ properties:
> - qcom,sm8550-qrd
> - const: qcom,sm8550
>
> + - items:
> + - enum:
> + - qcom,sm4450-qrd
> + - const: qcom,sm4450

No, really...

Best regards,
Krzysztof

2023-07-21 02:39:35

by Tengfei Fan

Subject: Re: [PATCH 4/5] dt-bindings: arm: qcom: Document SM4450 SoC and boards

在 7/19/2023 6:15 PM, Dmitry Baryshkov 写道:
> On 19/07/2023 13:01, Tengfei Fan wrote:
>> Document the SM8450 SoC binding and also the boards using it.
>>
>> Signed-off-by: Tengfei Fan <[email protected]>
>> ---
>>   Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>>   1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml
>> b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 450f616774e0..691e66612872 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -83,6 +83,7 @@ description: |
>>           sm8350
>>           sm8450
>>           sm8550
>> +        sm4450
>
> Please sort properly
V2 patch will resort.
>
>>     The 'board' element must be one of the following strings:
>> @@ -976,6 +977,11 @@ properties:
>>                 - qcom,sm8550-qrd
>>             - const: qcom,sm8550
>> +      - items:
>> +          - enum:
>> +              - qcom,sm4450-qrd
>> +          - const: qcom,sm4450
>> +
>
> And here
V2 patch will resort.
>
>>     # Board compatibles go above
>>     qcom,msm-id:
>

--
Thx and BRs,
Tengfei Fan

2023-07-21 03:35:24

by Tengfei Fan

Subject: Re: [PATCH 4/5] dt-bindings: arm: qcom: Document SM4450 SoC and boards

在 7/19/2023 6:24 PM, Krzysztof Kozlowski 写道:
> On 19/07/2023 12:01, Tengfei Fan wrote:
>> Document the SM8450 SoC binding and also the boards using it.
>>
>> Signed-off-by: Tengfei Fan <[email protected]>
>> ---
>> Documentation/devicetree/bindings/arm/qcom.yaml | 6 ++++++
>> 1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/qcom.yaml b/Documentation/devicetree/bindings/arm/qcom.yaml
>> index 450f616774e0..691e66612872 100644
>> --- a/Documentation/devicetree/bindings/arm/qcom.yaml
>> +++ b/Documentation/devicetree/bindings/arm/qcom.yaml
>> @@ -83,6 +83,7 @@ description: |
>> sm8350
>> sm8450
>> sm8550
>> + sm4450
>>
>> The 'board' element must be one of the following strings:
>>
>> @@ -976,6 +977,11 @@ properties:
>> - qcom,sm8550-qrd
>> - const: qcom,sm8550
>>
>> + - items:
>> + - enum:
>> + - qcom,sm4450-qrd
>> + - const: qcom,sm4450
>
> No, really...
V2 patch will resort it.
>
> Best regards,
> Krzysztof
>

--
Thx and BRs,
Tengfei Fan