2005-09-15 05:06:15

by Lukasz Kosewski

[permalink] [raw]
Subject: [PATCH 2.6.14-rc1 1/3] Add disk hotswap support to libata RESEND #3

Patch 1/3 for libata hotswapping. Properly masks out interrupts for
Promise SATAII150 Tx2Plus/Tx4 controllers. More comments in patch
header.

Luke Kosewski


Attachments:
(No filename) (159.00 B)
01-promise_sataII150_support-2.6.14-rc1.diff (6.15 kB)
Download all attachments

2005-09-16 03:08:29

by Jeff Garzik

[permalink] [raw]
Subject: Re: [PATCH 2.6.14-rc1 1/3] Add disk hotswap support to libata RESEND #3

Lukasz Kosewski wrote:
> Patch 1/3 for libata hotswapping. Properly masks out interrupts for
> Promise SATAII150 Tx2Plus/Tx4 controllers. More comments in patch
> header.
>
> Luke Kosewski
>
>
> ------------------------------------------------------------------------
>
> 15.09.05 Luke Kosewski <[email protected]>
>
> * A patch to the sata_promise driver in libata for it to correctly mask
> out hotplug interrupts on SATAII150 Tx4/Tx2 Plus controllers.
> * This is resend #3. It no longer applies to a -mm tree, but to
> 2.6.14-rc1. Therefore, the entry for board_2057x no longer has
> ATA_FLAG_SATA commented out.

You need to add a ->host_stop() hook that frees pdc_host_priv, otherwise
you have a memory leak on module remove/controller unplug.

Once fixed, this patch could go in immediately, it looks like.

Jeff