2014-04-08 17:50:17

by Sam Ravnborg

[permalink] [raw]
Subject: Re: [PATCH] asm-generic/io.h: Add default configuration for readX/writeX_relaxed

On Tue, Apr 08, 2014 at 09:16:01AM +0200, Michal Simek wrote:
> Define default readX/writeX_relaxed IO helper functions
> for all archs which use asm-generic/io.h.
> Using COMPILE_TEST, moving drivers out of arch/arm and
> removing architecture dependencies in Kconfig is causing
> that more and more drivers is using _relaxed IO helper
> functions which is causing compilation failures on architectures
> which don't define them.
>
> Signed-off-by: Michal Simek <[email protected]>

There is a potential cleanup patch for several architectures.
Those that already have similar defines can have them deleted as
they are now provided by the generic version.
Can you try to look into this too?

Sam

2014-04-08 18:08:09

by Michal Simek

[permalink] [raw]
Subject: Re: [PATCH] asm-generic/io.h: Add default configuration for readX/writeX_relaxed

Hi Sam,

On 04/08/2014 07:50 PM, Sam Ravnborg wrote:
> On Tue, Apr 08, 2014 at 09:16:01AM +0200, Michal Simek wrote:
>> Define default readX/writeX_relaxed IO helper functions
>> for all archs which use asm-generic/io.h.
>> Using COMPILE_TEST, moving drivers out of arch/arm and
>> removing architecture dependencies in Kconfig is causing
>> that more and more drivers is using _relaxed IO helper
>> functions which is causing compilation failures on architectures
>> which don't define them.
>>
>> Signed-off-by: Michal Simek <[email protected]>
>
> There is a potential cleanup patch for several architectures.

definitely yes.

> Those that already have similar defines can have them deleted as
> they are now provided by the generic version.
> Can you try to look into this too?

Yes. I wanted to send this out just to know opinion from others.
If this is acceptable, I will look at all archs.
One patch per arch seems to be the best way how to do it.

Thanks,
Michal

--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: http://www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Microblaze cpu - http://www.monstr.eu/fdt/
Maintainer of Linux kernel - Xilinx Zynq ARM architecture
Microblaze U-BOOT custodian and responsible for u-boot arm zynq platform



Attachments:
signature.asc (263.00 B)
OpenPGP digital signature