Hi,
When I check "rockchip,gpio-bank" with YAML it turns out that
rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property.
It is not defined in the "rockchip,pinctrl.txt" document, but in
~/.local/lib/python3.5/site-packages/dtschema/schemas/gpio/gpio.yaml
Where is that in use?
In this driver or external?
Can it be removed from mainline dts?
Johan
/arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml: gpio7@ff7e0000:
'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
From schema:
/Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
On 4/11/21 3:30 PM, Peter Geis wrote:
> From: Jianqun Xu <[email protected]>
>
> Separate the gpio driver from the pinctrl driver.
>
> Signed-off-by: Jianqun Xu <[email protected]>
> ---
Hi Johan,
Am Sonntag, 11. April 2021, 19:51:52 CEST schrieb Johan Jonker:
> Hi,
>
> When I check "rockchip,gpio-bank" with YAML it turns out that
> rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property.
> It is not defined in the "rockchip,pinctrl.txt" document, but in
> ~/.local/lib/python3.5/site-packages/dtschema/schemas/gpio/gpio.yaml
>
> Where is that in use?
> In this driver or external?
> Can it be removed from mainline dts?
gpio-line-names gets defined in devicetree/bindings/gpio/gpio.txt
which isn't converted to yaml yet:
Optionally, a GPIO controller may have a "gpio-line-names" property. This is
an array of strings defining the names of the GPIO lines going out of the
GPIO controller.
So that property is perfectly fine where it is.
Heiko
>
> Johan
>
> /arch/arm/boot/dts/rk3288-veyron-fievel.dt.yaml: gpio7@ff7e0000:
> 'gpio-line-names' does not match any of the regexes: 'pinctrl-[0-9]+'
> From schema:
> /Documentation/devicetree/bindings/gpio/rockchip,gpio-bank.yaml
>
> On 4/11/21 3:30 PM, Peter Geis wrote:
> > From: Jianqun Xu <[email protected]>
> >
> > Separate the gpio driver from the pinctrl driver.
> >
> > Signed-off-by: Jianqun Xu <[email protected]>
> > ---
>
Hi Johan,
On Sun, 11 Apr 2021 at 14:57, Heiko Stübner <[email protected]> wrote:
>
> Hi Johan,
>
> Am Sonntag, 11. April 2021, 19:51:52 CEST schrieb Johan Jonker:
> > Hi,
> >
> > When I check "rockchip,gpio-bank" with YAML it turns out that
> > rk3288-veyron-XXX has 'gpio-line-names' as 'extra' property.
> > It is not defined in the "rockchip,pinctrl.txt" document, but in
> > ~/.local/lib/python3.5/site-packages/dtschema/schemas/gpio/gpio.yaml
> >
> > Where is that in use?
> > In this driver or external?
> > Can it be removed from mainline dts?
>
> gpio-line-names gets defined in devicetree/bindings/gpio/gpio.txt
> which isn't converted to yaml yet:
>
On top of what Heiko says, feel free to convert
Documentation/devicetree/bindings/gpio/gpio.txt to YAML :-)
Thanks!
Ezequiel